New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak uniformity of expression was implemented #10611
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#10610 has been merged. Can you put the following changes into the fix commit? diff --git a/.rubocop.yml b/.rubocop.yml
index 15a364c2a..fff3ec393 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -97,6 +97,7 @@ Metrics/ModuleLength:
- 'spec/**/*.rb'
Naming/InclusiveLanguage:
+ CheckStrings: true
FlaggedTerms:
behaviour:
Suggestions:
@@ -106,6 +107,7 @@ Naming/InclusiveLanguage:
- offense
Exclude:
- lib/rubocop/cop/naming/inclusive_language.rb
+ - spec/rubocop/cop/naming/inclusive_language_spec.rb
RSpec/FilePath:
Exclude: |
Thank you so much. |
This PR is unified word fluctuation. Use "offense" instead of "offence"
Thanks! |
koic
added a commit
to rubocop/rubocop-rails
that referenced
this pull request
May 9, 2022
koic
added a commit
to rubocop/rubocop-performance
that referenced
this pull request
May 9, 2022
koic
added a commit
to rubocop/rubocop-minitest
that referenced
this pull request
May 9, 2022
ydah
added a commit
to ydah/rubocop_challenger
that referenced
this pull request
May 13, 2022
renawatson68
added a commit
to renawatson68/performance-develop-rubyonrails
that referenced
this pull request
Sep 23, 2022
richardstewart0213
added a commit
to richardstewart0213/performance-build-Performance-optimization-analysis-
that referenced
this pull request
Nov 4, 2022
MarttiCheng
added a commit
to MarttiCheng/Rubocop-Performance
that referenced
this pull request
Sep 28, 2023
SerhiiMisiura
added a commit
to SerhiiMisiura/Rubocop-Performance
that referenced
this pull request
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is unified word fluctuation.
Use "offense" instead of "offence"
Before submitting the PR make sure the following are checked:
* [ ] Commit message starts with[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).* [ ] Added tests.bundle exec rake default
. It executes all tests and runs RuboCop on its own code.* [ ] Added an entry (file) to the changelog folder named{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.