Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak uniformity of expression was implemented #10611

Merged
merged 1 commit into from May 9, 2022
Merged

Conversation

ydah
Copy link
Member

@ydah ydah commented May 7, 2022

This PR is unified word fluctuation.
Use "offense" instead of "offence"


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
    * [ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
    * [ ] Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
    * [ ] Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@koic
Copy link
Member

koic commented May 7, 2022

#10610 has been merged. Can you put the following changes into the fix commit?

diff --git a/.rubocop.yml b/.rubocop.yml
index 15a364c2a..fff3ec393 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -97,6 +97,7 @@ Metrics/ModuleLength:
     - 'spec/**/*.rb'

 Naming/InclusiveLanguage:
+  CheckStrings: true
   FlaggedTerms:
     behaviour:
       Suggestions:
@@ -106,6 +107,7 @@ Naming/InclusiveLanguage:
         - offense
   Exclude:
     - lib/rubocop/cop/naming/inclusive_language.rb
+    - spec/rubocop/cop/naming/inclusive_language_spec.rb

 RSpec/FilePath:
   Exclude:

@ydah
Copy link
Member Author

ydah commented May 9, 2022

Thank you so much.
I've added it because it is certainly better that way.

This PR is unified word fluctuation.
Use "offense" instead of "offence"
@koic koic merged commit 60d0c1d into rubocop:master May 9, 2022
@koic
Copy link
Member

koic commented May 9, 2022

Thanks!

@ydah ydah deleted the tweak-word branch May 9, 2022 02:53
koic added a commit to rubocop/rubocop-rails that referenced this pull request May 9, 2022
koic added a commit to rubocop/rubocop-performance that referenced this pull request May 9, 2022
koic added a commit to rubocop/rubocop-minitest that referenced this pull request May 9, 2022
ydah added a commit to ydah/rubocop_challenger that referenced this pull request May 13, 2022
renawatson68 added a commit to renawatson68/performance-develop-rubyonrails that referenced this pull request Sep 23, 2022
richardstewart0213 added a commit to richardstewart0213/performance-build-Performance-optimization-analysis- that referenced this pull request Nov 4, 2022
MarttiCheng added a commit to MarttiCheng/Rubocop-Performance that referenced this pull request Sep 28, 2023
SerhiiMisiura added a commit to SerhiiMisiura/Rubocop-Performance that referenced this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants