Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command line option combination --display-only-fail-level-offenses and -A seems not validated correctly #10536

Closed
nobuyo opened this issue Apr 14, 2022 · 1 comment · Fixed by #10591

Comments

@nobuyo
Copy link
Contributor

nobuyo commented Apr 14, 2022

I think I found a code that references an incorrect key for options.

https://github.com/rubocop/rubocop/blob/master/lib/rubocop/options.rb#L381-L383


Expected behavior

rubocop --display-only-fail-level-offenses -A should return an error and exit.

Actual behavior

rubocop --display-only-fail-level-offenses -A runs without any errors.

Steps to reproduce the problem

Execute the aforementioned command.

RuboCop version

$ [bundle exec] rubocop -V
1.27.0 (using Parser 3.1.1.0, rubocop-ast 1.17.0, running on ruby 2.7.1 x86_64-darwin19)
  - rubocop-performance 1.13.3
  - rubocop-rake 0.6.0
  - rubocop-rspec 2.9.0
@nobuyo nobuyo changed the title Command line option combination --display-only-fail-level-offenses and -A seems not validated correctly. Command line option combination --display-only-fail-level-offenses and -A seems not validated correctly Apr 14, 2022
@nobuyo
Copy link
Contributor Author

nobuyo commented Apr 18, 2022

@bbatsov How should I fix this?
This may be a kind of breaking change for users using the options if fixed🤔

nobuyo added a commit to nobuyo/rubocop that referenced this issue Apr 29, 2022
…on of `--display-only-fail-level-offenses` and `--auto-correct`
bbatsov pushed a commit that referenced this issue Apr 30, 2022
…--display-only-fail-level-offenses` and `--auto-correct`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant