Add logic to ensure badge information (Department/Name) in CamelCase #10271
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enforces the badge information (Department/Name) is stored in CamelCase.
Before, the budge information can be stored in snake_case, and so I could run, for example,
bundle exec rake 'new_cop[ex_snake/case]'
.This, however, creates a file
lib/rubocop/cop/ex_snake/case.rb
with class name in lowercase, and results in syntax error.The expected behavior would be either
A. return error when task is called
orB. create files with CamelCase
This PR implemented
B
I first fixed how the template file is prepared, but noticed that this PR is more straightforward. I recognize that the potential influence can be larger than just fixing template, but I did not find any problem so far. Also this is better solution in a sense that the badge does not expect the infos to be in snake_case.
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.