New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Naming/FileName: make CheckDefinitionPathHierarchy roots configureable #10224
Conversation
9617f68
to
453dc74
Compare
453dc74
to
44384d1
Compare
@dvandersluis could you take a look at this PR plz :) |
@@ -381,9 +381,13 @@ anything/using_snake_case.rake | |||
| `true` | |||
| Boolean | |||
|
|||
| CheckDefinitionPathHierarchyRoots |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cop doc files are generated automatically so should not be included here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how are they generated ? ... on merge or I have to run something ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They’re generated as part of the release process.
Can you please rebase? The specs were changed in #10223 (although magically this doesn't seem to have added a conflict somehow!) Also, please add tests for |
44384d1
to
9aca4fd
Compare
both the "file is under roots" and "file is not under roots" cases are already covered and the test uses the new configuration option ... but added a new test anyway |
good to go ? |
9aca4fd
to
9db9f18
Compare
…y roots configurable
9db9f18
to
9cb95c9
Compare
Thanks @grosser ! |
fixes #10220
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.confirmed that it fixes the issue: