Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an error for Layout/BlockAlignment when using Ruby 3.1.0-dev #10213

Merged

Conversation

koic
Copy link
Member

@koic koic commented Oct 26, 2021

This PR fixes the following build error.

% bundle exec rspec ./spec/rubocop/cop/layout/block_alignment_spec.rb:222
(snip)

      # ./lib/rubocop/cop/layout/block_alignment.rb:97:in `start_for_block_node'
      # ./lib/rubocop/cop/layout/block_alignment.rb:82:in `on_block'
      # ./lib/rubocop/cop/commissioner.rb:100:in `public_send'
      # ./lib/rubocop/cop/commissioner.rb:100:in `block (2 levels) in trigger_responding_cops'
      # ./lib/rubocop/cop/commissioner.rb:160:in `with_cop_error_handling'
      # ./lib/rubocop/cop/commissioner.rb:99:in `block in trigger_responding_cops'

https://app.circleci.com/pipelines/github/rubocop/rubocop/5414/workflows/4a7e4b81-7380-41e5-8ede-e28d9160010d/jobs/201236

I reported on this change of behavior.
https://bugs.ruby-lang.org/issues/18268

And it was due to the following change.
ruby/ruby#1509

This PR will be changed to the cop logic that is not affected by the above Ruby 3.1.0-dev change.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

This PR fixes the following build error.

```console
% bundle exec rspec ./spec/rubocop/cop/layout/block_alignment_spec.rb:222
(snip)

      # ./lib/rubocop/cop/layout/block_alignment.rb:97:in `start_for_block_node'
      # ./lib/rubocop/cop/layout/block_alignment.rb:82:in `on_block'
      # ./lib/rubocop/cop/commissioner.rb:100:in `public_send'
      # ./lib/rubocop/cop/commissioner.rb:100:in `block (2 levels) in trigger_responding_cops'
      # ./lib/rubocop/cop/commissioner.rb:160:in `with_cop_error_handling'
      # ./lib/rubocop/cop/commissioner.rb:99:in `block in trigger_responding_cops'
```

https://app.circleci.com/pipelines/github/rubocop/rubocop/5414/workflows/4a7e4b81-7380-41e5-8ede-e28d9160010d/jobs/201236

I reported on this change of behavior.
https://bugs.ruby-lang.org/issues/18268

And it was due to the following change.
ruby/ruby#1509

This PR will be changed to the cop logic that is not affected by the above Ruby 3.1.0-dev change.
@koic koic merged commit e93f705 into rubocop:master Oct 26, 2021
@koic koic deleted the fix_error_for_layout_block_alignment_using_ruby_31 branch October 26, 2021 08:51
@koic
Copy link
Member Author

koic commented Oct 28, 2021

This PR will be changed to the cop logic that is not affected by the above Ruby 3.1.0-dev change.

NOTE: This behavior has been added to Ruby 3.1's NEWS.
ruby/ruby#5044

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant