Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positive in Layout/DotPosition #10207

Merged
merged 1 commit into from Oct 22, 2021
Merged

Conversation

mvz
Copy link
Contributor

@mvz mvz commented Oct 22, 2021

This fixes a false positive in Layout/DotPosition where an offense would be registered for the trailing style when the receiver was a method call with multiline arguments, and the selector was on the same line as the receiver's closing bracket.

For example, before this change, the following offense would be registered:

foo(
  bar
).baz
 ^ Place the . on the previous line, together with the method call receiver.

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

This fixes a false positive in Layout/DotPosition where an offense would
be registered for the trailing style when the receiver was a method call
with multiline arguments, and the selector was on the same line as the
receiver's closing bracket.

For example, before this change, the following offense would be registered:

    foo(
      bar
    ).baz
     ^ Place the . on the previous line, together with the method call receiver.
Copy link
Collaborator

@Drenmi Drenmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@koic koic merged commit bf18dd3 into rubocop:master Oct 22, 2021
@koic
Copy link
Member

koic commented Oct 22, 2021

Thanks!

@natematykiewicz
Copy link

I was just about to report this. Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants