Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote inherit_from should follow remote includes #10174

Closed
grosser opened this issue Oct 8, 2021 · 0 comments · Fixed by #10233
Closed

remote inherit_from should follow remote includes #10174

grosser opened this issue Oct 8, 2021 · 0 comments · Fixed by #10233
Labels

Comments

@grosser
Copy link
Contributor

grosser commented Oct 8, 2021

Expected behavior

inherit_from:
- https://raw.githubusercontent.com/testdouble/standard/main/config/ruby-2.7.yml

should pull in

inherit_from: ./base.yml

from https://raw.githubusercontent.com/testdouble/standard/main/config/base.yml

Actual behavior

undefined method `request_uri' for #<URI::Generic /testdouble/standard/main/config/base.yml>
/Users/mgrosser/.gem/ruby/2.7.2/gems/rubocop-1.22.1/lib/rubocop/remote_config.rb:56:in `generate_request'
/Users/mgrosser/.gem/ruby/2.7.2/gems/rubocop-1.22.1/lib/rubocop/remote_config.rb:48:in `request'
/Users/mgrosser/.gem/ruby/2.7.2/gems/rubocop-1.22.1/lib/rubocop/remote_config.rb:69:in `handle_response'
/Users/mgrosser/.gem/ruby/2.7.2/gems/rubocop-1.22.1/lib/rubocop/remote_config.rb:49:in `block in request'

Steps to reproduce the problem

use example and run rubocop

RuboCop version

1.22.1 (using Parser 3.0.2.0, rubocop-ast 1.12.0, running on ruby 2.7.2 x86_64-darwin19)
@koic koic added the bug label Oct 8, 2021
hirasawayuki added a commit to hirasawayuki/rubocop that referenced this issue Nov 10, 2021
koic added a commit that referenced this issue Nov 10, 2021
[Fix #10174] Fix inherit_from_remote should follow remote includes path starting with `./`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants