[Fix #10140] Fix false positive for Layout/DotPosition when a heredoc receives a method on the same line as the start sigil in trailing style
#10141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a heredoc receives a method on the same line as the start sigil in `trailing` style.
tjvman
added a commit
to cloudfoundry/cloud_controller_ng
that referenced
this pull request
Sep 29, 2021
Rubocop v1.22.0 changed how DotPosition handled heredocs, but also causes false positives when the method is on the same line as the start of the heredoc. We can remove these disable comments once [this PR](rubocop/rubocop#10141) is merged.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix in #10113 caused a false positive when a heredoc receives a method on the same line as its start, such as
This should not have registered an offense because the dot is on the same line as the receiver.
Fixes #10140.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.