Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a false positive for Layout/SingleLineBlockChain #10063

Conversation

koic
Copy link
Member

@koic koic commented Sep 4, 2021

This PR fixes the following incorrect auto-correct for Layout/SingleLineBlockChain when method call chained on a new line after a single line block with trailing dot.

It also fixes the following incorrect auto-correction between Layout/SingleLineBlockChain and Layout/DotPosition cops.

% cat example.rb
example.select { |item| item.cond? }.
        join('-')
% ruby -c example.rb
Syntax OK
% bundle exec rubocop -a --only Layout/DotPosition,Layout/SingleLineBlockChain example.rb

% cat example.rb
example.select { |item| item.cond? }

        .join('-')
% ruby -c example.rb
example.rb:3: syntax error, unexpected '.', expecting end-of-input
        .join('-')

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

This PR fixes the following incorrect auto-correct for `Layout/SingleLineBlockChain`
when method call chained on a new line after a single line block with trailing dot.

It also fixes the following incorrect auto-correction between `Layout/SingleLineBlockChain`
and `Layout/DotPosition` cops.

```console
% cat example.rb
example.select { |item| item.cond? }.
        join('-')
% ruby -c example.rb
Syntax OK
% bundle exec rubocop -a --only Layout/DotPosition,Layout/SingleLineBlockChain example.rb

% cat example.rb
example.select { |item| item.cond? }

        .join('-')
% ruby -c example.rb
example.rb:3: syntax error, unexpected '.', expecting end-of-input
        .join('-')
```
@koic koic force-pushed the fix_a_false_positive_for_layout_single_line_block_chain branch from d86475c to e834c82 Compare September 4, 2021 11:00
@koic koic merged commit 8585c75 into rubocop:master Sep 6, 2021
@koic koic deleted the fix_a_false_positive_for_layout_single_line_block_chain branch September 6, 2021 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant