From 344a6784ff886166f5a0e3764b7f5310d25a16ab Mon Sep 17 00:00:00 2001 From: Takumasa Ochi Date: Wed, 27 Mar 2019 23:23:26 +0900 Subject: [PATCH] Fix deactivated `StyleGuideBaseURL` for `Layout/ClassStructure` `StyleGuide` config for `Layout/ClassStructure` was written as an absolute URL instead of a relative URL. This prevents custom `StyleGuideBaseURL` from taking precedence over original rubocop-hq URL. This patch fix the issue by specifying fragment as the `StyleGuide` of `Layout/ClassStructure`. --- CHANGELOG.md | 2 ++ config/default.yml | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index dc44d2854a0..fa0e8125687 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,7 @@ * [#6855](https://github.com/rubocop-hq/rubocop/pull/6855): Fix an exception in `Rails/RedundantReceiverInWithOptions` when the body is empty. ([@ericsullivan][]) * [#6856](https://github.com/rubocop-hq/rubocop/pull/6856): Fix auto-correction for `Style/BlockComments` when the file is missing a trailing blank line. ([@ericsullivan][]) * [#6858](https://github.com/rubocop-hq/rubocop/issues/6858): Fix an incorrect auto-correct for `Lint/ToJSON` when there are no `to_json` arguments. ([@koic][]) +* [#6865](https://github.com/rubocop-hq/rubocop/pull/6865): Fix deactivated `StyleGuideBaseURL` for `Layout/ClassStructure`. ([@aeroastro][]) ### Changes @@ -3889,3 +3890,4 @@ [@luciamo]: https://github.com/luciamo [@dirtyharrycallahan]: https://github.com/dirtyharrycallahan [@ericsullivan]: https://github.com/ericsullivan +[@aeroastro]: https://github.com/aeroastro diff --git a/config/default.yml b/config/default.yml index 062897a5cb3..e3015440868 100644 --- a/config/default.yml +++ b/config/default.yml @@ -368,7 +368,7 @@ Layout/CaseIndentation: Layout/ClassStructure: Description: 'Enforces a configured order of definitions within a class body.' - StyleGuide: 'https://github.com/rubocop-hq/ruby-style-guide#consistent-classes' + StyleGuide: '#consistent-classes' Enabled: false VersionAdded: '0.52' Categories: