From 464c4dfe2173176d5b2b471e89f0f3bc19dd604e Mon Sep 17 00:00:00 2001 From: Koichi ITO Date: Sun, 28 Mar 2021 07:14:57 +0900 Subject: [PATCH] Tweak offense message for `Lint/NumberConversion` --- lib/rubocop/cop/lint/number_conversion.rb | 4 +-- .../cop/lint/number_conversion_spec.rb | 28 +++++++++---------- 2 files changed, 16 insertions(+), 16 deletions(-) diff --git a/lib/rubocop/cop/lint/number_conversion.rb b/lib/rubocop/cop/lint/number_conversion.rb index 9ae49cb7c7d..229ace6df96 100644 --- a/lib/rubocop/cop/lint/number_conversion.rb +++ b/lib/rubocop/cop/lint/number_conversion.rb @@ -58,8 +58,8 @@ class NumberConversion < Base }.freeze MSG = 'Replace unsafe number conversion with number '\ 'class parsing, instead of using '\ - '%s, use stricter '\ - '%s.' + '`%s`, use stricter '\ + '`%s`.' METHODS = CONVERSION_METHOD_CLASS_MAPPING.keys.map(&:inspect).join(' ') # @!method to_method(node) diff --git a/spec/rubocop/cop/lint/number_conversion_spec.rb b/spec/rubocop/cop/lint/number_conversion_spec.rb index e628c4074e4..1932f38a22b 100644 --- a/spec/rubocop/cop/lint/number_conversion_spec.rb +++ b/spec/rubocop/cop/lint/number_conversion_spec.rb @@ -5,7 +5,7 @@ it 'when using `#to_i`' do expect_offense(<<~RUBY) "10".to_i - ^^^^^^^^^ Replace unsafe number conversion with number class parsing, instead of using "10".to_i, use stricter Integer("10", 10). + ^^^^^^^^^ Replace unsafe number conversion with number class parsing, instead of using `"10".to_i`, use stricter `Integer("10", 10)`. RUBY expect_correction(<<~RUBY) @@ -16,7 +16,7 @@ it 'when using `#to_i` for integer' do expect_offense(<<~RUBY) 10.to_i - ^^^^^^^ Replace unsafe number conversion with number class parsing, instead of using 10.to_i, use stricter Integer(10, 10). + ^^^^^^^ Replace unsafe number conversion with number class parsing, instead of using `10.to_i`, use stricter `Integer(10, 10)`. RUBY expect_correction(<<~RUBY) @@ -27,7 +27,7 @@ it 'when using `#to_f`' do expect_offense(<<~RUBY) "10.2".to_f - ^^^^^^^^^^^ Replace unsafe number conversion with number class parsing, instead of using "10.2".to_f, use stricter Float("10.2"). + ^^^^^^^^^^^ Replace unsafe number conversion with number class parsing, instead of using `"10.2".to_f`, use stricter `Float("10.2")`. RUBY expect_correction(<<~RUBY) @@ -38,7 +38,7 @@ it 'when using `#to_c`' do expect_offense(<<~RUBY) "10".to_c - ^^^^^^^^^ Replace unsafe number conversion with number class parsing, instead of using "10".to_c, use stricter Complex("10"). + ^^^^^^^^^ Replace unsafe number conversion with number class parsing, instead of using `"10".to_c`, use stricter `Complex("10")`. RUBY expect_correction(<<~RUBY) @@ -50,7 +50,7 @@ expect_offense(<<~RUBY) string_value = '10' string_value.to_i - ^^^^^^^^^^^^^^^^^ Replace unsafe number conversion with number class parsing, instead of using string_value.to_i, use stricter Integer(string_value, 10). + ^^^^^^^^^^^^^^^^^ Replace unsafe number conversion with number class parsing, instead of using `string_value.to_i`, use stricter `Integer(string_value, 10)`. RUBY expect_correction(<<~RUBY) @@ -63,7 +63,7 @@ expect_offense(<<~RUBY) params = { id: 10 } params[:id].to_i - ^^^^^^^^^^^^^^^^ Replace unsafe number conversion with number class parsing, instead of using params[:id].to_i, use stricter Integer(params[:id], 10). + ^^^^^^^^^^^^^^^^ Replace unsafe number conversion with number class parsing, instead of using `params[:id].to_i`, use stricter `Integer(params[:id], 10)`. RUBY expect_correction(<<~RUBY) @@ -76,7 +76,7 @@ expect_offense(<<~RUBY) args = [1,2,3] args[0].to_i - ^^^^^^^^^^^^ Replace unsafe number conversion with number class parsing, instead of using args[0].to_i, use stricter Integer(args[0], 10). + ^^^^^^^^^^^^ Replace unsafe number conversion with number class parsing, instead of using `args[0].to_i`, use stricter `Integer(args[0], 10)`. RUBY expect_correction(<<~RUBY) @@ -88,7 +88,7 @@ it 'when `#to_i` called on a variable on a hash' do expect_offense(<<~RUBY) params[:field].to_i - ^^^^^^^^^^^^^^^^^^^ Replace unsafe number conversion with number class parsing, instead of using params[:field].to_i, use stricter Integer(params[:field], 10). + ^^^^^^^^^^^^^^^^^^^ Replace unsafe number conversion with number class parsing, instead of using `params[:field].to_i`, use stricter `Integer(params[:field], 10)`. RUBY expect_correction(<<~RUBY) @@ -127,7 +127,7 @@ it 'registers offense and autocorrects' do expect_offense(<<~RUBY) "1,2,3,foo,5,6,7,8".split(',').map(&:to_i) - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Replace unsafe number conversion with number class parsing, instead of using &:to_i, use stricter { |i| Integer(i, 10) }. + ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Replace unsafe number conversion with number class parsing, instead of using `&:to_i`, use stricter `{ |i| Integer(i, 10) }`. RUBY expect_correction(<<~RUBY) @@ -138,7 +138,7 @@ it 'registers offense and autocorrects without parentheses' do expect_offense(<<~RUBY) "1,2,3,foo,5,6,7,8".split(',').map &:to_i - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Replace unsafe number conversion with number class parsing, instead of using &:to_i, use stricter { |i| Integer(i, 10) }. + ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Replace unsafe number conversion with number class parsing, instead of using `&:to_i`, use stricter `{ |i| Integer(i, 10) }`. RUBY expect_correction(<<~RUBY) @@ -149,7 +149,7 @@ it 'registers offense with try' do expect_offense(<<~RUBY) "foo".try(:to_f) - ^^^^^^^^^^^^^^^^ Replace unsafe number conversion with number class parsing, instead of using :to_f, use stricter { |i| Float(i) }. + ^^^^^^^^^^^^^^^^ Replace unsafe number conversion with number class parsing, instead of using `:to_f`, use stricter `{ |i| Float(i) }`. RUBY expect_correction(<<~RUBY) @@ -160,7 +160,7 @@ it 'registers offense with send' do expect_offense(<<~RUBY) "foo".send(:to_c) - ^^^^^^^^^^^^^^^^^ Replace unsafe number conversion with number class parsing, instead of using :to_c, use stricter { |i| Complex(i) }. + ^^^^^^^^^^^^^^^^^ Replace unsafe number conversion with number class parsing, instead of using `:to_c`, use stricter `{ |i| Complex(i) }`. RUBY expect_correction(<<~RUBY) @@ -216,7 +216,7 @@ it 'registers an offense for other methods' do expect_offense(<<~RUBY) 10.hours.to_i - ^^^^^^^^^^^^^ Replace unsafe number conversion with number class parsing, instead of using 10.hours.to_i, use stricter Integer(10.hours, 10). + ^^^^^^^^^^^^^ Replace unsafe number conversion with number class parsing, instead of using `10.hours.to_i`, use stricter `Integer(10.hours, 10)`. RUBY end end @@ -233,7 +233,7 @@ it 'registers an offense for other methods' do expect_offense(<<~RUBY) 10.hours.to_i - ^^^^^^^^^^^^^ Replace unsafe number conversion with number class parsing, instead of using 10.hours.to_i, use stricter Integer(10.hours, 10). + ^^^^^^^^^^^^^ Replace unsafe number conversion with number class parsing, instead of using `10.hours.to_i`, use stricter `Integer(10.hours, 10)`. RUBY end end