From b05e98fdb4d4a76244ce9160a086df6016cc47d8 Mon Sep 17 00:00:00 2001 From: Ryo Nakamura Date: Thu, 14 Jul 2022 08:35:45 +0900 Subject: [PATCH] Improve `Style/SymbolProc` about #10810 changes --- changelog/change_support_csend_on_stylesymbolproc.md | 2 +- lib/rubocop/cop/style/symbol_proc.rb | 2 +- spec/rubocop/cop/style/symbol_proc_spec.rb | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/changelog/change_support_csend_on_stylesymbolproc.md b/changelog/change_support_csend_on_stylesymbolproc.md index 8e44d84b294..74a88ea33fd 100644 --- a/changelog/change_support_csend_on_stylesymbolproc.md +++ b/changelog/change_support_csend_on_stylesymbolproc.md @@ -1 +1 @@ -* [#10810](https://github.com/rubocop/rubocop/pull/10810): Support `csend` on `Style/SymbolProc`. ([@r7kamura][]) +* [#10810](https://github.com/rubocop/rubocop/pull/10810): Support safe navigation operator on `Style/SymbolProc`. ([@r7kamura][]) diff --git a/lib/rubocop/cop/style/symbol_proc.rb b/lib/rubocop/cop/style/symbol_proc.rb index 120d9e05fef..099cb480893 100644 --- a/lib/rubocop/cop/style/symbol_proc.rb +++ b/lib/rubocop/cop/style/symbol_proc.rb @@ -89,7 +89,7 @@ class SymbolProc < Base def_node_matcher :proc_node?, '(send (const {nil? cbase} :Proc) :new)' # @!method symbol_proc_receiver?(node) - def_node_matcher :symbol_proc_receiver?, '{({csend | send} ...) (super ...) zsuper}' + def_node_matcher :symbol_proc_receiver?, '{(call ...) (super ...) zsuper}' # @!method symbol_proc?(node) def_node_matcher :symbol_proc?, <<~PATTERN diff --git a/spec/rubocop/cop/style/symbol_proc_spec.rb b/spec/rubocop/cop/style/symbol_proc_spec.rb index 1beefc91aa4..9ce4bcf8bd8 100644 --- a/spec/rubocop/cop/style/symbol_proc_spec.rb +++ b/spec/rubocop/cop/style/symbol_proc_spec.rb @@ -12,7 +12,7 @@ RUBY end - it 'registers an offense for csend' do + it 'registers an offense for safe navigation operator' do expect_offense(<<~RUBY) coll&.map { |e| e.upcase } ^^^^^^^^^^^^^^^^ Pass `&:upcase` as an argument to `map` instead of a block.