/
case_like_if_spec.rb
347 lines (307 loc) · 7.34 KB
/
case_like_if_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Style::CaseLikeIf do
subject(:cop) { described_class.new }
it 'registers an offense and corrects when using `===`' do
expect_offense(<<~RUBY)
if Integer === x
^^^^^^^^^^^^^^^^ Convert `if-elsif` to `case-when`.
elsif /foo/ === x
elsif (1..10) === x
else
end
RUBY
expect_correction(<<~RUBY)
case x
when Integer
when /foo/
when (1..10)
else
end
RUBY
end
it 'registers an offense and corrects when using `==` with literal' do
expect_offense(<<~RUBY)
if x == 1
^^^^^^^^^ Convert `if-elsif` to `case-when`.
elsif 'str' == x
else
end
RUBY
expect_correction(<<~RUBY)
case x
when 1
when 'str'
else
end
RUBY
end
it 'registers an offense and corrects when using `==` with constant' do
expect_offense(<<~RUBY)
if x == CONSTANT1
^^^^^^^^^^^^^^^^^ Convert `if-elsif` to `case-when`.
elsif CONSTANT2 == x
else
end
RUBY
expect_correction(<<~RUBY)
case x
when CONSTANT1
when CONSTANT2
else
end
RUBY
end
it 'does not register an offense when using `==` with method call with arguments' do
expect_no_offenses(<<~RUBY)
if x == foo(1)
elsif bar(1) == x
else
end
RUBY
end
it 'does not register an offense when using `==` with class reference' do
expect_no_offenses(<<~RUBY)
if x == Foo
elsif Bar == x
else
end
RUBY
end
it 'does not register an offense when one of the branches contains `==` with class reference' do
expect_no_offenses(<<~RUBY)
if x == 1
elsif x == Foo
else
end
RUBY
end
it 'does not register an offense when using `==` with constant containing 1 letter in name' do
expect_no_offenses(<<~RUBY)
if x == F
elsif B == x
else
end
RUBY
end
it 'does not register an offense when using `equal?` without a receiver' do
expect_no_offenses(<<~RUBY)
if equal?(Foo)
elsif Bar == x
else
end
RUBY
end
it 'registers an offense and corrects when using `is_a?`' do
expect_offense(<<~RUBY)
if x.is_a?(Foo)
^^^^^^^^^^^^^^^ Convert `if-elsif` to `case-when`.
elsif x.is_a?(Bar)
else
end
RUBY
expect_correction(<<~RUBY)
case x
when Foo
when Bar
else
end
RUBY
end
it 'registers an offense and corrects when using `match?` with regexp' do
expect_offense(<<~RUBY)
if /foo/.match?(x)
^^^^^^^^^^^^^^^^^^ Convert `if-elsif` to `case-when`.
elsif x.match?(/bar/)
else
end
RUBY
expect_correction(<<~RUBY)
case x
when /foo/
when /bar/
else
end
RUBY
end
it 'does not register an offense when using `match?` with non regexp' do
expect_no_offenses(<<~RUBY)
if y.match?(x)
elsif x.match?('str')
else
end
RUBY
end
it 'does not register an offense when using `match?` without a receiver' do
expect_no_offenses(<<~RUBY)
if match?(/foo/)
elsif x.match?(/bar/)
else
end
RUBY
end
it 'registers an offense and corrects when using `=~`' do
expect_offense(<<~RUBY)
if /foo/ =~ x
^^^^^^^^^^^^^ Convert `if-elsif` to `case-when`.
elsif x =~ returns_regexp(arg)
else
end
RUBY
expect_correction(<<~RUBY)
case x
when /foo/
when returns_regexp(arg)
else
end
RUBY
end
it 'does not register an offense when using `=~` in first branch with non regexp' do
expect_no_offenses(<<~RUBY)
if x =~ returns_regexp(arg)
elsif x =~ /foo/
else
end
RUBY
end
it 'does not register an offense when using `match?` in first branch with non regexp' do
expect_no_offenses(<<~RUBY)
if returns_regexp(arg).match?(x)
elsif x.match?(/bar/)
else
end
RUBY
end
it 'registers an offense and corrects when using `match?` with non regexp in other branches except first' do
expect_offense(<<~RUBY)
if /foo/.match?(x)
^^^^^^^^^^^^^^^^^^ Convert `if-elsif` to `case-when`.
elsif returns_regexp(arg).match?(x)
else
end
RUBY
expect_correction(<<~RUBY)
case x
when /foo/
when returns_regexp(arg)
else
end
RUBY
end
it 'registers an offense and corrects when using `include?` with range' do
expect_offense(<<~RUBY)
if (1..10).include?(x)
^^^^^^^^^^^^^^^^^^^^^^ Convert `if-elsif` to `case-when`.
elsif (11...100).include?(x)
else
end
RUBY
expect_correction(<<~RUBY)
case x
when 1..10
when 11...100
else
end
RUBY
end
it 'registers an offense and corrects when using `||` within conditions' do
expect_offense(<<~RUBY)
if Integer === x || x == 2
^^^^^^^^^^^^^^^^^^^^^^^^^^ Convert `if-elsif` to `case-when`.
elsif 1 == x || (1..10) === x || x.match?(/foo/)
else
end
RUBY
expect_correction(<<~RUBY)
case x
when Integer, 2
when 1, (1..10), /foo/
else
end
RUBY
end
it 'does not register an offense when one of `||` subconditions is not convertible' do
expect_no_offenses(<<~RUBY)
if Integer === x || (x == 2 && x == 3)
elsif 1 == x || (1..10) === x || x.match?(/foo/)
else
end
RUBY
end
it 'registers an offense and corrects when using nested conditions with `||`' do
expect_offense(<<~RUBY)
if Integer === x || ((x == 2) || (3 == x)) || x =~ /foo/
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Convert `if-elsif` to `case-when`.
elsif 1 == x || (1..10) === x || x.match?(/bar/)
else
end
RUBY
expect_correction(<<~RUBY)
case x
when Integer, 2, 3, /foo/
when 1, (1..10), /bar/
else
end
RUBY
end
it 'registers an offense and corrects when target is a method call' do
expect_offense(<<~RUBY)
if x.type == 1 || x.type == 2
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Convert `if-elsif` to `case-when`.
elsif /foo/ === x.type
else
end
RUBY
expect_correction(<<~RUBY)
case x.type
when 1, 2
when /foo/
else
end
RUBY
end
it 'does not register an offense when not all conditions contain target' do
expect_no_offenses(<<~RUBY)
if x == 2
elsif 3 == y
else
end
RUBY
end
it 'does not register an offense when only single `if`' do
expect_no_offenses(<<~RUBY)
if x == 1
end
RUBY
end
it 'does not register an offense when only `if-else`' do
expect_no_offenses(<<~RUBY)
if x == 1
else
end
RUBY
end
it 'does not register an offense when using `unless`' do
expect_no_offenses(<<~RUBY)
unless x == 1
else
end
RUBY
end
it 'does not register an offense when using ternary operator' do
expect_no_offenses(<<~RUBY)
x == 1 ? y : z
RUBY
end
it 'does not register an offense when using modifier `if`' do
expect_no_offenses(<<~RUBY)
foo if x == 1
RUBY
end
it 'does not register an offense when an object overrides `equal?` with no arity' do
expect_no_offenses(<<~RUBY)
if x.equal?
elsif y
end
RUBY
end
end