/
require_mfa_spec.rb
171 lines (155 loc) · 4.96 KB
/
require_mfa_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Gemspec::RequireMFA, :config do
context 'when the gemspec is blank' do
it 'does not register an offense' do
expect_no_offenses('', 'my.gemspec')
end
end
context 'when the specification is blank' do
it 'registers an offense and corrects' do
expect_offense(<<~RUBY, 'my.gemspec')
Gem::Specification.new do |spec|
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ `metadata['rubygems_mfa_required']` must be set to `'true'`.
end
RUBY
expect_correction(<<~RUBY)
Gem::Specification.new do |spec|
spec.metadata = {
'rubygems_mfa_required' => 'true'
}
end
RUBY
end
end
context 'when the specification has a metadata hash but no rubygems_mfa_required key' do
it 'registers an offense and corrects' do
expect_offense(<<~RUBY, 'my.gemspec')
Gem::Specification.new do |spec|
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ `metadata['rubygems_mfa_required']` must be set to `'true'`.
spec.metadata = {
}
end
RUBY
expect_correction(<<~RUBY)
Gem::Specification.new do |spec|
spec.metadata = {
'rubygems_mfa_required' => 'true'}
end
RUBY
end
end
context 'when the specification has an non-hash metadata' do
it 'registers an offense but does not correct' do
expect_offense(<<~RUBY, 'my.gemspec')
Gem::Specification.new do |spec|
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ `metadata['rubygems_mfa_required']` must be set to `'true'`.
spec.metadata = Metadata.new
end
RUBY
end
end
context 'when there are other metadata keys' do
context 'and `rubygems_mfa_required` is included' do
it 'does not register an offense' do
expect_no_offenses(<<~RUBY, 'my.gemspec')
Gem::Specification.new do |spec|
spec.metadata = {
'foo' => 'bar',
'rubygems_mfa_required' => 'true',
'baz' => 'quux'
}
end
RUBY
end
end
context 'and `rubygems_mfa_required` is not included' do
it 'registers an offense and corrects' do
expect_offense(<<~RUBY, 'my.gemspec')
Gem::Specification.new do |spec|
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ `metadata['rubygems_mfa_required']` must be set to `'true'`.
spec.metadata = {
'foo' => 'bar',
'baz' => 'quux'
}
end
RUBY
expect_correction(<<~RUBY)
Gem::Specification.new do |spec|
spec.metadata = {
'foo' => 'bar',
'baz' => 'quux',
'rubygems_mfa_required' => 'true'
}
end
RUBY
end
end
end
context 'when metadata is set by key assignment' do
context 'and `rubygems_mfa_required` is included' do
it 'does not register an offense' do
expect_no_offenses(<<~RUBY, 'my.gemspec')
Gem::Specification.new do |spec|
spec.metadata['foo'] = 'bar'
spec.metadata['rubygems_mfa_required'] = 'true'
end
RUBY
end
end
context 'and `rubygems_mfa_required` is not included' do
it 'registers an offense' do
expect_offense(<<~RUBY, 'my.gemspec')
Gem::Specification.new do |spec|
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ `metadata['rubygems_mfa_required']` must be set to `'true'`.
spec.metadata['foo'] = 'bar'
end
RUBY
end
end
end
context 'with rubygems_mfa_required: true' do
it 'does not register an offense' do
expect_no_offenses(<<~RUBY, 'my.gemspec')
Gem::Specification.new do |spec|
spec.metadata = {
'rubygems_mfa_required' => 'true'
}
end
RUBY
end
end
context 'with rubygems_mfa_required: false' do
it 'registers an offense and corrects' do
expect_offense(<<~RUBY, 'my.gemspec')
Gem::Specification.new do |spec|
spec.metadata = {
'rubygems_mfa_required' => 'false'
^^^^^^^ `metadata['rubygems_mfa_required']` must be set to `'true'`.
}
end
RUBY
expect_correction(<<~RUBY)
Gem::Specification.new do |spec|
spec.metadata = {
'rubygems_mfa_required' => 'true'
}
end
RUBY
end
end
context 'with rubygems_mfa_required: false by key access' do
it 'registers an offense and corrects' do
expect_offense(<<~RUBY, 'my.gemspec')
Gem::Specification.new do |spec|
spec.metadata['rubygems_mfa_required'] = 'false'
^^^^^^^ `metadata['rubygems_mfa_required']` must be set to `'true'`.
end
RUBY
expect_correction(<<~RUBY)
Gem::Specification.new do |spec|
spec.metadata['rubygems_mfa_required'] = 'true'
end
RUBY
end
end
end