/
ambiguous_regexp_literal.rb
72 lines (59 loc) · 2.17 KB
/
ambiguous_regexp_literal.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
# frozen_string_literal: true
module RuboCop
module Cop
module Lint
# This cop checks for ambiguous regexp literals in the first argument of
# a method invocation without parentheses.
#
# @example
#
# # bad
#
# # This is interpreted as a method invocation with a regexp literal,
# # but it could possibly be `/` method invocations.
# # (i.e. `do_something./(pattern)./(i)`)
# do_something /pattern/i
#
# @example
#
# # good
#
# # With parentheses, there's no ambiguity.
# do_something(/pattern/i)
class AmbiguousRegexpLiteral < Base
extend AutoCorrector
MSG = 'Ambiguous regexp literal. Parenthesize the method arguments ' \
"if it's surely a regexp literal, or add a whitespace to the " \
'right of the `/` if it should be a division.'
def on_new_investigation
processed_source.diagnostics.each do |diagnostic|
next unless diagnostic.reason == :ambiguous_literal
offense_node = find_offense_node_by(diagnostic)
add_offense(diagnostic.location, severity: diagnostic.level) do |corrector|
add_parentheses(offense_node, corrector)
end
end
end
private
def find_offense_node_by(diagnostic)
node = processed_source.ast.each_node(:regexp).find do |regexp_node|
regexp_node.source_range.begin_pos == diagnostic.location.begin_pos
end
find_offense_node(node.parent, node)
end
def find_offense_node(node, regexp_receiver)
return node unless node.parent
if node.parent.send_type? || method_chain_to_regexp_receiver?(node, regexp_receiver)
node = find_offense_node(node.parent, regexp_receiver)
end
node
end
def method_chain_to_regexp_receiver?(node, regexp_receiver)
return false unless (parent = node.parent)
return false unless (parent_receiver = parent.receiver)
parent.parent && parent_receiver.receiver == regexp_receiver
end
end
end
end
end