/
hash_transform_values_spec.rb
313 lines (262 loc) · 9.9 KB
/
hash_transform_values_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Style::HashTransformValues, :config do
context 'when using Ruby 2.4 or newer', :ruby24 do
context 'with inline block' do
it 'flags each_with_object when transform_values could be used' do
expect_offense(<<~RUBY)
x.each_with_object({}) {|(k, v), h| h[k] = foo(v)}
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer `transform_values` over `each_with_object`.
RUBY
expect_correction(<<~RUBY)
x.transform_values {|v| foo(v)}
RUBY
end
end
context 'with multiline block' do
it 'flags each_with_object when transform_values could be used' do
expect_offense(<<~RUBY)
some_hash.each_with_object({}) do |(key, val), memo|
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer `transform_values` over `each_with_object`.
memo[key] = val * val
end
RUBY
expect_correction(<<~RUBY)
some_hash.transform_values do |val|
val * val
end
RUBY
end
end
context 'with safe navigation operator' do
it 'flags each_with_object when transform_values could be used' do
expect_offense(<<~RUBY)
x&.each_with_object({}) {|(k, v), h| h[k] = foo(v)}
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer `transform_values` over `each_with_object`.
RUBY
expect_correction(<<~RUBY)
x&.transform_values {|v| foo(v)}
RUBY
end
end
it 'does not flag each_with_object when both key & value are transformed' do
expect_no_offenses(<<~RUBY)
x.each_with_object({}) {|(k, v), h| h[k.to_sym] = foo(v)}
RUBY
end
it 'does not flag each_with_object when value transformation uses key' do
expect_no_offenses('x.each_with_object({}) {|(k, v), h| h[k] = k.to_s}')
end
it 'does not flag each_with_object when no transformation occurs' do
expect_no_offenses('x.each_with_object({}) {|(k, v), h| h[k] = v}')
end
it 'does not flag each_with_object when its argument is not modified' do
expect_no_offenses(<<~RUBY)
x.each_with_object({}) {|(k, v), h| other_h[k] = v * v}
RUBY
end
it 'does not flag `each_with_object` when its argument is used in the value' do
expect_no_offenses(<<~RUBY)
x.each_with_object({}) { |(k, v), h| h[k] = h.count }
RUBY
end
it 'does not flag each_with_object when receiver is array literal' do
expect_no_offenses(<<~RUBY)
[1, 2, 3].each_with_object({}) {|(k, v), h| h[k] = foo(v)}
RUBY
end
it 'does not flag `each_with_object` when its receiver is `each_with_index`' do
expect_no_offenses(<<~RUBY)
[1, 2, 3].each_with_index.each_with_object({}) { |(k, v), h| h[k] = foo(v) }
RUBY
end
it 'does not flag `each_with_object` when its receiver is `with_index`' do
expect_no_offenses(<<~RUBY)
[1, 2, 3].each.with_index.each_with_object({}) { |(k, v), h| h[k] = foo(v) }
RUBY
end
it 'does not flag `each_with_object` when its receiver is `zip`' do
expect_no_offenses(<<~RUBY)
%i[a b c].zip([1, 2, 3]).each_with_object({}) { |(k, v), h| h[k] = foo(v) }
RUBY
end
it 'flags _.map {...}.to_h when transform_values could be used' do
expect_offense(<<~RUBY)
x.map {|k, v| [k, foo(v)]}.to_h
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer `transform_values` over `map {...}.to_h`.
RUBY
expect_correction(<<~RUBY)
x.transform_values {|v| foo(v)}
RUBY
end
it 'flags _.map {...}.to_h when transform_values could be used when line break before `to_h`' do
expect_offense(<<~RUBY)
x.map {|k, v| [k, foo(v)]}.
^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer `transform_values` over `map {...}.to_h`.
to_h
RUBY
expect_correction(<<~RUBY)
x.transform_values {|v| foo(v)}
RUBY
end
it 'flags _.map {...}.to_h when transform_values could be used when wrapped in another block' do
expect_offense(<<~RUBY)
wrapping do
x.map do |k, v|
^^^^^^^^^^^^^^^ Prefer `transform_values` over `map {...}.to_h`.
[k, v.to_s]
end.to_h
end
RUBY
expect_correction(<<~RUBY)
wrapping do
x.transform_values do |v|
v.to_s
end
end
RUBY
end
it 'does not flag _.map{...}.to_h when both key & value are transformed' do
expect_no_offenses('x.map {|k, v| [k.to_sym, foo(v)]}.to_h')
end
it 'flags Hash[_.map{...}] when transform_values could be used' do
expect_offense(<<~RUBY)
Hash[x.map {|k, v| [k, foo(v)]}]
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer `transform_values` over `Hash[_.map {...}]`.
RUBY
expect_correction(<<~RUBY)
x.transform_values {|v| foo(v)}
RUBY
end
it 'does not flag Hash[_.map{...}] when both key & value are transformed' do
expect_no_offenses('Hash[x.map {|k, v| [k.to_sym, foo(v)]}]')
end
it 'does not flag _.map {...}.to_h when value block argument is unused' do
expect_no_offenses(<<~RUBY)
x.map {|k, _v| [k, k]}.to_h
RUBY
end
it 'does not flag value transformation in the absence of to_h' do
expect_no_offenses('x.map {|k, v| [k, foo(v)]}')
end
it 'does not flag value transformation when receiver is array literal' do
expect_no_offenses(<<~RUBY)
[1, 2, 3].map {|k, v| [k, foo(v)]}.to_h
RUBY
end
it 'does not flag `_.map{...}.to_h` when its receiver is `each_with_index`' do
expect_no_offenses(<<~RUBY)
[1, 2, 3].each_with_index.map { |k, v| [k, foo(v)] }.to_h
RUBY
end
it 'does not flag `_.map{...}.to_h` when its receiver is `with_index`' do
expect_no_offenses(<<~RUBY)
[1, 2, 3].each.with_index.map { |k, v| [k, foo(v)] }.to_h
RUBY
end
it 'does not flag `_.map{...}.to_h` when its receiver is `zip`' do
expect_no_offenses(<<~RUBY)
%i[a b c].zip([1, 2, 3]).map { |k, v| [k, foo(v)] }.to_h
RUBY
end
it 'correctly autocorrects _.map{...}.to_h with block' do
expect_offense(<<~RUBY)
{a: 1, b: 2}.map {|k, v| [k, foo(v)]}.to_h {|k, v| [v, k]}
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer `transform_values` over `map {...}.to_h`.
RUBY
expect_correction(<<~RUBY)
{a: 1, b: 2}.transform_values {|v| foo(v)}.to_h {|k, v| [v, k]}
RUBY
end
it 'does not flag `Hash[_.map{...}]` when its receiver is an array literal' do
expect_no_offenses(<<~RUBY)
Hash[[1, 2, 3].map { |k, v| [k, foo(v)] }]
RUBY
end
it 'does not flag `Hash[_.map{...}]` when its receiver is `each_with_index`' do
expect_no_offenses(<<~RUBY)
Hash[[1, 2, 3].each_with_index.map { |k, v| [k, foo(v)] }]
RUBY
end
it 'does not flag `Hash[_.map{...}]` when its receiver is `with_index`' do
expect_no_offenses(<<~RUBY)
Hash[[1, 2, 3].each.with_index.map { |k, v| [k, foo(v)] }]
RUBY
end
it 'does not flag `Hash[_.map{...}]` when its receiver is `zip`' do
expect_no_offenses(<<~RUBY)
Hash[%i[a b c].zip([1, 2, 3]).map { |k, v| [k, foo(v)] }]
RUBY
end
end
context 'when using Ruby 2.6 or newer', :ruby26 do
it 'flags _.to_h{...} when transform_values could be used' do
expect_offense(<<~RUBY)
x.to_h {|k, v| [k, foo(v)]}
^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer `transform_values` over `to_h {...}`.
RUBY
expect_correction(<<~RUBY)
x.transform_values {|v| foo(v)}
RUBY
end
it 'register and corrects an offense _.to_h{...} when value is a hash literal and is enclosed in braces' do
expect_offense(<<~RUBY)
{a: 1, b: 2}.to_h { |key, val| [key, { value: val }] }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer `transform_values` over `to_h {...}`.
RUBY
expect_correction(<<~RUBY)
{a: 1, b: 2}.transform_values { |val| { value: val } }
RUBY
end
it 'register and corrects an offense _.to_h{...} when value is a hash literal and is not enclosed in braces' do
expect_offense(<<~RUBY)
{a: 1, b: 2}.to_h { |key, val| [key, value: val] }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Prefer `transform_values` over `to_h {...}`.
RUBY
expect_correction(<<~RUBY)
{a: 1, b: 2}.transform_values { |val| { value: val } }
RUBY
end
it 'does not flag `_.to_h{...}` when both key & value are transformed' do
expect_no_offenses(<<~RUBY)
x.to_h { |k, v| [k.to_sym, foo(v)] }
RUBY
end
it 'does not flag _.to_h {...} when value block argument is unused' do
expect_no_offenses(<<~RUBY)
x.to_h {|k, _v| [k, k]}
RUBY
end
it 'does not flag `_.to_h{...}` when its receiver is an array literal' do
expect_no_offenses(<<~RUBY)
[1, 2, 3].to_h { |k, v| [k, foo(v)] }
RUBY
end
it 'does not flag `_.to_h{...}` when its receiver is `each_with_index`' do
expect_no_offenses(<<~RUBY)
[1, 2, 3].each_with_index.to_h { |k, v| [k, foo(v)] }
RUBY
end
it 'does not flag `_.to_h{...}` when its receiver is `with_index`' do
expect_no_offenses(<<~RUBY)
[1, 2, 3].each.with_index.to_h { |k, v| [k, foo(v)] }
RUBY
end
it 'does not flag `_.to_h{...}` when its receiver is `zip`' do
expect_no_offenses(<<~RUBY)
%i[a b c].zip([1, 2, 3]).to_h { |k, v| [k, foo(v)] }
RUBY
end
end
context 'below Ruby 2.4', :ruby23 do
it 'does not flag even if transform_values could be used' do
expect_no_offenses('x.each_with_object({}) {|(k, v), h| h[k] = foo(v)}')
end
end
context 'below Ruby 2.6', :ruby25 do
it 'does not flag _.to_h{...}' do
expect_no_offenses(<<~RUBY)
x.to_h {|k, v| [k, foo(v)]}
RUBY
end
end
end