/
cyclomatic_complexity_spec.rb
330 lines (295 loc) · 8.51 KB
/
cyclomatic_complexity_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Metrics::CyclomaticComplexity, :config do
context 'when Max is 1' do
let(:cop_config) { { 'Max' => 1 } }
it 'accepts a method with no decision points' do
expect_no_offenses(<<~RUBY)
def method_name
call_foo
end
RUBY
end
it 'accepts an empty method' do
expect_no_offenses(<<~RUBY)
def method_name
end
RUBY
end
it 'accepts an empty `define_method`' do
expect_no_offenses(<<~RUBY)
define_method :method_name do
end
RUBY
end
it 'accepts complex code outside of methods' do
expect_no_offenses(<<~RUBY)
def method_name
call_foo
end
if first_condition then
call_foo if second_condition && third_condition
call_bar if fourth_condition || fifth_condition
end
RUBY
end
it 'registers an offense for an if modifier' do
expect_offense(<<~RUBY)
def self.method_name
^^^^^^^^^^^^^^^^^^^^ Cyclomatic complexity for method_name is too high. [2/1]
call_foo if some_condition
end
RUBY
end
it 'registers an offense for an unless modifier' do
expect_offense(<<~RUBY)
def method_name
^^^^^^^^^^^^^^^ Cyclomatic complexity for method_name is too high. [2/1]
call_foo unless some_condition
end
RUBY
end
it 'registers an offense for an elsif block' do
expect_offense(<<~RUBY)
def method_name
^^^^^^^^^^^^^^^ Cyclomatic complexity for method_name is too high. [3/1]
if first_condition then
call_foo
elsif second_condition then
call_bar
else
call_bam
end
end
RUBY
end
it 'registers an offense for a ternary operator' do
expect_offense(<<~RUBY)
def method_name
^^^^^^^^^^^^^^^ Cyclomatic complexity for method_name is too high. [2/1]
value = some_condition ? 1 : 2
end
RUBY
end
it 'registers an offense for a while block' do
expect_offense(<<~RUBY)
def method_name
^^^^^^^^^^^^^^^ Cyclomatic complexity for method_name is too high. [2/1]
while some_condition do
call_foo
end
end
RUBY
end
it 'registers an offense for an until block' do
expect_offense(<<~RUBY)
def method_name
^^^^^^^^^^^^^^^ Cyclomatic complexity for method_name is too high. [2/1]
until some_condition do
call_foo
end
end
RUBY
end
it 'registers an offense for a for block' do
expect_offense(<<~RUBY)
def method_name
^^^^^^^^^^^^^^^ Cyclomatic complexity for method_name is too high. [2/1]
for i in 1..2 do
call_method
end
end
RUBY
end
it 'registers an offense for a rescue block' do
expect_offense(<<~RUBY)
def method_name
^^^^^^^^^^^^^^^ Cyclomatic complexity for method_name is too high. [2/1]
begin
call_foo
rescue Exception
call_bar
end
end
RUBY
end
it 'registers an offense for a case/when block' do
expect_offense(<<~RUBY)
def method_name
^^^^^^^^^^^^^^^ Cyclomatic complexity for method_name is too high. [3/1]
case value
when 1
call_foo
when 2
call_bar
end
end
RUBY
end
it 'registers an offense for &&' do
expect_offense(<<~RUBY)
def method_name
^^^^^^^^^^^^^^^ Cyclomatic complexity for method_name is too high. [2/1]
call_foo && call_bar
end
RUBY
end
it 'registers an offense for &&=' do
expect_offense(<<~RUBY)
def method_name
^^^^^^^^^^^^^^^ Cyclomatic complexity for method_name is too high. [2/1]
foo = nil
foo &&= 42
end
RUBY
end
it 'registers an offense for and' do
expect_offense(<<~RUBY)
def method_name
^^^^^^^^^^^^^^^ Cyclomatic complexity for method_name is too high. [2/1]
call_foo and call_bar
end
RUBY
end
it 'registers an offense for ||' do
expect_offense(<<~RUBY)
def method_name
^^^^^^^^^^^^^^^ Cyclomatic complexity for method_name is too high. [2/1]
call_foo || call_bar
end
RUBY
end
it 'registers an offense for ||=' do
expect_offense(<<~RUBY)
def method_name
^^^^^^^^^^^^^^^ Cyclomatic complexity for method_name is too high. [2/1]
foo = nil
foo ||= 42
end
RUBY
end
it 'registers an offense for or' do
expect_offense(<<~RUBY)
def method_name
^^^^^^^^^^^^^^^ Cyclomatic complexity for method_name is too high. [2/1]
call_foo or call_bar
end
RUBY
end
it 'deals with nested if blocks containing && and ||' do
expect_offense(<<~RUBY)
def method_name
^^^^^^^^^^^^^^^ Cyclomatic complexity for method_name is too high. [6/1]
if first_condition then
call_foo if second_condition && third_condition
call_bar if fourth_condition || fifth_condition
end
end
RUBY
end
it 'registers an offense for &.' do
expect_offense(<<~RUBY)
def method_name
^^^^^^^^^^^^^^^ Cyclomatic complexity for method_name is too high. [2/1]
foo = nil
foo&.bar
end
RUBY
end
it 'counts only a single method' do
expect_offense(<<~RUBY)
def method_name_1
^^^^^^^^^^^^^^^^^ Cyclomatic complexity for method_name_1 is too high. [2/1]
call_foo if some_condition
end
def method_name_2
^^^^^^^^^^^^^^^^^ Cyclomatic complexity for method_name_2 is too high. [2/1]
call_foo if some_condition
end
RUBY
end
it 'registers an offense for a `define_method`' do
expect_offense(<<~RUBY)
define_method :method_name do
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Cyclomatic complexity for method_name is too high. [2/1]
call_foo if some_condition
end
RUBY
end
it 'counts enumerating methods with blocks as +1' do
expect_offense(<<~RUBY)
define_method :method_name do
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Cyclomatic complexity for method_name is too high. [3/1]
(1..4).map do |i| # map: +1
i * 2
end.each.with_index { |val, i| puts val, i } # each: +0, with_index: +1
return treasure.map
end
RUBY
end
it 'counts enumerating methods with block-pass as +1' do
expect_offense(<<~RUBY)
define_method :method_name do
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Cyclomatic complexity for method_name is too high. [2/1]
[].map(&:to_s)
end
RUBY
end
it 'does not count blocks in general' do
expect_no_offenses(<<~RUBY)
define_method :method_name do
Struct.new(:foo, :bar) do
String.class_eval do
[42].tap do |answer|
foo { bar }
end
end
end
end
RUBY
end
end
context 'when method is in list of ignored methods' do
let(:cop_config) { { 'Max' => 0, 'IgnoredMethods' => ['foo'] } }
it 'does not register an offense when defining an instance method' do
expect_no_offenses(<<~RUBY)
def foo
bar.baz(:qux)
end
RUBY
end
it 'does not register an offense when defining a class method' do
expect_no_offenses(<<~RUBY)
def self.foo
bar.baz(:qux)
end
RUBY
end
it 'does not register an offense when using `define_method`' do
expect_no_offenses(<<~RUBY)
define_method :foo do
bar.baz(:qux)
end
RUBY
end
end
context 'when Max is 2' do
let(:cop_config) { { 'Max' => 2 } }
it 'counts stupid nested if and else blocks' do
expect_offense(<<~RUBY)
def method_name
^^^^^^^^^^^^^^^ Cyclomatic complexity for method_name is too high. [5/2]
if first_condition then
call_foo
else
if second_condition then
call_bar
else
call_bam if third_condition
end
call_baz if fourth_condition
end
end
RUBY
end
end
end