/
raise_exception_spec.rb
161 lines (134 loc) · 4.26 KB
/
raise_exception_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Lint::RaiseException, :config do
let(:cop_config) { { 'AllowedImplicitNamespaces' => ['Gem'] } }
it 'registers an offense and corrects for `raise` with `::Exception`' do
expect_offense(<<~RUBY)
raise ::Exception
^^^^^^^^^^^ Use `StandardError` over `Exception`.
RUBY
expect_correction(<<~RUBY)
raise ::StandardError
RUBY
end
it 'registers an offense and corrects for `raise` with `::Exception.new`' do
expect_offense(<<~RUBY)
raise ::Exception.new 'Error with exception'
^^^^^^^^^^^ Use `StandardError` over `Exception`.
RUBY
expect_correction(<<~RUBY)
raise ::StandardError.new 'Error with exception'
RUBY
end
it 'registers an offense and corrects for `raise` with `::Exception` and message' do
expect_offense(<<~RUBY)
raise ::Exception, 'Error with exception'
^^^^^^^^^^^ Use `StandardError` over `Exception`.
RUBY
expect_correction(<<~RUBY)
raise ::StandardError, 'Error with exception'
RUBY
end
it 'registers an offense and corrects for `raise` with `Exception`' do
expect_offense(<<~RUBY)
raise Exception
^^^^^^^^^ Use `StandardError` over `Exception`.
RUBY
expect_correction(<<~RUBY)
raise StandardError
RUBY
end
it 'registers an offense and corrects for `raise` with `Exception` and message' do
expect_offense(<<~RUBY)
raise Exception, 'Error with exception'
^^^^^^^^^ Use `StandardError` over `Exception`.
RUBY
expect_correction(<<~RUBY)
raise StandardError, 'Error with exception'
RUBY
end
it 'registers an offense and corrects for `raise` with `Exception.new` and message' do
expect_offense(<<~RUBY)
raise Exception.new 'Error with exception'
^^^^^^^^^ Use `StandardError` over `Exception`.
RUBY
expect_correction(<<~RUBY)
raise StandardError.new 'Error with exception'
RUBY
end
it 'registers an offense and corrects for `raise` with `Exception.new(args*)` ' do
expect_offense(<<~RUBY)
raise Exception.new('arg1', 'arg2')
^^^^^^^^^ Use `StandardError` over `Exception`.
RUBY
expect_correction(<<~RUBY)
raise StandardError.new('arg1', 'arg2')
RUBY
end
it 'registers an offense and corrects for `fail` with `Exception`' do
expect_offense(<<~RUBY)
fail Exception
^^^^^^^^^ Use `StandardError` over `Exception`.
RUBY
expect_correction(<<~RUBY)
fail StandardError
RUBY
end
it 'registers an offense and corrects for `fail` with `Exception` and message' do
expect_offense(<<~RUBY)
fail Exception, 'Error with exception'
^^^^^^^^^ Use `StandardError` over `Exception`.
RUBY
expect_correction(<<~RUBY)
fail StandardError, 'Error with exception'
RUBY
end
it 'registers an offense and corrects for `fail` with `Exception.new` and message' do
expect_offense(<<~RUBY)
fail Exception.new 'Error with exception'
^^^^^^^^^ Use `StandardError` over `Exception`.
RUBY
expect_correction(<<~RUBY)
fail StandardError.new 'Error with exception'
RUBY
end
it 'does not register an offense for `raise` without arguments' do
expect_no_offenses('raise')
end
it 'does not register an offense for `fail` without arguments' do
expect_no_offenses('fail')
end
it 'does not register an offense when raising Exception with explicit ' \
'namespace' do
expect_no_offenses(<<~RUBY)
raise Foo::Exception
RUBY
end
context 'when under namespace' do
it 'does not register an offense when Exception without cbase specified' do
expect_no_offenses(<<~RUBY)
module Gem
def self.foo
raise Exception
end
end
RUBY
end
it 'registers an offense and corrects when Exception with cbase specified' do
expect_offense(<<~RUBY)
module Gem
def self.foo
raise ::Exception
^^^^^^^^^^^ Use `StandardError` over `Exception`.
end
end
RUBY
expect_correction(<<~RUBY)
module Gem
def self.foo
raise ::StandardError
end
end
RUBY
end
end
end