-
-
Notifications
You must be signed in to change notification settings - Fork 3k
/
config_obsoletion_spec.rb
298 lines (288 loc) · 19.7 KB
/
config_obsoletion_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
# frozen_string_literal: true
RSpec.describe RuboCop::ConfigObsoletion do
include FileHelper
subject(:config_obsoletion) { described_class.new(configuration) }
let(:configuration) { RuboCop::Config.new(hash, loaded_path) }
let(:loaded_path) { 'example/.rubocop.yml' }
describe '#validate', :isolated_environment do
let(:configuration_path) { '.rubocop.yml' }
context 'when the configuration includes any obsolete cop name' do
let(:hash) do
{
# Renamed cops
'Layout/AlignArguments' => { 'Enabled': true },
'Layout/AlignArray' => { 'Enabled': true },
'Layout/AlignHash' => { 'Enabled': true },
'Layout/AlignParameters' => { 'Enabled': true },
'Layout/FirstParameterIndentation' => { 'Enabled': true },
'Layout/IndentArray' => { 'Enabled': true },
'Layout/IndentAssignment' => { 'Enabled': true },
'Layout/IndentFirstArgument' => { 'Enabled': true },
'Layout/IndentFirstArrayElement' => { 'Enabled': true },
'Layout/IndentFirstHashElement' => { 'Enabled': true },
'Layout/IndentFirstParameter' => { 'Enabled': true },
'Layout/IndentHash' => { 'Enabled': true },
'Layout/IndentHeredoc' => { 'Enabled': true },
'Layout/LeadingBlankLines' => { 'Enabled': true },
'Layout/TrailingBlankLines' => { 'Enabled': true },
'Lint/DuplicatedKey' => { 'Enabled': true },
'Lint/HandleExceptions' => { 'Enabled': true },
'Lint/MultipleCompare' => { 'Enabled': true },
'Lint/StringConversionInInterpolation' => { 'Enabled': true },
'Lint/UnneededCopDisableDirective' => { 'Enabled': true },
'Lint/UnneededCopEnableDirective' => { 'Enabled': true },
'Lint/UnneededRequireStatement' => { 'Enabled': true },
'Lint/UnneededSplatExpansion' => { 'Enabled': true },
'Naming/UncommunicativeBlockParamName' => { 'Enabled': true },
'Naming/UncommunicativeMethodParamName' => { 'Enabled': true },
'Style/DeprecatedHashMethods' => { 'Enabled': true },
'Style/MethodCallParentheses' => { 'Enabled': true },
'Style/OpMethod' => { 'Enabled': true },
'Style/SingleSpaceBeforeFirstArg' => { 'Enabled': true },
'Style/UnneededCapitalW' => { 'Enabled': true },
'Style/UnneededCondition' => { 'Enabled': true },
'Style/UnneededInterpolation' => { 'Enabled': true },
'Style/UnneededPercentQ' => { 'Enabled': true },
'Style/UnneededSort' => { 'Enabled': true },
# Moved cops
'Lint/BlockAlignment' => { 'Enabled': true },
'Lint/DefEndAlignment' => { 'Enabled': true },
'Lint/EndAlignment' => { 'Enabled': true },
'Lint/Eval' => { 'Enabled': true },
'Style/AccessorMethodName' => { 'Enabled': true },
'Style/AsciiIdentifiers' => { 'Enabled': true },
'Style/ClassAndModuleCamelCase' => { 'Enabled': true },
'Style/ConstantName' => { 'Enabled': true },
'Style/FileName' => { 'Enabled': true },
'Style/FlipFlop' => { 'Enabled': true },
'Style/MethodName' => { 'Enabled': true },
'Style/PredicateName' => { 'Enabled': true },
'Style/VariableName' => { 'Enabled': true },
'Style/VariableNumber' => { 'Enabled': true },
# Removed cops
'Layout/SpaceAfterControlKeyword' => { 'Enabled': true },
'Layout/SpaceBeforeModifierKeyword' => { 'Enabled': true },
'Lint/InvalidCharacterLiteral' => { 'Enabled': true },
'Lint/RescueWithoutErrorClass' => { 'Enabled': true },
'Lint/SpaceBeforeFirstArg' => { 'Enabled': true },
'Rails/DefaultScope' => { 'Enabled': true },
'Style/SpaceAfterControlKeyword' => { 'Enabled': true },
'Style/SpaceBeforeModifierKeyword' => { 'Enabled': true },
'Style/TrailingComma' => { 'Enabled': true },
'Style/TrailingCommaInLiteral' => { 'Enabled': true },
# Split cops
'Style/MethodMissing' => { 'Enabled': true }
}
end
let(:expected_message) do
<<~OUTPUT.chomp
The `Layout/AlignArguments` cop has been renamed to `Layout/ArgumentAlignment`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Layout/AlignArray` cop has been renamed to `Layout/ArrayAlignment`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Layout/AlignHash` cop has been renamed to `Layout/HashAlignment`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Layout/AlignParameters` cop has been renamed to `Layout/ParameterAlignment`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Layout/IndentArray` cop has been renamed to `Layout/FirstArrayElementIndentation`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Layout/IndentAssignment` cop has been renamed to `Layout/AssignmentIndentation`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Layout/IndentFirstArgument` cop has been renamed to `Layout/FirstArgumentIndentation`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Layout/IndentFirstArrayElement` cop has been renamed to `Layout/FirstArrayElementIndentation`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Layout/IndentFirstHashElement` cop has been renamed to `Layout/FirstHashElementIndentation`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Layout/IndentFirstParameter` cop has been renamed to `Layout/FirstParameterIndentation`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Layout/IndentHash` cop has been renamed to `Layout/FirstHashElementIndentation`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Layout/IndentHeredoc` cop has been renamed to `Layout/HeredocIndentation`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Layout/LeadingBlankLines` cop has been renamed to `Layout/LeadingEmptyLines`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Layout/TrailingBlankLines` cop has been renamed to `Layout/TrailingEmptyLines`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Lint/DuplicatedKey` cop has been renamed to `Lint/DuplicateHashKey`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Lint/HandleExceptions` cop has been renamed to `Lint/SuppressedException`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Lint/MultipleCompare` cop has been renamed to `Lint/MultipleComparison`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Lint/StringConversionInInterpolation` cop has been renamed to `Lint/RedundantStringCoercion`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Lint/UnneededCopDisableDirective` cop has been renamed to `Lint/RedundantCopDisableDirective`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Lint/UnneededCopEnableDirective` cop has been renamed to `Lint/RedundantCopEnableDirective`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Lint/UnneededRequireStatement` cop has been renamed to `Lint/RedundantRequireStatement`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Lint/UnneededSplatExpansion` cop has been renamed to `Lint/RedundantSplatExpansion`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Naming/UncommunicativeBlockParamName` cop has been renamed to `Naming/BlockParameterName`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Naming/UncommunicativeMethodParamName` cop has been renamed to `Naming/MethodParameterName`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Style/DeprecatedHashMethods` cop has been renamed to `Style/PreferredHashMethods`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Style/MethodCallParentheses` cop has been renamed to `Style/MethodCallWithoutArgsParentheses`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Style/OpMethod` cop has been renamed to `Naming/BinaryOperatorParameterName`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Style/SingleSpaceBeforeFirstArg` cop has been renamed to `Layout/SpaceBeforeFirstArg`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Style/UnneededCapitalW` cop has been renamed to `Style/RedundantCapitalW`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Style/UnneededCondition` cop has been renamed to `Style/RedundantCondition`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Style/UnneededInterpolation` cop has been renamed to `Style/RedundantInterpolation`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Style/UnneededPercentQ` cop has been renamed to `Style/RedundantPercentQ`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Style/UnneededSort` cop has been renamed to `Style/RedundantSort`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Lint/Eval` cop has been moved to `Security/Eval`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Style/ClassAndModuleCamelCase` cop has been moved to `Naming/ClassAndModuleCamelCase`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Style/ConstantName` cop has been moved to `Naming/ConstantName`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Style/FileName` cop has been moved to `Naming/FileName`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Style/MethodName` cop has been moved to `Naming/MethodName`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Style/PredicateName` cop has been moved to `Naming/PredicateName`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Style/VariableName` cop has been moved to `Naming/VariableName`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Style/VariableNumber` cop has been moved to `Naming/VariableNumber`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Style/AccessorMethodName` cop has been moved to `Naming/AccessorMethodName`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Style/AsciiIdentifiers` cop has been moved to `Naming/AsciiIdentifiers`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Lint/BlockAlignment` cop has been moved to `Layout/BlockAlignment`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Lint/EndAlignment` cop has been moved to `Layout/EndAlignment`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Lint/DefEndAlignment` cop has been moved to `Layout/DefEndAlignment`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Style/FlipFlop` cop has been moved to `Lint/FlipFlop`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Layout/SpaceAfterControlKeyword` cop has been removed. Please use `Layout/SpaceAroundKeyword` instead.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Layout/SpaceBeforeModifierKeyword` cop has been removed. Please use `Layout/SpaceAroundKeyword` instead.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Lint/RescueWithoutErrorClass` cop has been removed. Please use `Style/RescueStandardError` instead.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Rails/DefaultScope` cop has been removed.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Style/SpaceAfterControlKeyword` cop has been removed. Please use `Layout/SpaceAroundKeyword` instead.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Style/SpaceBeforeModifierKeyword` cop has been removed. Please use `Layout/SpaceAroundKeyword` instead.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Style/TrailingComma` cop has been removed. Please use `Style/TrailingCommaInArguments`, `Style/TrailingCommaInArrayLiteral`, and/or `Style/TrailingCommaInHashLiteral` instead.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Style/TrailingCommaInLiteral` cop has been removed. Please use `Style/TrailingCommaInArrayLiteral` and/or `Style/TrailingCommaInHashLiteral` instead.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Lint/InvalidCharacterLiteral` cop has been removed since it was never being actually triggered.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Lint/SpaceBeforeFirstArg` cop has been removed since it was a duplicate of `Layout/SpaceBeforeFirstArg`. Please use `Layout/SpaceBeforeFirstArg` instead.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Style/MethodMissing` cop has been split into `Style/MethodMissingSuper` and `Style/MissingRespondToMissing`.
(obsolete configuration found in example/.rubocop.yml, please update it)
OUTPUT
end
it 'prints a warning message' do
begin
config_obsoletion.reject_obsolete_cops_and_parameters
raise 'Expected a RuboCop::ValidationError'
rescue RuboCop::ValidationError => e
expect(expected_message).to eq(e.message)
end
end
end
context 'when the configuration includes any obsolete parameters' do
let(:hash) do
{
'Layout/SpaceAroundOperators' => {
'MultiSpaceAllowedForOperators' => true
},
'Style/SpaceAroundOperators' => {
'MultiSpaceAllowedForOperators' => true
},
'Style/Encoding' => {
'EnforcedStyle' => 'a',
'SupportedStyles' => %w[a b c],
'AutoCorrectEncodingComment' => true
},
'Style/IfUnlessModifier' => { 'MaxLineLength' => 100 },
'Style/WhileUntilModifier' => { 'MaxLineLength' => 100 },
'AllCops' => { 'RunRailsCops' => true },
'Layout/CaseIndentation' => { 'IndentWhenRelativeTo' => 'end' },
'Layout/BlockAlignment' => { 'AlignWith' => 'end' },
'Layout/EndAlignment' => { 'AlignWith' => 'end' },
'Layout/DefEndAlignment' => { 'AlignWith' => 'end' },
'Rails/UniqBeforePluck' => { 'EnforcedMode' => 'x' },
# Moved cops with obsolete parameters
'Lint/BlockAlignment' => { 'AlignWith' => 'end' },
'Lint/EndAlignment' => { 'AlignWith' => 'end' },
'Lint/DefEndAlignment' => { 'AlignWith' => 'end' }
}
end
let(:expected_message) do
<<~OUTPUT.chomp
The `Lint/BlockAlignment` cop has been moved to `Layout/BlockAlignment`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Lint/EndAlignment` cop has been moved to `Layout/EndAlignment`.
(obsolete configuration found in example/.rubocop.yml, please update it)
The `Lint/DefEndAlignment` cop has been moved to `Layout/DefEndAlignment`.
(obsolete configuration found in example/.rubocop.yml, please update it)
obsolete parameter MultiSpaceAllowedForOperators (for Layout/SpaceAroundOperators) found in example/.rubocop.yml
If your intention was to allow extra spaces for alignment, please use AllowForAlignment: true instead.
obsolete parameter MultiSpaceAllowedForOperators (for Style/SpaceAroundOperators) found in example/.rubocop.yml
If your intention was to allow extra spaces for alignment, please use AllowForAlignment: true instead.
obsolete parameter EnforcedStyle (for Style/Encoding) found in example/.rubocop.yml
Style/Encoding no longer supports styles. The "never" behavior is always assumed.
obsolete parameter SupportedStyles (for Style/Encoding) found in example/.rubocop.yml
Style/Encoding no longer supports styles. The "never" behavior is always assumed.
obsolete parameter AutoCorrectEncodingComment (for Style/Encoding) found in example/.rubocop.yml
Style/Encoding no longer supports styles. The "never" behavior is always assumed.
obsolete parameter MaxLineLength (for Style/IfUnlessModifier) found in example/.rubocop.yml
`Style/IfUnlessModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead
obsolete parameter MaxLineLength (for Style/WhileUntilModifier) found in example/.rubocop.yml
`Style/WhileUntilModifier: MaxLineLength` has been removed. Use `Metrics/LineLength: Max` instead
obsolete parameter RunRailsCops (for AllCops) found in example/.rubocop.yml
Use the following configuration instead:
Rails:
Enabled: true
obsolete parameter IndentWhenRelativeTo (for Layout/CaseIndentation) found in example/.rubocop.yml
`IndentWhenRelativeTo` has been renamed to `EnforcedStyle`
obsolete parameter AlignWith (for Lint/BlockAlignment) found in example/.rubocop.yml
`AlignWith` has been renamed to `EnforcedStyleAlignWith`
obsolete parameter AlignWith (for Layout/BlockAlignment) found in example/.rubocop.yml
`AlignWith` has been renamed to `EnforcedStyleAlignWith`
obsolete parameter AlignWith (for Lint/EndAlignment) found in example/.rubocop.yml
`AlignWith` has been renamed to `EnforcedStyleAlignWith`
obsolete parameter AlignWith (for Layout/EndAlignment) found in example/.rubocop.yml
`AlignWith` has been renamed to `EnforcedStyleAlignWith`
obsolete parameter AlignWith (for Lint/DefEndAlignment) found in example/.rubocop.yml
`AlignWith` has been renamed to `EnforcedStyleAlignWith`
obsolete parameter AlignWith (for Layout/DefEndAlignment) found in example/.rubocop.yml
`AlignWith` has been renamed to `EnforcedStyleAlignWith`
obsolete parameter EnforcedMode (for Rails/UniqBeforePluck) found in example/.rubocop.yml
`EnforcedMode` has been renamed to `EnforcedStyle`
OUTPUT
end
it 'prints a warning message' do
begin
config_obsoletion.reject_obsolete_cops_and_parameters
raise 'Expected a RuboCop::ValidationError'
rescue RuboCop::ValidationError => e
expect(expected_message).to eq(e.message)
end
end
end
end
end