-
-
Notifications
You must be signed in to change notification settings - Fork 3k
/
space_around_block_parameters_spec.rb
408 lines (338 loc) · 11.6 KB
/
space_around_block_parameters_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Layout::SpaceAroundBlockParameters, :config do
shared_examples 'common behavior' do
it 'accepts an empty block' do
expect_no_offenses('{}.each {}')
end
it 'skips lambda without args' do
expect_no_offenses('->() { puts "a" }')
end
it 'skips lambda without parens' do
expect_no_offenses('->a { puts a }')
end
end
context 'when EnforcedStyleInsidePipes is no_space' do
let(:cop_config) { { 'EnforcedStyleInsidePipes' => 'no_space' } }
include_examples 'common behavior'
it 'accepts a block with spaces in the right places' do
expect_no_offenses('{}.each { |x, y| puts x }')
end
it 'accepts a block with parameters but no body' do
expect_no_offenses('{}.each { |x, y| }')
end
it 'accepts a block parameter without preceding space' do
# This is checked by Layout/SpaceAfterComma.
expect_no_offenses('{}.each { |x,y| puts x }')
end
it 'accepts block parameters with surrounding space that includes line ' \
'breaks' do
# This is checked by Layout/MultilineBlockLayout.
expect_no_offenses(<<~RUBY)
some_result = lambda do |
so_many,
parameters,
it_will,
be_too_long,
for_one_line
|
do_something
end
RUBY
end
it 'accepts a lambda with spaces in the right places' do
expect_no_offenses('->(x, y) { puts x }')
end
it 'registers an offense and corrects space before first parameter' do
expect_offense(<<~RUBY)
{}.each { | x| puts x }
^ Space before first block parameter detected.
RUBY
expect_correction(<<~RUBY)
{}.each { |x| puts x }
RUBY
end
it 'registers an offense and corrects space after last parameter' do
expect_offense(<<~RUBY)
{}.each { |x, y | puts x }
^^ Space after last block parameter detected.
RUBY
expect_correction(<<~RUBY)
{}.each { |x, y| puts x }
RUBY
end
it 'registers an offense and corrects no space after closing pipe' do
expect_offense(<<~RUBY)
{}.each { |x, y|puts x }
^ Space after closing `|` missing.
RUBY
expect_correction(<<~RUBY)
{}.each { |x, y| puts x }
RUBY
end
it 'registers an offense and corrects a lambda for space before ' \
'first parameter' do
expect_offense(<<~RUBY)
->( x, y) { puts x }
^ Space before first block parameter detected.
RUBY
expect_correction(<<~RUBY)
->(x, y) { puts x }
RUBY
end
it 'registers an offense and corrects a lambda for space after ' \
'the last parameter' do
expect_offense(<<~RUBY)
->(x, y ) { puts x }
^^ Space after last block parameter detected.
RUBY
expect_correction(<<~RUBY)
->(x, y) { puts x }
RUBY
end
it 'accepts line break after closing pipe' do
expect_no_offenses(<<~RUBY)
{}.each do |x, y|
puts x
end
RUBY
end
it 'registers an offense and corrects multiple spaces before parameter' do
expect_offense(<<~RUBY)
{}.each { |x, y| puts x }
^^ Extra space before block parameter detected.
RUBY
expect_correction(<<~RUBY)
{}.each { |x, y| puts x }
RUBY
end
it 'registers an offense and corrects for space with parens' do
expect_offense(<<~RUBY)
{}.each { |a, (x, y), z| puts x }
^ Extra space before block parameter detected.
^ Extra space before block parameter detected.
^ Extra space before block parameter detected.
RUBY
expect_correction(<<~RUBY)
{}.each { |a, (x, y), z| puts x }
RUBY
end
context 'trailing comma' do
it 'registers an offense for space after the last comma' do
expect_offense(<<~RUBY)
{}.each { |x, | puts x }
^ Space after last block parameter detected.
RUBY
expect_correction(<<~RUBY)
{}.each { |x,| puts x }
RUBY
end
it 'accepts no space after the last comma' do
expect_no_offenses('{}.each { |x,| puts x }')
end
end
it 'registers an offense and corrects all types of spacing issues' do
expect_offense(<<~RUBY)
{}.each { | x=5, (y,*z) |puts x }
^ Space after closing `|` missing.
^ Space after last block parameter detected.
^ Extra space before block parameter detected.
^ Extra space before block parameter detected.
^^ Space before first block parameter detected.
RUBY
expect_correction(<<~RUBY)
{}.each { |x=5, (y,*z)| puts x }
RUBY
end
it 'registers an offense and corrects all types of spacing issues ' \
'for a lambda' do
expect_offense(<<~RUBY)
->( a, b, c) { puts a }
^ Extra space before block parameter detected.
^ Extra space before block parameter detected.
^^ Space before first block parameter detected.
RUBY
expect_correction(<<~RUBY)
->(a, b, c) { puts a }
RUBY
end
end
context 'when EnforcedStyleInsidePipes is space' do
let(:cop_config) { { 'EnforcedStyleInsidePipes' => 'space' } }
include_examples 'common behavior'
it 'accepts a block with spaces in the right places' do
expect_no_offenses('{}.each { | x, y | puts x }')
end
it 'accepts a block with parameters but no body' do
expect_no_offenses('{}.each { | x, y | }')
end
it 'accepts a block parameter without preceding space' do
# This is checked by Layout/SpaceAfterComma.
expect_no_offenses('{}.each { | x,y | puts x }')
end
it 'accepts a lambda with spaces in the right places' do
expect_no_offenses('->( x, y ) { puts x }')
end
it 'registers an offense for no space before first parameter' do
expect_offense(<<~RUBY)
{}.each { |x | puts x }
^ Space before first block parameter missing.
RUBY
expect_correction(<<~RUBY)
{}.each { | x | puts x }
RUBY
end
it 'registers an offense and corrects no space after last parameter' do
expect_offense(<<~RUBY)
{}.each { | x, y| puts x }
^ Space after last block parameter missing.
RUBY
expect_correction(<<~RUBY)
{}.each { | x, y | puts x }
RUBY
end
it 'registers an offense and corrects extra space before first parameter' do
expect_offense(<<~RUBY)
{}.each { | x | puts x }
^ Extra space before first block parameter detected.
RUBY
expect_correction(<<~RUBY)
{}.each { | x | puts x }
RUBY
end
it 'registers an offense and corrects multiple spaces ' \
'after last parameter' do
expect_offense(<<~RUBY)
{}.each { | x, y | puts x }
^^ Extra space after last block parameter detected.
RUBY
expect_correction(<<~RUBY)
{}.each { | x, y | puts x }
RUBY
end
it 'registers an offense and corrects no space after closing pipe' do
expect_offense(<<~RUBY)
{}.each { | x, y |puts x }
^ Space after closing `|` missing.
RUBY
expect_correction(<<~RUBY)
{}.each { | x, y | puts x }
RUBY
end
it 'registers an offense and corrects a lambda for no space ' \
'before first parameter' do
expect_offense(<<~RUBY)
->(x ) { puts x }
^ Space before first block parameter missing.
RUBY
expect_correction(<<~RUBY)
->( x ) { puts x }
RUBY
end
it 'registers an offense and corrects a lambda for ' \
'no space after last parameter' do
expect_offense(<<~RUBY)
->( x, y) { puts x }
^ Space after last block parameter missing.
RUBY
expect_correction(<<~RUBY)
->( x, y ) { puts x }
RUBY
end
it 'registers an offense and corrects a lambda for extra space' \
'before first parameter' do
expect_offense(<<~RUBY)
->( x ) { puts x }
^ Extra space before first block parameter detected.
RUBY
expect_correction(<<~RUBY)
->( x ) { puts x }
RUBY
end
it 'registers an offense and corrects a lambda for multiple spaces' \
'after last parameter' do
expect_offense(<<~RUBY)
->( x, y ) { puts x }
^^ Extra space after last block parameter detected.
RUBY
expect_correction(<<~RUBY)
->( x, y ) { puts x }
RUBY
end
it 'accepts line break after closing pipe' do
expect_no_offenses(<<~RUBY)
{}.each do | x, y |
puts x
end
RUBY
end
it 'registers an offense and corrects multiple spaces before parameter' do
expect_offense(<<~RUBY)
{}.each { | x, y | puts x }
^^ Extra space before block parameter detected.
RUBY
expect_correction(<<~RUBY)
{}.each { | x, y | puts x }
RUBY
end
it 'registers an offense and corrects space with parens at middle' do
expect_offense(<<~RUBY)
{}.each { |(x, y), z| puts x }
^^^^^^^ Space before first block parameter missing.
^ Extra space before block parameter detected.
^ Extra space before block parameter detected.
^ Space after last block parameter missing.
RUBY
expect_correction(<<~RUBY)
{}.each { | (x, y), z | puts x }
RUBY
end
context 'trailing comma' do
it 'accepts space after the last comma' do
expect_no_offenses('{}.each { | x, | puts x }')
end
it 'registers an offense and corrects no space after the last comma' do
expect_offense(<<~RUBY)
{}.each { | x,| puts x }
^ Space after last block parameter missing.
RUBY
expect_correction(<<~RUBY)
{}.each { | x ,| puts x }
RUBY
end
end
it 'registers an offense and corrects block arguments inside Hash#each' do
expect_offense(<<~RUBY)
{}.each { | x=5, (y,*z)|puts x }
^ Space after closing `|` missing.
^^^^^^ Space after last block parameter missing.
^ Extra space before block parameter detected.
^ Extra space before first block parameter detected.
RUBY
expect_correction(<<~RUBY)
{}.each { | x=5, (y,*z) | puts x }
RUBY
end
it 'registers an offense and corrects missing space ' \
'before first argument and after last argument' do
expect_offense(<<~RUBY)
{}.each { |x, z| puts x }
^ Space after last block parameter missing.
^ Space before first block parameter missing.
RUBY
expect_correction(<<~RUBY)
{}.each { | x, z | puts x }
RUBY
end
it 'registers an offense and corrects spacing in lambda args' do
expect_offense(<<~RUBY)
->( x, y) { puts x }
^ Space after last block parameter missing.
^ Extra space before block parameter detected.
^ Extra space before first block parameter detected.
RUBY
expect_correction(<<~RUBY)
->( x, y ) { puts x }
RUBY
end
end
end