/
space_inside_block_braces_spec.rb
397 lines (333 loc) · 9.76 KB
/
space_inside_block_braces_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Layout::SpaceInsideBlockBraces, :config do
let(:supported_styles) { %w[space no_space] }
let(:cop_config) do
{
'EnforcedStyle' => 'space',
'SupportedStyles' => supported_styles,
'SpaceBeforeBlockParameters' => true
}
end
context 'with space inside empty braces not allowed' do
let(:cop_config) { { 'EnforcedStyleForEmptyBraces' => 'no_space' } }
it 'accepts empty braces with no space inside' do
expect_no_offenses('each {}')
end
it 'accepts braces with something inside' do
expect_no_offenses('each { "f" }')
end
it 'accepts multiline braces with content' do
expect_no_offenses(<<~RUBY)
each { %(
) }
RUBY
end
it 'accepts empty braces with comment and line break inside' do
expect_no_offenses(<<~RUBY)
each { # Comment
}
RUBY
end
it 'accepts empty braces with line break inside' do
expect_no_offenses(<<-RUBY.strip_margin('|'))
| each {
| }
RUBY
end
it 'registers an offense and corrects empty braces with space inside' do
expect_offense(<<~RUBY)
each { }
^ Space inside empty braces detected.
RUBY
expect_correction(<<~RUBY)
each {}
RUBY
end
it 'accepts braces that are not empty' do
expect_no_offenses(<<~RUBY)
a {
b
}
RUBY
end
end
context 'with space inside empty braces allowed' do
let(:cop_config) { { 'EnforcedStyleForEmptyBraces' => 'space' } }
it 'accepts empty braces with space inside' do
expect_no_offenses('each { }')
end
it 'registers an offense and corrects empty braces with no space inside' do
expect_offense(<<~RUBY)
each {}
^^ Space missing inside empty braces.
RUBY
expect_correction(<<~RUBY)
each { }
RUBY
end
end
context 'with invalid value for EnforcedStyleForEmptyBraces' do
let(:cop_config) { { 'EnforcedStyleForEmptyBraces' => 'unknown' } }
it 'fails with an error' do
expect { expect_no_offenses('each { }') }
.to raise_error('Unknown EnforcedStyleForEmptyBraces selected!')
end
end
context 'Ruby >= 2.7', :ruby27 do
it 'registers an offense for numblocks without inner space' do
expect_offense(<<~RUBY)
[1, 2, 3].each {_1 * 2}
^ Space missing inside {.
^ Space missing inside }.
RUBY
expect_correction(<<~RUBY)
[1, 2, 3].each { _1 * 2 }
RUBY
end
end
it 'accepts braces surrounded by spaces' do
expect_no_offenses('each { puts }')
end
it 'accepts left brace without outer space' do
expect_no_offenses('each{ puts }')
end
it 'registers an offense and corrects left brace without inner space' do
expect_offense(<<~RUBY)
each {puts }
^ Space missing inside {.
RUBY
expect_correction(<<~RUBY)
each { puts }
RUBY
end
it 'registers an offense and corrects right brace without inner space' do
expect_offense(<<~RUBY)
each { puts}
^ Space missing inside }.
RUBY
expect_correction(<<~RUBY)
each { puts }
RUBY
end
it 'registers an offense and corrects both left and right brace without inner space after success' do
expect_offense(<<~RUBY)
each { puts }
each {puts}
^ Space missing inside {.
^ Space missing inside }.
RUBY
expect_correction(<<~RUBY)
each { puts }
each { puts }
RUBY
end
it 'register offenses and correct both braces without inner space' do
expect_offense(<<~RUBY)
a {}
b { }
^ Space inside empty braces detected.
each {puts}
^ Space missing inside {.
^ Space missing inside }.
RUBY
expect_correction(<<~RUBY)
a {}
b {}
each { puts }
RUBY
end
context 'with passed in parameters' do
context 'for single-line blocks' do
it 'accepts left brace with inner space' do
expect_no_offenses('each { |x| puts }')
end
it 'registers an offense and corrects left brace without inner space' do
expect_offense(<<~RUBY)
each {|x| puts }
^^ Space between { and | missing.
RUBY
expect_correction(<<~RUBY)
each { |x| puts }
RUBY
end
end
context 'for multi-line blocks' do
it 'accepts left brace with inner space' do
expect_no_offenses(<<~RUBY)
each { |x|
puts
}
RUBY
end
it 'registers an offense and corrects left brace without inner space' do
expect_offense(<<~RUBY)
each {|x|
^^ Space between { and | missing.
puts
}
RUBY
expect_correction(<<~RUBY)
each { |x|
puts
}
RUBY
end
end
it 'accepts new lambda syntax' do
expect_no_offenses('->(x) { x }')
end
context 'and BlockDelimiters cop enabled' do
let(:config) do
RuboCop::Config.new('Style/BlockDelimiters' => { 'Enabled' => true },
'Layout/SpaceInsideBlockBraces' => cop_config)
end
it 'registers an offense and corrects for single-line blocks' do
expect_offense(<<~RUBY)
each {|x| puts}
^ Space missing inside }.
^^ Space between { and | missing.
RUBY
expect_correction(<<~RUBY)
each { |x| puts }
RUBY
end
it 'registers an offense and corrects multi-line blocks' do
expect_offense(<<~RUBY)
each {|x|
^^ Space between { and | missing.
puts
}
RUBY
expect_correction(<<~RUBY)
each { |x|
puts
}
RUBY
end
end
context 'and space before block parameters not allowed' do
let(:cop_config) do
{
'EnforcedStyle' => 'space',
'SupportedStyles' => supported_styles,
'SpaceBeforeBlockParameters' => false
}
end
it 'registers an offense and corrects left brace with inner space' do
expect_offense(<<~RUBY)
each { |x| puts }
^ Space between { and | detected.
RUBY
expect_correction(<<~RUBY)
each {|x| puts }
RUBY
end
it 'accepts new lambda syntax' do
expect_no_offenses('->(x) { x }')
end
it 'accepts left brace without inner space' do
expect_no_offenses('each {|x| puts }')
end
end
end
context 'configured with no_space' do
let(:cop_config) do
{
'EnforcedStyle' => 'no_space',
'SupportedStyles' => supported_styles,
'SpaceBeforeBlockParameters' => true
}
end
it 'accepts braces without spaces inside' do
expect_no_offenses('each {puts}')
end
it 'registers an offense and corrects left brace with inner space' do
expect_offense(<<~RUBY)
each { puts}
^ Space inside { detected.
RUBY
expect_correction(<<~RUBY)
each {puts}
RUBY
end
it 'registers an offense and corrects right brace with inner space' do
expect_offense(<<~RUBY)
each {puts }
^ Space inside } detected.
RUBY
expect_correction(<<~RUBY)
each {puts}
RUBY
end
it 'registers an offense and corrects both left and right brace with inner space after success' do
expect_offense(<<~RUBY)
each {puts}
each { puts }
^ Space inside { detected.
^ Space inside } detected.
RUBY
expect_correction(<<~RUBY)
each {puts}
each {puts}
RUBY
end
it 'accepts left brace without outer space' do
expect_no_offenses('each{puts}')
end
context 'with passed in parameters' do
context 'and space before block parameters allowed' do
it 'accepts left brace with inner space' do
expect_no_offenses('each { |x| puts}')
end
it 'registers an offense and corrects left brace without inner space' do
expect_offense(<<~RUBY)
each {|x| puts}
^^ Space between { and | missing.
RUBY
expect_correction(<<~RUBY)
each { |x| puts}
RUBY
end
it 'accepts new lambda syntax' do
expect_no_offenses('->(x) {x}')
end
end
context 'and space before block parameters not allowed' do
let(:cop_config) do
{
'EnforcedStyle' => 'no_space',
'SupportedStyles' => supported_styles,
'SpaceBeforeBlockParameters' => false
}
end
it 'registers an offense and corrects left brace with inner space' do
expect_offense(<<~RUBY)
each { |x| puts}
^ Space between { and | detected.
RUBY
expect_correction(<<~RUBY)
each {|x| puts}
RUBY
end
it 'accepts new lambda syntax' do
expect_no_offenses('->(x) {x}')
end
it 'accepts when braces are aligned in multiline block' do
expect_no_offenses(<<~RUBY)
items.map {|item|
item.do_something
}
RUBY
end
it 'registers an offense when braces are not aligned in multiline block' do
expect_offense(<<~RUBY)
items.map {|item|
item.do_something
^{} Space inside } detected.
}
RUBY
end
end
end
end
end