/
redundant_regexp_character_class_spec.rb
263 lines (223 loc) · 7.6 KB
/
redundant_regexp_character_class_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Style::RedundantRegexpCharacterClass do
subject(:cop) { described_class.new }
context 'with a character class containing a single character' do
it 'registers an offense and corrects' do
expect_offense(<<~RUBY)
foo = /[a]/
^^^ Redundant single-element character class, `[a]` can be replaced with `a`.
RUBY
expect_correction(<<~RUBY)
foo = /a/
RUBY
end
end
context 'with multiple character classes containing single characters' do
it 'registers an offense and corrects' do
expect_offense(<<~RUBY)
foo = /[a]b[c]d/
^^^ Redundant single-element character class, `[a]` can be replaced with `a`.
^^^ Redundant single-element character class, `[c]` can be replaced with `c`.
RUBY
expect_correction(<<~RUBY)
foo = /abcd/
RUBY
end
end
context 'with a character class containing an escaped ]' do
it 'registers an offense and corrects' do
expect_offense(<<~'RUBY')
foo = /[\]]/
^^^^ Redundant single-element character class, `[\]]` can be replaced with `\]`.
RUBY
expect_correction(<<~'RUBY')
foo = /\]/
RUBY
end
end
context 'with a character class containing a space meta-character' do
it 'registers an offense and corrects' do
expect_offense(<<~'RUBY')
foo = /[\s]/
^^^^ Redundant single-element character class, `[\s]` can be replaced with `\s`.
RUBY
expect_correction(<<~'RUBY')
foo = /\s/
RUBY
end
end
context 'with a character class containing a negated-space meta-character' do
it 'registers an offense and corrects' do
expect_offense(<<~'RUBY')
foo = /[\S]/
^^^^ Redundant single-element character class, `[\S]` can be replaced with `\S`.
RUBY
expect_correction(<<~'RUBY')
foo = /\S/
RUBY
end
end
context 'with a character class containing a single unicode code-point' do
it 'registers an offense and corrects' do
expect_offense(<<~'RUBY')
foo = /[\u{06F2}]/
^^^^^^^^^^ Redundant single-element character class, `[\u{06F2}]` can be replaced with `\u{06F2}`.
RUBY
expect_correction(<<~'RUBY')
foo = /\u{06F2}/
RUBY
end
end
context 'with a character class containing a single unicode character property' do
it 'registers an offense and corrects' do
expect_offense(<<~'RUBY')
foo = /[\p{Digit}]/
^^^^^^^^^^^ Redundant single-element character class, `[\p{Digit}]` can be replaced with `\p{Digit}`.
RUBY
expect_correction(<<~'RUBY')
foo = /\p{Digit}/
RUBY
end
end
context 'with a character class containing a single negated unicode character property' do
it 'registers an offense and corrects' do
expect_offense(<<~'RUBY')
foo = /[\P{Digit}]/
^^^^^^^^^^^ Redundant single-element character class, `[\P{Digit}]` can be replaced with `\P{Digit}`.
RUBY
expect_correction(<<~'RUBY')
foo = /\P{Digit}/
RUBY
end
end
context 'with a character class containing an escaped-#' do
it 'registers an offense and corrects' do
expect_offense(<<~'RUBY')
foo = /[\#]/
^^^^ Redundant single-element character class, `[\#]` can be replaced with `\#`.
RUBY
expect_correction(<<~'RUBY')
foo = /\#/
RUBY
end
end
context 'with a character class containing an escaped-b' do
# See https://github.com/rubocop-hq/rubocop/issues/8193 for details - in short \b != [\b] - the
# former matches a word boundary, the latter a backspace character.
it 'does not register an offense' do
expect_no_offenses('foo = /[\b]/')
end
end
context 'with a character class containing a character requiring escape outside' do
# Not implemented for now, since we would have to escape on auto-correct, and the cop message
# would need to be dynamic to not be misleading.
it 'does not register an offense' do
expect_no_offenses('foo = /[+]/')
end
end
context 'with a character class containing escaped character requiring escape outside' do
it 'registers an offense and corrects' do
expect_offense(<<~'RUBY')
foo = /[\+]/
^^^^ Redundant single-element character class, `[\+]` can be replaced with `\+`.
RUBY
expect_correction(<<~'RUBY')
foo = /\+/
RUBY
end
end
context 'with an interpolated unnecessary-character-class regexp' do
it 'registers an offense and corrects' do
expect_offense(<<~'RUBY')
foo = /a#{/[b]/}c/
^^^ Redundant single-element character class, `[b]` can be replaced with `b`.
RUBY
expect_correction(<<~'RUBY')
foo = /a#{/b/}c/
RUBY
end
end
context 'with a negated character class with a single element' do
it 'does not register an offense' do
expect_no_offenses('foo = /[^x]/')
end
end
context 'with a character class containing an interpolation' do
it 'does not register an offense' do
expect_no_offenses('foo = /[#{foo}]/')
end
end
context 'with consecutive escaped square brackets' do
it 'does not register an offense' do
expect_no_offenses('foo = /\[\]/')
end
end
context 'with consecutive escaped square brackets inside a character class' do
it 'does not register an offense' do
expect_no_offenses('foo = /[\[\]]/')
end
end
context 'with escaped square brackets surrounding a single character' do
it 'does not register an offense' do
expect_no_offenses('foo = /\[x\]/')
end
end
context 'with a character class containing two characters' do
it 'does not register an offense' do
expect_no_offenses('foo = /[ab]/')
end
end
context 'with an array index inside an interpolation' do
it 'does not register an offense' do
expect_no_offenses('foo = /a#{b[0]}c/')
end
end
context 'with a character class containing a space' do
context 'when not using free-spaced mode' do
it 'registers an offense and corrects' do
expect_offense(<<~RUBY)
foo = /[ ]/
^^^ Redundant single-element character class, `[ ]` can be replaced with ` `.
RUBY
expect_correction(<<~RUBY)
foo = / /
RUBY
end
end
context 'with an unnecessary-character-class after a comment' do
it 'registers an offense and corrects' do
expect_offense(<<~'RUBY')
foo = /
a # This comment shouldn't affect the position of the offense
[b]
^^^ Redundant single-element character class, `[b]` can be replaced with `b`.
/x
RUBY
expect_correction(<<~'RUBY')
foo = /
a # This comment shouldn't affect the position of the offense
b
/x
RUBY
end
end
context 'when using free-spaced mode' do
context 'with a commented single-element character class' do
it 'does not register an offense' do
expect_no_offenses('foo = /foo # [a]/x')
end
end
context 'with a single space character class' do
it 'does not register an offense with only /x' do
expect_no_offenses('foo = /[ ]/x')
end
it 'does not register an offense with /ix' do
expect_no_offenses('foo = /[ ]/ix')
end
it 'does not register an offense with /iux' do
expect_no_offenses('foo = /[ ]/iux')
end
end
end
end
end