/
out_of_range_regexp_ref.rb
68 lines (58 loc) · 1.7 KB
/
out_of_range_regexp_ref.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
# frozen_string_literal: true
module RuboCop
module Cop
module Lint
# This cops looks for out of range referencing for Regexp, as while capturing groups out of
# out of range reference always returns nil.
#
# @example
#
# /(foo)bar/ =~ 'foobar'
#
# # bad - always returns nil
#
# puts $2 # => nil
#
# # good
#
# puts $1 # => foo
#
class OutOfRangeRegexpRef < Base
MSG = 'Do not use out of range reference for the Regexp.'
def on_new_investigation
@valid_ref = 0
end
def on_regexp(node)
@valid_ref = nil
return if contain_non_literal?(node)
begin
tree = Regexp::Parser.parse(node.content)
# Returns if a regular expression that cannot be processed by regexp_parser gem.
# https://github.com/rubocop-hq/rubocop/issues/8083
rescue Regexp::Scanner::ScannerError
return
end
@valid_ref = regexp_captures(tree)
end
def on_nth_ref(node)
backref, = *node
return if @valid_ref.nil?
add_offense(node) if backref > @valid_ref
end
private
def contain_non_literal?(node)
node.children.size != 2 || !node.children.first.str_type?
end
def regexp_captures(tree)
named_capture = numbered_capture = 0
tree.each_expression do |e|
if e.type?(:group)
e.respond_to?(:name) ? named_capture += 1 : numbered_capture += 1
end
end
named_capture.positive? ? named_capture : numbered_capture
end
end
end
end
end