/
eval_with_location_spec.rb
304 lines (262 loc) · 8.52 KB
/
eval_with_location_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Style::EvalWithLocation, :config do
it 'registers an offense when using `#eval` without any arguments' do
expect_offense(<<~RUBY)
eval <<-CODE
^^^^^^^^^^^^ Pass a binding, `__FILE__` and `__LINE__` to `eval`.
do_something
CODE
RUBY
expect_no_corrections
end
it 'registers an offense when using `Kernel.eval` without any arguments' do
expect_offense(<<~RUBY)
Kernel.eval <<-CODE
^^^^^^^^^^^^^^^^^^^ Pass a binding, `__FILE__` and `__LINE__` to `eval`.
do_something
CODE
RUBY
expect_no_corrections
end
it 'registers an offense when using `::Kernel.eval` without any arguments' do
expect_offense(<<~RUBY)
::Kernel.eval <<-CODE
^^^^^^^^^^^^^^^^^^^^^ Pass a binding, `__FILE__` and `__LINE__` to `eval`.
do_something
CODE
RUBY
expect_no_corrections
end
it 'does not register an offense if `eval` is called on another object' do
expect_no_offenses(<<~RUBY)
foo.eval "CODE"
RUBY
end
it 'registers an offense when using `#eval` with `binding` only' do
expect_offense(<<~RUBY)
eval <<-CODE, binding
^^^^^^^^^^^^^^^^^^^^^ Pass a binding, `__FILE__` and `__LINE__` to `eval`.
do_something
CODE
RUBY
expect_correction(<<~RUBY)
eval <<-CODE, binding, __FILE__, __LINE__ + 1
do_something
CODE
RUBY
end
it 'registers an offense when using `#eval` without lineno' do
expect_offense(<<~RUBY)
eval <<-CODE, binding, __FILE__
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Pass a binding, `__FILE__` and `__LINE__` to `eval`.
do_something
CODE
RUBY
expect_correction(<<~RUBY)
eval <<-CODE, binding, __FILE__, __LINE__ + 1
do_something
CODE
RUBY
end
it 'registers an offense when using `#eval` with an incorrect line number' do
expect_offense(<<~RUBY)
eval 'do_something', binding, __FILE__, __LINE__ + 1
^^^^^^^^^^^^ Incorrect line number for `eval`; use `__LINE__` instead of `__LINE__ + 1`.
RUBY
expect_correction(<<~RUBY)
eval 'do_something', binding, __FILE__, __LINE__
RUBY
end
it 'registers an offense when using `#eval` with a heredoc and ' \
'an incorrect line number' do
expect_offense(<<~RUBY)
eval <<-CODE, binding, __FILE__, __LINE__ + 2
^^^^^^^^^^^^ Incorrect line number for `eval`; use `__LINE__ + 1` instead of `__LINE__ + 2`.
do_something
CODE
RUBY
expect_correction(<<~RUBY)
eval <<-CODE, binding, __FILE__, __LINE__ + 1
do_something
CODE
RUBY
end
it 'registers an offense when using `#eval` with a string on a new line ' do
expect_offense(<<~RUBY)
eval('puts 42',
binding,
__FILE__,
__LINE__)
^^^^^^^^ Incorrect line number for `eval`; use `__LINE__ - 3` instead of `__LINE__`.
RUBY
expect_correction(<<~RUBY)
eval('puts 42',
binding,
__FILE__,
__LINE__ - 3)
RUBY
end
it 'registers an offense when using `#class_eval` without any arguments' do
expect_offense(<<~RUBY)
C.class_eval <<-CODE
^^^^^^^^^^^^^^^^^^^^ Pass `__FILE__` and `__LINE__` to `class_eval`.
do_something
CODE
RUBY
expect_correction(<<~RUBY)
C.class_eval <<-CODE, __FILE__, __LINE__ + 1
do_something
CODE
RUBY
end
it 'registers an offense when using `#module_eval` without any arguments' do
expect_offense(<<~RUBY)
M.module_eval <<-CODE
^^^^^^^^^^^^^^^^^^^^^ Pass `__FILE__` and `__LINE__` to `module_eval`.
do_something
CODE
RUBY
expect_correction(<<~RUBY)
M.module_eval <<-CODE, __FILE__, __LINE__ + 1
do_something
CODE
RUBY
end
it 'registers an offense when using `#instance_eval` without any arguments' do
expect_offense(<<~RUBY)
foo.instance_eval <<-CODE
^^^^^^^^^^^^^^^^^^^^^^^^^ Pass `__FILE__` and `__LINE__` to `instance_eval`.
do_something
CODE
RUBY
expect_correction(<<~RUBY)
foo.instance_eval <<-CODE, __FILE__, __LINE__ + 1
do_something
CODE
RUBY
end
it 'registers an offense when using `#instance_eval` with a string argument in parentheses' do
expect_offense(<<~RUBY)
instance_eval('@foo = foo')
^^^^^^^^^^^^^^^^^^^^^^^^^^^ Pass `__FILE__` and `__LINE__` to `instance_eval`.
RUBY
expect_correction(<<~RUBY)
instance_eval('@foo = foo', __FILE__, __LINE__)
RUBY
end
it 'registers an offense when using `#class_eval` with an incorrect lineno' do
expect_offense(<<~RUBY)
C.class_eval <<-CODE, __FILE__, __LINE__
^^^^^^^^ Incorrect line number for `class_eval`; use `__LINE__ + 1` instead of `__LINE__`.
do_something
CODE
RUBY
expect_correction(<<~RUBY)
C.class_eval <<-CODE, __FILE__, __LINE__ + 1
do_something
CODE
RUBY
end
it 'accepts `eval` with a heredoc, a filename and `__LINE__ + 1`' do
expect_no_offenses(<<~RUBY)
eval <<-CODE, binding, __FILE__, __LINE__ + 1
do_something
CODE
RUBY
end
it 'accepts `eval` with a code that is a variable' do
expect_no_offenses(<<~RUBY)
code = something
eval code
RUBY
end
it 'accepts `eval` with a string, a filename and `__LINE__`' do
expect_no_offenses(<<~RUBY)
eval 'do_something', binding, __FILE__, __LINE__
RUBY
end
it 'accepts `eval` with a string, a filename and `__LINE__` on a new line' do
expect_no_offenses(<<~RUBY)
eval 'do_something', binding, __FILE__,
__LINE__ - 1
RUBY
end
it 'registers an offense when using `eval` with improper arguments' do
expect_offense(<<~RUBY)
eval <<-CODE, binding, 'foo', 'bar'
^^^^^ Incorrect line number for `eval`; use `__LINE__ + 1` instead of `'bar'`.
^^^^^ Incorrect file for `eval`; use `__FILE__` instead of `'foo'`.
do_something
CODE
RUBY
expect_correction(<<~RUBY)
eval <<-CODE, binding, __FILE__, __LINE__ + 1
do_something
CODE
RUBY
end
it 'registers an offense when using `instance_eval` with improper arguments' do
expect_offense(<<~RUBY)
instance_eval <<-CODE, 'foo', 'bar'
^^^^^ Incorrect line number for `instance_eval`; use `__LINE__ + 1` instead of `'bar'`.
^^^^^ Incorrect file for `instance_eval`; use `__FILE__` instead of `'foo'`.
do_something
CODE
RUBY
expect_correction(<<~RUBY)
instance_eval <<-CODE, __FILE__, __LINE__ + 1
do_something
CODE
RUBY
end
it 'registers an offense when using `class_eval` with improper arguments' do
expect_offense(<<~RUBY)
class_eval <<-CODE, 'foo', 'bar'
^^^^^ Incorrect line number for `class_eval`; use `__LINE__ + 1` instead of `'bar'`.
^^^^^ Incorrect file for `class_eval`; use `__FILE__` instead of `'foo'`.
do_something
CODE
RUBY
expect_correction(<<~RUBY)
class_eval <<-CODE, __FILE__, __LINE__ + 1
do_something
CODE
RUBY
end
it 'registers an offense when using `module_eval` with improper arguments' do
expect_offense(<<~RUBY)
module_eval <<-CODE, 'foo', 'bar'
^^^^^ Incorrect line number for `module_eval`; use `__LINE__ + 1` instead of `'bar'`.
^^^^^ Incorrect file for `module_eval`; use `__FILE__` instead of `'foo'`.
do_something
CODE
RUBY
expect_correction(<<~RUBY)
module_eval <<-CODE, __FILE__, __LINE__ + 1
do_something
CODE
RUBY
end
it 'registers an offense when using correct file argument but incorrect line' do
expect_offense(<<~RUBY)
module_eval <<-CODE, __FILE__, 'bar'
^^^^^ Incorrect line number for `module_eval`; use `__LINE__ + 1` instead of `'bar'`.
do_something
CODE
RUBY
expect_correction(<<~RUBY)
module_eval <<-CODE, __FILE__, __LINE__ + 1
do_something
CODE
RUBY
end
it 'does not register an offense when using eval with block argument' do
expect_no_offenses(<<~RUBY)
def self.included(base)
base.class_eval do
include OtherModule
end
end
RUBY
end
end