/
explicit_block_argument_spec.rb
117 lines (102 loc) · 3.06 KB
/
explicit_block_argument_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Style::ExplicitBlockArgument do
subject(:cop) { described_class.new }
it 'registers an offense and corrects when block just yields its arguments' do
expect_offense(<<~RUBY)
def m
items.something(first_arg) { |i| yield i }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Consider using explicit block argument in the surrounding method's signature over `yield`.
end
RUBY
expect_correction(<<~RUBY)
def m(&block)
items.something(first_arg, &block)
end
RUBY
end
it 'registers an offense and corrects when block yields several first its arguments' do
expect_offense(<<~RUBY)
def m
items.something { |i, j| yield i }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Consider using explicit block argument in the surrounding method's signature over `yield`.
end
RUBY
expect_correction(<<~RUBY)
def m(&block)
items.something(&block)
end
RUBY
end
it 'correctly corrects when method already has an explicit block argument' do
expect_offense(<<~RUBY)
def m(&block)
items.something { |i| yield i }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Consider using explicit block argument in the surrounding method's signature over `yield`.
end
RUBY
expect_correction(<<~RUBY)
def m(&block)
items.something(&block)
end
RUBY
end
it 'registers an offense and corrects when method contains multiple `yield`s' do
expect_offense(<<~RUBY)
def m
items.something { |i| yield i }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Consider using explicit block argument in the surrounding method's signature over `yield`.
if condition
yield 2
elsif other_condition
3.times { yield }
else
other_items.something { |i, j| yield i }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Consider using explicit block argument in the surrounding method's signature over `yield`.
end
end
RUBY
expect_correction(<<~RUBY)
def m(&block)
items.something(&block)
if condition
yield 2
elsif other_condition
3.times { yield }
else
other_items.something(&block)
end
end
RUBY
end
it 'does not register an offense when `yield` is not inside block' do
expect_no_offenses(<<~RUBY)
def m
yield i
end
RUBY
end
it 'does not register an offense when `yield` inside block has no arguments' do
expect_no_offenses(<<~RUBY)
def m
3.times { yield }
end
RUBY
end
it 'does not register an offense when `yield` is the sole block body' do
expect_no_offenses(<<~RUBY)
def m
items.something do |i|
do_something
yield i
end
end
RUBY
end
it 'does not register an offense when `yield` arguments is not a prefix of block arguments' do
expect_no_offenses(<<~RUBY)
def m
items.something { |i, j, k| yield j, k }
end
RUBY
end
end