/
space_around_method_call_operator_spec.rb
514 lines (458 loc) · 14 KB
/
space_around_method_call_operator_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Layout::SpaceAroundMethodCallOperator do
subject(:cop) { described_class.new(config) }
let(:config) { RuboCop::Config.new }
shared_examples 'offense' do |name, code, offense, correction|
it "registers an offense when #{name}" do
expect_offense(offense)
end
it "autocorrects offense when #{name}" do
corrected = autocorrect_source(code)
expect(corrected).to eq(correction)
end
end
context 'dot operator' do
include_examples 'offense', 'space after method call',
<<-CODE, <<-OFFENSE, <<-CORRECTION
foo. bar
CODE
foo. bar
^ Avoid using spaces around a method call operator.
OFFENSE
foo.bar
CORRECTION
include_examples 'offense', 'space before method call',
<<-CODE, <<-OFFENSE, <<-CORRECTION
foo .bar
CODE
foo .bar
^ Avoid using spaces around a method call operator.
OFFENSE
foo.bar
CORRECTION
include_examples 'offense', 'spaces before method call',
<<-CODE, <<-OFFENSE, <<-CORRECTION
foo .bar
CODE
foo .bar
^^ Avoid using spaces around a method call operator.
OFFENSE
foo.bar
CORRECTION
include_examples 'offense', 'spaces after method call',
<<-CODE, <<-OFFENSE, <<-CORRECTION
foo. bar
CODE
foo. bar
^^ Avoid using spaces around a method call operator.
OFFENSE
foo.bar
CORRECTION
include_examples 'offense', 'spaces around method call',
<<-CODE, <<-OFFENSE, <<-CORRECTION
foo . bar
CODE
foo . bar
^ Avoid using spaces around a method call operator.
^ Avoid using spaces around a method call operator.
OFFENSE
foo.bar
CORRECTION
include_examples 'offense', 'spaces after `Proc#call` shorthand call',
<<-CODE, <<-OFFENSE, <<-CORRECTION
foo. ()
CODE
foo. ()
^ Avoid using spaces around a method call operator.
OFFENSE
foo.()
CORRECTION
context 'when multi line method call' do
include_examples 'offense', 'space before method call',
<<-CODE, <<-OFFENSE, <<-CORRECTION
foo
. bar
CODE
foo
. bar
^ Avoid using spaces around a method call operator.
OFFENSE
foo
.bar
CORRECTION
include_examples 'offense', 'space before method call in suffix chaining',
<<-CODE, <<-OFFENSE, <<-CORRECTION
foo .
bar
CODE
foo .
^ Avoid using spaces around a method call operator.
bar
OFFENSE
foo.
bar
CORRECTION
it 'does not register an offense when no space after the `.`' do
expect_no_offenses(<<~RUBY)
foo
.bar
RUBY
end
end
it 'does not register an offense when no space around method call' do
expect_no_offenses(<<~RUBY)
'foo'.bar
RUBY
end
include_examples 'offense', 'space after last method call operator',
<<-CODE, <<-OFFENSE, <<-CORRECTION
foo.bar. buzz
CODE
foo.bar. buzz
^ Avoid using spaces around a method call operator.
OFFENSE
foo.bar.buzz
CORRECTION
include_examples 'offense', 'space after first method call operator',
<<-CODE, <<-OFFENSE, <<-CORRECTION
foo. bar.buzz
CODE
foo. bar.buzz
^ Avoid using spaces around a method call operator.
OFFENSE
foo.bar.buzz
CORRECTION
include_examples 'offense', 'space before first method call operator',
<<-CODE, <<-OFFENSE, <<-CORRECTION
foo .bar.buzz
CODE
foo .bar.buzz
^ Avoid using spaces around a method call operator.
OFFENSE
foo.bar.buzz
CORRECTION
include_examples 'offense', 'space before last method call operator',
<<-CODE, <<-OFFENSE, <<-CORRECTION
foo.bar .buzz
CODE
foo.bar .buzz
^ Avoid using spaces around a method call operator.
OFFENSE
foo.bar.buzz
CORRECTION
include_examples 'offense',
'space around intermediate method call operator',
<<-CODE, <<-OFFENSE, <<-CORRECTION
foo.bar .buzz.bat
CODE
foo.bar .buzz.bat
^ Avoid using spaces around a method call operator.
OFFENSE
foo.bar.buzz.bat
CORRECTION
include_examples 'offense', 'space around multiple method call operator',
<<-CODE, <<-OFFENSE, <<-CORRECTION
foo. bar. buzz.bat
CODE
foo. bar. buzz.bat
^ Avoid using spaces around a method call operator.
^ Avoid using spaces around a method call operator.
OFFENSE
foo.bar.buzz.bat
CORRECTION
it 'does not register an offense when no space around any `.` operators' do
expect_no_offenses(<<~RUBY)
foo.bar.buzz
RUBY
end
context 'when there is a space between `.` operator and a comment' do
it 'does not register an offense when there is not a space before `.`' do
expect_no_offenses(<<~RUBY)
foo. # comment
bar.baz
RUBY
end
it 'registers an offense when there is a space before `.`' do
expect_offense(<<~RUBY)
foo . # comment
^ Avoid using spaces around a method call operator.
bar.baz
RUBY
expect_correction(<<~RUBY)
foo. # comment
bar.baz
RUBY
end
end
end
context 'safe navigation operator' do
include_examples 'offense', 'space after method call',
<<-CODE, <<-OFFENSE, <<-CORRECTION
foo&. bar
CODE
foo&. bar
^ Avoid using spaces around a method call operator.
OFFENSE
foo&.bar
CORRECTION
include_examples 'offense', 'space before method call',
<<-CODE, <<-OFFENSE, <<-CORRECTION
foo &.bar
CODE
foo &.bar
^ Avoid using spaces around a method call operator.
OFFENSE
foo&.bar
CORRECTION
include_examples 'offense', 'spaces before method call',
<<-CODE, <<-OFFENSE, <<-CORRECTION
foo &.bar
CODE
foo &.bar
^^ Avoid using spaces around a method call operator.
OFFENSE
foo&.bar
CORRECTION
include_examples 'offense', 'spaces after method call',
<<-CODE, <<-OFFENSE, <<-CORRECTION
foo&. bar
CODE
foo&. bar
^^ Avoid using spaces around a method call operator.
OFFENSE
foo&.bar
CORRECTION
include_examples 'offense', 'spaces around method call',
<<-CODE, <<-OFFENSE, <<-CORRECTION
foo &. bar
CODE
foo &. bar
^ Avoid using spaces around a method call operator.
^ Avoid using spaces around a method call operator.
OFFENSE
foo&.bar
CORRECTION
context 'when multi line method call' do
include_examples 'offense', 'space before method call',
<<-CODE, <<-OFFENSE, <<-CORRECTION
foo
&. bar
CODE
foo
&. bar
^ Avoid using spaces around a method call operator.
OFFENSE
foo
&.bar
CORRECTION
include_examples 'offense', 'space before method call in suffix chaining',
<<-CODE, <<-OFFENSE, <<-CORRECTION
foo &.
bar
CODE
foo &.
^ Avoid using spaces around a method call operator.
bar
OFFENSE
foo&.
bar
CORRECTION
it 'does not register an offense when no space after the `&.`' do
expect_no_offenses(<<~RUBY)
foo
&.bar
RUBY
end
end
it 'does not register an offense when no space around method call' do
expect_no_offenses(<<~RUBY)
foo&.bar
RUBY
end
include_examples 'offense', 'space after last method call operator',
<<-CODE, <<-OFFENSE, <<-CORRECTION
foo&.bar&. buzz
CODE
foo&.bar&. buzz
^ Avoid using spaces around a method call operator.
OFFENSE
foo&.bar&.buzz
CORRECTION
include_examples 'offense', 'space after first method call operator',
<<-CODE, <<-OFFENSE, <<-CORRECTION
foo&. bar&.buzz
CODE
foo&. bar&.buzz
^ Avoid using spaces around a method call operator.
OFFENSE
foo&.bar&.buzz
CORRECTION
include_examples 'offense', 'space before first method call operator',
<<-CODE, <<-OFFENSE, <<-CORRECTION
foo &.bar&.buzz
CODE
foo &.bar&.buzz
^ Avoid using spaces around a method call operator.
OFFENSE
foo&.bar&.buzz
CORRECTION
include_examples 'offense', 'space before last method call operator',
<<-CODE, <<-OFFENSE, <<-CORRECTION
foo&.bar &.buzz
CODE
foo&.bar &.buzz
^ Avoid using spaces around a method call operator.
OFFENSE
foo&.bar&.buzz
CORRECTION
include_examples 'offense',
'space around intermediate method call operator',
<<-CODE, <<-OFFENSE, <<-CORRECTION
foo&.bar &.buzz&.bat
CODE
foo&.bar &.buzz&.bat
^ Avoid using spaces around a method call operator.
OFFENSE
foo&.bar&.buzz&.bat
CORRECTION
include_examples 'offense', 'space around multiple method call operator',
<<-CODE, <<-OFFENSE, <<-CORRECTION
foo&. bar&. buzz&.bat
CODE
foo&. bar&. buzz&.bat
^ Avoid using spaces around a method call operator.
^ Avoid using spaces around a method call operator.
OFFENSE
foo&.bar&.buzz&.bat
CORRECTION
it 'does not register an offense when no space around any `.` operators' do
expect_no_offenses(<<~RUBY)
foo&.bar&.buzz
RUBY
end
end
context ':: operator' do
include_examples 'offense', 'space after method call',
<<-CODE, <<-OFFENSE, <<-CORRECTION
RuboCop:: Cop
CODE
RuboCop:: Cop
^ Avoid using spaces around a method call operator.
OFFENSE
RuboCop::Cop
CORRECTION
include_examples 'offense', 'spaces after method call',
<<-CODE, <<-OFFENSE, <<-CORRECTION
RuboCop:: Cop
CODE
RuboCop:: Cop
^^ Avoid using spaces around a method call operator.
OFFENSE
RuboCop::Cop
CORRECTION
context 'when multi line method call' do
include_examples 'offense', 'space before method call',
<<-CODE, <<-OFFENSE, <<-CORRECTION
RuboCop
:: Cop
CODE
RuboCop
:: Cop
^ Avoid using spaces around a method call operator.
OFFENSE
RuboCop
::Cop
CORRECTION
it 'does not register an offense when no space after the `::`' do
expect_no_offenses(<<~RUBY)
RuboCop
::Cop
RUBY
end
end
it 'does not register an offense when no space around method call' do
expect_no_offenses(<<~RUBY)
RuboCop::Cop
RUBY
end
include_examples 'offense', 'space after last method call operator',
<<-CODE, <<-OFFENSE, <<-CORRECTION
RuboCop::Cop:: Cop
CODE
RuboCop::Cop:: Cop
^ Avoid using spaces around a method call operator.
OFFENSE
RuboCop::Cop::Cop
CORRECTION
include_examples 'offense',
'space around intermediate method call operator',
<<-CODE, <<-OFFENSE, <<-CORRECTION
RuboCop::Cop:: Cop::Cop
CODE
RuboCop::Cop:: Cop::Cop
^ Avoid using spaces around a method call operator.
OFFENSE
RuboCop::Cop::Cop::Cop
CORRECTION
include_examples 'offense', 'space around multiple method call operator',
<<-CODE, <<-OFFENSE, <<-CORRECTION
:: RuboCop:: Cop:: Cop::Cop
CODE
:: RuboCop:: Cop:: Cop::Cop
^ Avoid using spaces around a method call operator.
^ Avoid using spaces around a method call operator.
^ Avoid using spaces around a method call operator.
OFFENSE
::RuboCop::Cop::Cop::Cop
CORRECTION
include_examples 'offense', 'space after first operator with assignment',
<<-CODE, <<-OFFENSE, <<-CORRECTION
klass = :: RuboCop::Cop
CODE
klass = :: RuboCop::Cop
^ Avoid using spaces around a method call operator.
OFFENSE
klass = ::RuboCop::Cop
CORRECTION
it 'does not register an offense when no space around any `.` operators' do
expect_no_offenses(<<~RUBY)
RuboCop::Cop::Cop
RUBY
end
it 'does not register an offense if no space before `::`
operator with assignment' do
expect_no_offenses(<<~RUBY)
klass = ::RuboCop::Cop
RUBY
end
it 'does not register an offense if no space before `::`
operator with inheritance' do
expect_no_offenses(<<~RUBY)
class Test < ::RuboCop::Cop
end
RUBY
end
it 'does not register an offense if no space with
conditionals' do
expect_no_offenses(<<~RUBY)
::RuboCop::Cop || ::RuboCop
RUBY
end
include_examples 'offense', 'multiple spaces with assignment',
<<-CODE, <<-OFFENSE, <<-CORRECTION
:: RuboCop:: Cop || :: RuboCop
CODE
:: RuboCop:: Cop || :: RuboCop
^ Avoid using spaces around a method call operator.
^ Avoid using spaces around a method call operator.
^ Avoid using spaces around a method call operator.
OFFENSE
::RuboCop::Cop || ::RuboCop
CORRECTION
end
it 'does not register an offense when no method call operator' do
expect_no_offenses(<<~RUBY)
'foo' + 'bar'
RUBY
end
end