-
-
Notifications
You must be signed in to change notification settings - Fork 3k
/
empty_method_spec.rb
221 lines (182 loc) · 6.39 KB
/
empty_method_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Style::EmptyMethod, :config do
before do
inspect_source(source)
end
shared_examples 'code with offense' do |code, expected|
context "when checking #{code}" do
let(:source) { code }
it 'registers an offense' do
expect(cop.offenses.size).to eq(1)
expect(cop.messages).to eq([message])
end
if expected
it 'auto-corrects' do
expect(autocorrect_source(code)).to eq(expected)
end
else
it 'does not auto-correct' do
expect(autocorrect_source(code)).to eq(code)
end
end
end
end
shared_examples 'code without offense' do |code|
let(:source) { code }
it 'does not register an offense' do
expect(cop.offenses.empty?).to be(true)
end
end
context 'when configured with compact style' do
let(:cop_config) { { 'EnforcedStyle' => 'compact' } }
let(:message) { 'Put empty method definitions on a single line.' }
context 'with an empty instance method definition' do
it_behaves_like 'code with offense',
['def foo',
'end'].join("\n"),
'def foo; end'
it_behaves_like 'code with offense',
['def foo(bar, baz)',
'end'].join("\n"),
'def foo(bar, baz); end'
it_behaves_like 'code with offense',
['def foo bar, baz',
'end'].join("\n"),
'def foo bar, baz; end'
it_behaves_like 'code with offense',
['def foo',
'',
'end'].join("\n"),
'def foo; end'
it_behaves_like 'code with offense',
['def foo(arg',
'); end'].join("\n"),
'def foo(arg); end'
it_behaves_like 'code without offense',
'def foo; end'
end
context 'with a non-empty instance method definition' do
it_behaves_like 'code without offense',
<<~RUBY
def foo
bar
end
RUBY
it_behaves_like 'code without offense',
'def foo; bar; end'
it_behaves_like 'code without offense',
<<~RUBY
def foo
# bar
end
RUBY
end
context 'with an empty class method definition' do
it_behaves_like 'code with offense',
['def self.foo',
'end'].join("\n"),
'def self.foo; end'
it_behaves_like 'code with offense',
['def self.foo(bar, baz)',
'end'].join("\n"),
'def self.foo(bar, baz); end'
it_behaves_like 'code with offense',
['def self.foo',
'',
'end'].join("\n"),
'def self.foo; end'
it_behaves_like 'code without offense',
'def self.foo; end'
end
context 'with a non-empty class method definition' do
it_behaves_like 'code without offense',
<<~RUBY
def self.foo
bar
end
RUBY
it_behaves_like 'code without offense',
'def self.foo; bar; end'
it_behaves_like 'code without offense',
<<~RUBY
def self.foo
# bar
end
RUBY
end
end
context 'when configured with expanded style' do
let(:cop_config) { { 'EnforcedStyle' => 'expanded' } }
let(:message) do
'Put the `end` of empty method definitions on the next line.'
end
context 'with an empty instance method definition' do
it_behaves_like 'code without offense',
['def foo',
'end'].join("\n")
it_behaves_like 'code without offense',
['def foo',
'',
'end'].join("\n")
it_behaves_like 'code with offense',
'def foo; end',
['def foo',
'end'].join("\n")
end
context 'with a non-empty instance method definition' do
it_behaves_like 'code without offense',
<<~RUBY
def foo
bar
end
RUBY
it_behaves_like 'code without offense',
'def foo; bar; end'
it_behaves_like 'code without offense',
<<~RUBY
def foo
# bar
end
RUBY
end
context 'with an empty class method definition' do
it_behaves_like 'code without offense',
['def self.foo',
'end'].join("\n")
it_behaves_like 'code without offense',
['def self.foo',
'',
'end'].join("\n")
it_behaves_like 'code with offense',
'def self.foo; end',
['def self.foo',
'end'].join("\n")
end
context 'with a non-empty class method definition' do
it_behaves_like 'code without offense',
<<~RUBY
def self.foo
bar
end
RUBY
it_behaves_like 'code without offense',
'def self.foo; bar; end'
it_behaves_like 'code without offense',
<<~RUBY
def self.foo
# bar
end
RUBY
end
context 'when method is nested in class scope' do
it_behaves_like 'code with offense',
['class Foo',
' def bar; end',
'end'].join("\n"),
['class Foo',
' def bar',
' end',
'end'].join("\n")
end
end
end