/
redundant_string_coercion.rb
59 lines (50 loc) · 1.3 KB
/
redundant_string_coercion.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
# frozen_string_literal: true
module RuboCop
module Cop
module Lint
# This cop checks for string conversion in string interpolation,
# which is redundant.
#
# @example
#
# # bad
#
# "result is #{something.to_s}"
#
# @example
#
# # good
#
# "result is #{something}"
class RedundantStringCoercion < Cop
include Interpolation
MSG_DEFAULT = 'Redundant use of `Object#to_s` in interpolation.'
MSG_SELF = 'Use `self` instead of `Object#to_s` in ' \
'interpolation.'
def_node_matcher :to_s_without_args?, '(send _ :to_s)'
def on_interpolation(begin_node)
final_node = begin_node.children.last
return unless to_s_without_args?(final_node)
add_offense(final_node, location: :selector)
end
def autocorrect(node)
lambda do |corrector|
receiver = node.receiver
corrector.replace(
node,
if receiver
receiver.source
else
'self'
end
)
end
end
private
def message(node)
node.receiver ? MSG_DEFAULT : MSG_SELF
end
end
end
end
end