/
redundant_parentheses_spec.rb
281 lines (245 loc) · 9.43 KB
/
redundant_parentheses_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Style::RedundantParentheses do
subject(:cop) { described_class.new }
shared_examples 'redundant' do |expr, correct, type, highlight = nil|
it "registers an offense for parentheses around #{type}" do
inspect_source(expr)
expect(cop.messages)
.to eq(["Don't use parentheses around #{type}."])
expect(cop.highlights).to eq([highlight || expr])
end
it 'auto-corrects' do
expect(autocorrect_source(expr)).to eq correct
end
end
shared_examples 'plausible' do |expr|
it 'accepts parentheses when arguments are unparenthesized' do
expect_no_offenses(expr)
end
end
shared_examples 'keyword with return value' do |keyword|
it_behaves_like 'redundant', "(#{keyword})", keyword, 'a keyword'
it_behaves_like 'redundant', "(#{keyword}())", "#{keyword}()", 'a keyword'
it_behaves_like 'redundant', "(#{keyword}(1))", "#{keyword}(1)", 'a keyword'
it_behaves_like 'plausible', "(#{keyword} 1, 2)"
end
shared_examples 'keyword with arguments' do |keyword|
it_behaves_like 'redundant', "(#{keyword})", keyword, 'a keyword'
it_behaves_like 'redundant', "(#{keyword}())", "#{keyword}()", 'a keyword'
it_behaves_like 'redundant', "(#{keyword}(1, 2))", "#{keyword}(1, 2)",
'a keyword'
it_behaves_like 'plausible', "(#{keyword} 1, 2)"
end
it_behaves_like 'redundant', '("x")', '"x"', 'a literal'
it_behaves_like 'redundant', '("#{x}")', '"#{x}"', 'a literal'
it_behaves_like 'redundant', '(:x)', ':x', 'a literal'
it_behaves_like 'redundant', '(:"#{x}")', ':"#{x}"', 'a literal'
it_behaves_like 'redundant', '(1)', '1', 'a literal'
it_behaves_like 'redundant', '(1.2)', '1.2', 'a literal'
it_behaves_like 'redundant', '({})', '{}', 'a literal'
it_behaves_like 'redundant', '([])', '[]', 'a literal'
it_behaves_like 'redundant', '(nil)', 'nil', 'a literal'
it_behaves_like 'redundant', '(true)', 'true', 'a literal'
it_behaves_like 'redundant', '(false)', 'false', 'a literal'
it_behaves_like 'redundant', '(/regexp/)', '/regexp/', 'a literal'
it_behaves_like 'redundant', '("x"; "y")', '"x"; "y"', 'a literal'
it_behaves_like 'redundant', '(1; 2)', '1; 2', 'a literal'
it_behaves_like 'redundant', '(1i)', '1i', 'a literal'
it_behaves_like 'redundant', '(1r)', '1r', 'a literal'
it_behaves_like 'redundant', '(__FILE__)', '__FILE__', 'a keyword'
it_behaves_like 'redundant', '(__LINE__)', '__LINE__', 'a keyword'
it_behaves_like 'redundant', '(__ENCODING__)', '__ENCODING__', 'a keyword'
it_behaves_like 'redundant', '(redo)', 'redo', 'a keyword'
it_behaves_like 'redundant', '(retry)', 'retry', 'a keyword'
it_behaves_like 'redundant', '(self)', 'self', 'a keyword'
it_behaves_like 'redundant', '(X) ? Y : N', 'X ? Y : N', 'a constant', '(X)'
it_behaves_like 'redundant', '(X)? Y : N', 'X ? Y : N', 'a constant', '(X)'
it_behaves_like 'keyword with return value', 'break'
it_behaves_like 'keyword with return value', 'next'
it_behaves_like 'keyword with return value', 'return'
it_behaves_like 'keyword with arguments', 'super'
it_behaves_like 'keyword with arguments', 'yield'
it_behaves_like 'redundant', '(defined?(:A))', 'defined?(:A)', 'a keyword'
it_behaves_like 'plausible', '(defined? :A)'
it_behaves_like 'plausible', '(alias a b)'
it_behaves_like 'plausible', '(not 1)'
it_behaves_like 'plausible', '(a until b)'
it_behaves_like 'plausible', '(a while b)'
it_behaves_like 'redundant', 'x = 1; (x)', 'x = 1; x', 'a variable', '(x)'
it_behaves_like 'redundant', '(@x)', '@x', 'a variable'
it_behaves_like 'redundant', '(@@x)', '@@x', 'a variable'
it_behaves_like 'redundant', '($x)', '$x', 'a variable'
it_behaves_like 'redundant', '(X)', 'X', 'a constant'
it_behaves_like 'redundant', '(x)', 'x', 'a method call'
it_behaves_like 'redundant', '(x(1, 2))', 'x(1, 2)', 'a method call'
it_behaves_like 'redundant', '("x".to_sym)', '"x".to_sym', 'a method call'
it_behaves_like 'redundant', '("x"&.to_sym)', '"x"&.to_sym', 'a method call'
it_behaves_like 'redundant', '(x[:y])', 'x[:y]', 'a method call'
it_behaves_like 'redundant', '("foo"[0])', '"foo"[0]', 'a method call'
it_behaves_like 'redundant', '(["foo"][0])', '["foo"][0]', 'a method call'
it_behaves_like 'redundant', '({0 => :a}[0])', '{0 => :a}[0]', 'a method call'
it_behaves_like 'redundant', '(x; y)', 'x; y', 'a method call'
it_behaves_like 'redundant', '(!x)', '!x', 'an unary operation'
it_behaves_like 'redundant', '(~x)', '~x', 'an unary operation'
it_behaves_like 'redundant', '(-x)', '-x', 'an unary operation'
it_behaves_like 'redundant', '(+x)', '+x', 'an unary operation'
it_behaves_like 'plausible', '(!x.m arg)'
it_behaves_like 'plausible', '(!x).y'
it_behaves_like 'plausible', '-(1.foo)'
it_behaves_like 'plausible', '+(1.foo)'
it_behaves_like 'plausible', '-(1.foo.bar)'
it_behaves_like 'plausible', '+(1.foo.bar)'
it_behaves_like 'plausible', '()'
it_behaves_like 'redundant', '[(1)]', '[1]', 'a literal', '(1)'
it_behaves_like 'redundant', "[(1\n)]", "[1\n]", 'a literal', "(1\n)"
it_behaves_like 'plausible', "[(1\n),]"
it_behaves_like 'redundant', '{a: (1)}', '{a: 1}', 'a literal', '(1)'
it_behaves_like 'redundant', "{a: (1\n)}", "{a: 1\n}", 'a literal', "(1\n)"
it_behaves_like 'plausible', "{a: (1\n),}"
it_behaves_like 'redundant', '(0)**2', '0**2', 'a literal', '(0)'
it_behaves_like 'redundant', '(2)**2', '2**2', 'a literal', '(2)'
it_behaves_like 'redundant', '(2.1)**2', '2.1**2', 'a literal', '(2.1)'
it_behaves_like 'redundant', '2**(-2)', '2**-2', 'a literal', '(-2)'
it_behaves_like 'redundant', '2**(2)', '2**2', 'a literal', '(2)'
it_behaves_like 'plausible', '(-2)**2'
it_behaves_like 'plausible', '(-2.1)**2'
it_behaves_like 'plausible', 'x = (foo; bar)'
it_behaves_like 'plausible', 'x += (foo; bar)'
it_behaves_like 'plausible', 'x + (foo; bar)'
it_behaves_like 'plausible', 'x((foo; bar))'
it_behaves_like 'redundant', <<-RUBY, <<-RUBY2, 'a method call', '(foo; bar)'
def x
(foo; bar)
end
RUBY
def x
foo; bar
end
RUBY2
it_behaves_like 'redundant', <<-RUBY, <<-RUBY2, 'a method call', '(foo; bar)'
def x
baz
(foo; bar)
end
RUBY
def x
baz
foo; bar
end
RUBY2
it_behaves_like 'redundant', <<-RUBY, <<-RUBY2, 'a method call', '(foo; bar)'
x do
(foo; bar)
end
RUBY
x do
foo; bar
end
RUBY2
it_behaves_like 'redundant', <<-RUBY, <<-RUBY2, 'a method call', '(foo; bar)'
x do
baz
(foo; bar)
end
RUBY
x do
baz
foo; bar
end
RUBY2
it 'accepts parentheses around a method call with unparenthesized ' \
'arguments' do
expect_no_offenses('(a 1, 2) && (1 + 1)')
end
it 'accepts parentheses inside an irange' do
expect_no_offenses('(a)..(b)')
end
it 'accepts parentheses inside an erange' do
expect_no_offenses('(a)...(b)')
end
it 'accepts parentheses around an irange' do
expect_no_offenses('(a..b)')
end
it 'accepts parentheses around an erange' do
expect_no_offenses('(a...b)')
end
it 'accepts parentheses around operator keywords' do
expect_no_offenses('(1 and 2) and (3 or 4)')
end
it 'registers an offense when there is space around the parentheses' do
expect_offense(<<~RUBY)
if x; y else (1) end
^^^ Don't use parentheses around a literal.
RUBY
end
it 'accepts parentheses when enclosed in parentheses at `while-post`' do
expect_no_offenses(<<~RUBY)
begin
do_something
end while(bar)
RUBY
end
it 'accepts parentheses when enclosed in parentheses at `until-post`' do
expect_no_offenses(<<~RUBY)
begin
do_something
end until(bar)
RUBY
end
it 'accepts parentheses when they touch the preceding keyword' do
expect_no_offenses('if x; y else(1) end')
end
it 'accepts parentheses when they touch the following keyword' do
expect_no_offenses('if x; y else (1)end')
end
context 'when the first argument in a method call begins with a hash '\
'literal' do
it 'accepts parentheses if the argument list is not parenthesized ' do
expect_no_offenses('x ({ y: 1 }), z')
expect_no_offenses('x ({ y: 1 }.merge({ y: 2 })), z')
expect_no_offenses('x ({ y: 1 }.merge({ y: 2 }).merge({ y: 3 })), z')
end
it 'registers an offense if the argument list is parenthesized ' do
expect_offense(<<~RUBY)
x(({ y: 1 }), z)
^^^^^^^^^^ Don't use parentheses around a literal.
RUBY
end
end
context 'when a hash literal is the second argument in a method call' do
it 'registers an offense' do
expect_offense(<<~RUBY)
x ({ y: 1 }), ({ y: 1 })
^^^^^^^^^^ Don't use parentheses around a literal.
RUBY
end
end
context 'when a non-parenthesized call has an arg and a block' do
it 'accepts parens around the arg' do
expect_no_offenses('method (:arg) { blah }')
end
end
it 'accepts parentheses around the error passed to rescue' do
expect_no_offenses(<<~RUBY)
begin
some_method
rescue(StandardError)
end
RUBY
end
it 'accepts parentheses around a constant passed to when' do
expect_no_offenses(<<~RUBY)
case foo
when(Const)
bar
end
RUBY
end
it 'accepts parentheses in super call with hash' do
expect_no_offenses(<<~RUBY)
super ({
foo: bar,
})
RUBY
end
end