/
dot_position.rb
105 lines (90 loc) · 2.89 KB
/
dot_position.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
# frozen_string_literal: true
module RuboCop
module Cop
module Layout
# This cop checks the . position in multi-line method calls.
#
# @example EnforcedStyle: leading (default)
# # bad
# something.
# method
#
# # good
# something
# .method
#
# @example EnforcedStyle: trailing
# # bad
# something
# .method
#
# # good
# something.
# method
class DotPosition < Cop
include ConfigurableEnforcedStyle
def on_send(node)
return unless node.dot? || ampersand_dot?(node)
if proper_dot_position?(node)
correct_style_detected
else
add_offense(node, location: :dot) { opposite_style_detected }
end
end
alias on_csend on_send
def autocorrect(node)
lambda do |corrector|
dot = node.loc.dot.source
corrector.remove(node.loc.dot)
case style
when :leading
corrector.insert_before(selector_range(node), dot)
when :trailing
corrector.insert_after(node.receiver, dot)
end
end
end
private
def message(node)
dot = node.loc.dot.source
"Place the #{dot} on the " +
case style
when :leading
'next line, together with the method name.'
when :trailing
'previous line, together with the method call receiver.'
end
end
def proper_dot_position?(node)
receiver_line = node.receiver.source_range.end.line
selector_line = selector_range(node).line
# receiver and selector are on the same line
return true if selector_line == receiver_line
dot_line = node.loc.dot.line
# don't register an offense if there is a line comment between the
# dot and the selector otherwise, we might break the code while
# "correcting" it (even if there is just an extra blank line, treat
# it the same)
return true if line_between?(selector_line, dot_line)
correct_dot_position_style?(dot_line, selector_line)
end
def line_between?(first_line, second_line)
(first_line - second_line) > 1
end
def correct_dot_position_style?(dot_line, selector_line)
case style
when :leading then dot_line == selector_line
when :trailing then dot_line != selector_line
end
end
def selector_range(node)
# l.(1) has no selector, so we use the opening parenthesis instead
node.loc.selector || node.loc.begin
end
def ampersand_dot?(node)
node.loc.respond_to?(:dot) && node.loc.dot && node.loc.dot.is?('&.')
end
end
end
end
end