/
empty_conditional_body_spec.rb
94 lines (83 loc) · 2.18 KB
/
empty_conditional_body_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Lint::EmptyConditionalBody, :config do
let(:cop_config) do
{ 'AllowComments' => true }
end
it 'registers an offense for missing `if` body' do
expect_offense(<<~RUBY)
if condition
^^^^^^^^^^^^ Avoid `if` branches without a body.
end
RUBY
end
it 'does not register an offense for missing `if` body with a comment' do
expect_no_offenses(<<~RUBY)
if condition
# noop
end
RUBY
end
it 'registers an offense for missing `elsif` body' do
expect_offense(<<~RUBY)
if condition
do_something
elsif other_condition
^^^^^^^^^^^^^^^^^^^^^ Avoid `elsif` branches without a body.
end
RUBY
end
it 'does not register an offense for missing `elsif` body with a comment' do
expect_no_offenses(<<~RUBY)
if condition
do_something
elsif other_condition
# noop
end
RUBY
end
it 'registers an offense for missing `unless` body' do
expect_offense(<<~RUBY)
unless condition
^^^^^^^^^^^^^^^^ Avoid `unless` branches without a body.
end
RUBY
end
it 'does not register an offense for missing `unless` body with a comment' do
expect_no_offenses(<<~RUBY)
unless condition
# noop
end
RUBY
end
context 'when AllowComments is false' do
let(:cop_config) do
{ 'AllowComments' => false }
end
it 'registers an offense for missing `if` body with a comment' do
expect_offense(<<~RUBY)
if condition
^^^^^^^^^^^^ Avoid `if` branches without a body.
# noop
end
RUBY
end
it 'registers an offense for missing `elsif` body with a comment' do
expect_offense(<<~RUBY)
if condition
do_something
elsif other_condition
^^^^^^^^^^^^^^^^^^^^^ Avoid `elsif` branches without a body.
# noop
end
RUBY
end
it 'registers an offense for missing `unless` body with a comment' do
expect_offense(<<~RUBY)
unless condition
^^^^^^^^^^^^^^^^ Avoid `unless` branches without a body.
# noop
end
RUBY
end
end
end