/
class_and_module_children_spec.rb
160 lines (142 loc) · 3.63 KB
/
class_and_module_children_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Style::ClassAndModuleChildren, :config do
context 'nested style' do
let(:cop_config) { { 'EnforcedStyle' => 'nested' } }
it 'registers an offense for not nested classes' do
expect_offense(<<~RUBY)
class FooClass::BarClass
^^^^^^^^^^^^^^^^^^ Use nested module/class definitions instead of compact style.
end
RUBY
expect_correction(<<~RUBY)
module FooClass
class BarClass
end
end
RUBY
end
it 'registers an offense for not nested classes with explicit superclass' do
expect_offense(<<~RUBY)
class FooClass::BarClass < Super
^^^^^^^^^^^^^^^^^^ Use nested module/class definitions instead of compact style.
end
RUBY
expect_correction(<<~RUBY)
module FooClass
class BarClass < Super
end
end
RUBY
end
it 'registers an offense for not nested modules' do
expect_offense(<<~RUBY)
module FooModule::BarModule
^^^^^^^^^^^^^^^^^^^^ Use nested module/class definitions instead of compact style.
end
RUBY
expect_correction(<<~RUBY)
module FooModule
module BarModule
end
end
RUBY
end
it 'accepts nested children' do
expect_no_offenses(<<~RUBY)
class FooClass
class BarClass
end
end
module FooModule
module BarModule
end
end
RUBY
end
it 'accepts cbase class name' do
expect_no_offenses(<<~RUBY)
class ::Foo
end
RUBY
end
it 'accepts :: in parent class on inheritance' do
expect_no_offenses(<<~RUBY)
class FooClass
class BarClass
end
end
class BazClass < FooClass::BarClass
end
RUBY
end
end
context 'compact style' do
let(:cop_config) { { 'EnforcedStyle' => 'compact' } }
it 'registers a offense for classes with nested children' do
expect_offense(<<~RUBY)
class FooClass
^^^^^^^^ Use compact module/class definition instead of nested style.
class BarClass
end
end
RUBY
expect_correction(<<~RUBY)
class FooClass::BarClass
end
RUBY
end
it 'registers a offense for modules with nested children' do
expect_offense(<<~RUBY)
module FooModule
^^^^^^^^^ Use compact module/class definition instead of nested style.
module BarModule
end
end
RUBY
expect_correction(<<~RUBY)
module FooModule::BarModule
end
RUBY
end
it 'accepts compact style for classes/modules' do
expect_no_offenses(<<~RUBY)
class FooClass::BarClass
end
module FooClass::BarModule
end
RUBY
end
it 'accepts nesting for classes/modules with more than one child' do
expect_no_offenses(<<~RUBY)
class FooClass
class BarClass
end
class BazClass
end
end
module FooModule
module BarModule
end
class BazModule
end
end
RUBY
end
it 'accepts class/module with single method' do
expect_no_offenses(<<~RUBY)
class FooClass
def bar_method
end
end
RUBY
end
it 'accepts nesting for classes with an explicit superclass' do
expect_no_offenses(<<~RUBY)
class FooClass < Super
class BarClass
end
end
RUBY
end
end
end