/
non_deterministic_require_order_spec.rb
200 lines (185 loc) · 6.2 KB
/
non_deterministic_require_order_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Lint::NonDeterministicRequireOrder do
subject(:cop) { described_class.new(config) }
let(:config) { RuboCop::Config.new }
context 'when requiring files' do
context 'with unsorted index' do
it 'registers an offsense and autocorrects to add .sort' do
expect_offense(<<~RUBY)
Dir["./lib/**/*.rb"].each do |file|
^^^^^^^^^^^^^^^^^^^^^^^^^ Sort files before requiring them.
require file
end
RUBY
expect_correction(<<~RUBY)
Dir["./lib/**/*.rb"].sort.each do |file|
require file
end
RUBY
end
it 'registers an offsense with extra logic' do
expect_offense(<<~RUBY)
Dir["./lib/**/*.rb"].each do |file|
^^^^^^^^^^^^^^^^^^^^^^^^^ Sort files before requiring them.
if file.start_with?('_')
puts "Not required."
else
require file
end
end
RUBY
expect_correction(<<~RUBY)
Dir["./lib/**/*.rb"].sort.each do |file|
if file.start_with?('_')
puts "Not required."
else
require file
end
end
RUBY
end
context 'with require block passed as parameter' do
it 'registers an offense an autocorrects to add sort' do
expect_offense(<<~RUBY)
Dir["./lib/**/*.rb"].each(&method(:require))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Sort files before requiring them.
RUBY
expect_correction(<<~RUBY)
Dir["./lib/**/*.rb"].sort.each(&method(:require))
RUBY
end
end
context 'with top-level ::Dir' do
it 'registers an offense and corrects to add .sort' do
expect_offense(<<~RUBY)
::Dir["./lib/**/*.rb"].each do |file|
^^^^^^^^^^^^^^^^^^^^^^^^^^^ Sort files before requiring them.
require file
end
RUBY
expect_correction(<<~RUBY)
::Dir["./lib/**/*.rb"].sort.each do |file|
require file
end
RUBY
end
end
end
context 'with unsorted glob' do
it 'registers an offsense and autocorrects to add .sort' do
expect_offense(<<~RUBY)
Dir.glob(Rails.root.join(__dir__, 'test', '*.rb'), File::FNM_DOTMATCH).each do |file|
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Sort files before requiring them.
require file
end
RUBY
expect_correction(<<~RUBY)
Dir.glob(Rails.root.join(__dir__, 'test', '*.rb'), File::FNM_DOTMATCH).sort.each do |file|
require file
end
RUBY
end
context 'with require block passed as parameter' do
it 'registers an offense an autocorrects to add sort' do
expect_offense(<<~RUBY)
Dir.glob(Rails.root.join('test', '*.rb')).each(&method(:require))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Sort files before requiring them.
RUBY
expect_correction(<<~RUBY)
Dir.glob(Rails.root.join('test', '*.rb')).sort.each(&method(:require))
RUBY
end
end
context 'with top-level ::Dir' do
it 'registers an offense and corrects to add .sort' do
expect_offense(<<~RUBY)
::Dir.glob(Rails.root.join(__dir__, 'test', '*.rb'), ::File::FNM_DOTMATCH).each do |file|
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Sort files before requiring them.
require file
end
RUBY
expect_correction(<<~RUBY)
::Dir.glob(Rails.root.join(__dir__, 'test', '*.rb'), ::File::FNM_DOTMATCH).sort.each do |file|
require file
end
RUBY
end
end
end
context 'with direct block glob' do
it 'registers an offsense and autocorrects to add .sort.each' do
expect_offense(<<~RUBY)
Dir.glob("./lib/**/*.rb") do |file|
^^^^^^^^^^^^^^^^^^^^^^^^^ Sort files before requiring them.
require file
end
RUBY
expect_correction(<<~RUBY)
Dir.glob("./lib/**/*.rb").sort.each do |file|
require file
end
RUBY
end
context 'with require block passed as parameter' do
it 'registers an offense and autocorrects to add sort' do
expect_offense(<<~RUBY)
Dir.glob(
^^^^^^^^^ Sort files before requiring them.
Rails.root.join('./lib/**/*.rb'),
File::FNM_DOTMATCH,
&method(:require)
)
RUBY
expect_correction(<<~RUBY)
Dir.glob(
Rails.root.join('./lib/**/*.rb'),
File::FNM_DOTMATCH
).sort.each(&method(:require))
RUBY
end
end
context 'with top-level ::Dir' do
it 'registers an offense and corrects to add .sort.each' do
expect_offense(<<~RUBY)
::Dir.glob("./lib/**/*.rb") do |file|
^^^^^^^^^^^^^^^^^^^^^^^^^^^ Sort files before requiring them.
require file
end
RUBY
expect_correction(<<~RUBY)
::Dir.glob("./lib/**/*.rb").sort.each do |file|
require file
end
RUBY
end
end
end
context 'with sorted index' do
it 'does not register an offense' do
expect_no_offenses(<<~RUBY)
Dir["./lib/**/*.rb"].sort.each do |file|
require file
end
RUBY
end
end
context 'with sorted glob' do
it 'does not register an offense' do
expect_no_offenses(<<~RUBY)
Dir.glob(Rails.root.join(__dir__, 'test', '*.rb'), File::FNM_DOTMATCH).sort.each do |file|
require file
end
RUBY
end
end
end
context 'when not requiring files' do
it 'does not register an offense' do
expect_no_offenses(<<~RUBY)
Dir["./lib/**/*.rb"].each do |file|
puts file
end
RUBY
end
end
end