-
-
Notifications
You must be signed in to change notification settings - Fork 3k
/
empty_lines_around_class_body_spec.rb
423 lines (331 loc) · 9.11 KB
/
empty_lines_around_class_body_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Layout::EmptyLinesAroundClassBody, :config do
let(:extra_begin) { 'Extra empty line detected at class body beginning.' }
let(:extra_end) { 'Extra empty line detected at class body end.' }
let(:missing_begin) { 'Empty line missing at class body beginning.' }
let(:missing_end) { 'Empty line missing at class body end.' }
let(:missing_def) { 'Empty line missing before first def definition' }
let(:missing_type) { 'Empty line missing before first class definition' }
context 'when EnforcedStyle is no_empty_lines' do
let(:cop_config) { { 'EnforcedStyle' => 'no_empty_lines' } }
it 'registers an offense for class body starting with a blank' do
inspect_source(<<~RUBY)
class SomeClass
do_something
end
RUBY
expect(cop.messages)
.to eq([extra_begin])
end
it 'autocorrects class body containing only a blank' do
corrected = autocorrect_source(<<~RUBY)
class SomeClass
end
RUBY
expect(corrected).to eq <<~RUBY
class SomeClass
end
RUBY
end
it 'registers an offense for class body ending with a blank' do
inspect_source(<<~RUBY)
class SomeClass
do_something
end
RUBY
expect(cop.messages)
.to eq([extra_end])
end
it 'registers an offense for singleton class body starting with a blank' do
inspect_source(<<~RUBY)
class << self
do_something
end
RUBY
expect(cop.messages)
.to eq([extra_begin])
end
it 'autocorrects singleton class body containing only a blank' do
corrected = autocorrect_source(<<~RUBY)
class << self
end
RUBY
expect(corrected).to eq <<~RUBY
class << self
end
RUBY
end
it 'registers an offense for singleton class body ending with a blank' do
inspect_source(<<~RUBY)
class << self
do_something
end
RUBY
expect(cop.messages)
.to eq([extra_end])
end
end
context 'when EnforcedStyle is empty_lines' do
let(:cop_config) { { 'EnforcedStyle' => 'empty_lines' } }
it 'does not register offenses' do
expect_no_offenses(<<~RUBY)
class Foo
def do_something
end
end
RUBY
end
it 'does not register offenses when specifying a superclass ' \
'that breaks the line' do
expect_no_offenses(<<~RUBY)
class Foo <
Bar
def do_something
end
end
RUBY
end
it 'registers an offense for class body not starting or ending with a ' \
'blank' do
inspect_source(<<~RUBY)
class SomeClass
do_something
end
RUBY
expect(cop.messages).to eq([missing_begin, missing_end])
end
it 'ignores classes with an empty body' do
source = "class SomeClass\nend"
corrected = autocorrect_source(source)
expect(corrected).to eq(source)
end
it 'autocorrects beginning and end' do
new_source = autocorrect_source(<<~RUBY)
class SomeClass
do_something
end
RUBY
expect(new_source).to eq(<<~RUBY)
class SomeClass
do_something
end
RUBY
end
it 'registers an offense for singleton class body not starting or ending ' \
'with a blank' do
inspect_source(<<~RUBY)
class << self
do_something
end
RUBY
expect(cop.messages).to eq([missing_begin, missing_end])
end
it 'ignores singleton classes with an empty body' do
source = "class << self\nend"
corrected = autocorrect_source(source)
expect(corrected).to eq(source)
end
it 'autocorrects beginning and end for `class << self`' do
new_source = autocorrect_source(<<~RUBY)
class << self
do_something
end
RUBY
expect(new_source).to eq(<<~RUBY)
class << self
do_something
end
RUBY
end
end
context 'when EnforcedStyle is empty_lines_except_namespace' do
let(:cop_config) { { 'EnforcedStyle' => 'empty_lines_except_namespace' } }
context 'when only child is class' do
it 'requires no empty lines for namespace' do
expect_no_offenses(<<~RUBY)
class Parent < Base
class Child
do_something
end
end
RUBY
end
it 'registers offense for namespace body starting with a blank' do
inspect_source(<<~RUBY)
class Parent
class Child
do_something
end
end
RUBY
expect(cop.messages).to eq([extra_begin])
end
it 'registers offense for namespace body ending with a blank' do
inspect_source(<<~RUBY)
class Parent
class Child
do_something
end
end
RUBY
expect(cop.messages).to eq([extra_end])
end
it 'registers offenses for namespaced class body not starting '\
'with a blank' do
inspect_source(<<~RUBY)
class Parent
class Child
do_something
end
end
RUBY
expect(cop.messages).to eq([missing_begin])
end
it 'registers offenses for namespaced class body not ending '\
'with a blank' do
inspect_source(<<~RUBY)
class Parent
class Child
do_something
end
end
RUBY
expect(cop.messages).to eq([missing_end])
end
it 'autocorrects beginning and end' do
new_source = autocorrect_source(<<~RUBY)
class Parent < Base
class Child
do_something
end
end
RUBY
expect(new_source).to eq(<<~RUBY)
class Parent < Base
class Child
do_something
end
end
RUBY
end
end
context 'when only child is module' do
it 'requires no empty lines for namespace' do
expect_no_offenses(<<~RUBY)
class Parent
module Child
do_something
end
end
RUBY
end
it 'registers offense for namespace body starting with a blank' do
inspect_source(<<~RUBY)
class Parent
module Child
do_something
end
end
RUBY
expect(cop.messages).to eq([extra_begin])
end
it 'registers offense for namespace body ending with a blank' do
inspect_source(<<~RUBY)
class Parent
module Child
do_something
end
end
RUBY
expect(cop.messages).to eq([extra_end])
end
end
context 'when has multiple child classes' do
it 'requires empty lines for namespace' do
expect_no_offenses(<<~RUBY)
class Parent
class Mom
do_something
end
class Dad
end
end
RUBY
end
it 'registers offenses for namespace body starting '\
'and ending without a blank' do
inspect_source(<<~RUBY)
class Parent
class Mom
do_something
end
class Dad
end
end
RUBY
expect(cop.messages).to eq([missing_begin, missing_end])
end
end
end
context 'when EnforcedStyle is beginning_only' do
let(:cop_config) { { 'EnforcedStyle' => 'beginning_only' } }
it 'ignores empty lines at the beginning of a class' do
expect_no_offenses(<<~RUBY)
class SomeClass
do_something
end
RUBY
end
it 'registers an offense for an empty line at the end of a class' do
inspect_source(<<~RUBY)
class SomeClass
do_something
end
RUBY
expect(cop.messages).to eq([extra_end])
end
it 'autocorrects end' do
new_source = autocorrect_source(<<~RUBY)
class SomeClass
do_something
end
RUBY
expect(new_source).to eq(<<~RUBY)
class SomeClass
do_something
end
RUBY
end
end
context 'when EnforcedStyle is ending_only' do
let(:cop_config) { { 'EnforcedStyle' => 'ending_only' } }
it 'ignores empty lines at the beginning of a class' do
expect_no_offenses(<<~RUBY)
class SomeClass
do_something
end
RUBY
end
it 'registers an offense for an empty line at the end of a class' do
inspect_source(<<~RUBY)
class SomeClass
do_something
end
RUBY
expect(cop.messages).to eq([extra_begin])
end
it 'autocorrects end' do
new_source = autocorrect_source(<<~RUBY)
class SomeClass
do_something
end
RUBY
expect(new_source).to eq(<<~RUBY)
class SomeClass
do_something
end
RUBY
end
end
include_examples 'empty_lines_around_class_or_module_body', 'class'
end