-
-
Notifications
You must be signed in to change notification settings - Fork 3k
/
space_inside_reference_brackets_spec.rb
479 lines (402 loc) · 12.6 KB
/
space_inside_reference_brackets_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Layout::SpaceInsideReferenceBrackets, :config do
context 'with space inside empty brackets not allowed' do
let(:cop_config) { { 'EnforcedStyleForEmptyBrackets' => 'no_space' } }
it 'accepts empty brackets with no space inside' do
expect_no_offenses('a[]')
end
it 'registers an offense and corrects empty brackets with 1 space inside' do
expect_offense(<<~RUBY)
foo[ ]
^^^ Do not use space inside empty reference brackets.
RUBY
expect_correction(<<~RUBY)
foo[]
RUBY
end
it 'registers an offense and corrects empty brackets ' \
'with multiple spaces inside' do
expect_offense(<<~RUBY)
a[ ]
^^^^^^^ Do not use space inside empty reference brackets.
RUBY
expect_correction(<<~RUBY)
a[]
RUBY
end
end
context 'with space inside empty braces allowed' do
let(:cop_config) { { 'EnforcedStyleForEmptyBrackets' => 'space' } }
it 'accepts empty brackets with space inside' do
expect_no_offenses('a[ ]')
end
it 'registers offense and corrects empty brackets with no space inside' do
expect_offense(<<~RUBY)
foo[]
^^ Use one space inside empty reference brackets.
RUBY
expect_correction(<<~RUBY)
foo[ ]
RUBY
end
it 'registers offense and corrects empty brackets ' \
'with more than one space inside' do
expect_offense(<<~RUBY)
a[ ]
^^^^^^^^ Use one space inside empty reference brackets.
RUBY
expect_correction(<<~RUBY)
a[ ]
RUBY
end
end
context 'when EnforcedStyle is no_space' do
let(:cop_config) { { 'EnforcedStyle' => 'no_space' } }
it 'does not register offense for array literals' do
expect_no_offenses(<<~RUBY)
a = [1, 2 ]
b = [ 3, 4]
c = [5, 6]
d = [ 7, 8 ]
RUBY
end
it 'does not register offense for reference brackets with no spaces' do
expect_no_offenses(<<~RUBY)
a[1]
b[index, 2]
c["foo"]
d[:bar]
e[]
RUBY
end
it 'does not register offense for ref bcts with no spaces that assign' do
expect_no_offenses(<<~RUBY)
a[1] = 2
b[345] = [ 678, var, "", nil]
c["foo"] = "qux"
d[:bar] = var
e[] = foo
RUBY
end
it 'registers an offense and corrects when a reference bracket with a ' \
'leading whitespace is assigned by another reference bracket' do
expect_offense(<<~RUBY)
a[ "foo"] = b["something"]
^ Do not use space inside reference brackets.
RUBY
expect_correction(<<~RUBY)
a["foo"] = b["something"]
RUBY
end
it 'registers an offense and correcs when a reference bracket with a ' \
'trailing whitespace is assigned by another reference bracket' do
expect_offense(<<~RUBY)
a["foo" ] = b["something"]
^ Do not use space inside reference brackets.
RUBY
expect_correction(<<~RUBY)
a["foo"] = b["something"]
RUBY
end
it 'registers an offense and corrects when a reference bracket is ' \
'assigned by another reference bracket with trailing whitespace' do
expect_offense(<<~RUBY)
a["foo"] = b["something" ]
^ Do not use space inside reference brackets.
RUBY
expect_correction(<<~RUBY)
a["foo"] = b["something"]
RUBY
end
it 'accepts square brackets as method name' do
expect_no_offenses(<<~RUBY)
def Vector.[](*array)
end
RUBY
end
it 'accepts square brackets called with method call syntax' do
expect_no_offenses('subject.[](0)')
end
it 'accepts an array as a reference object' do
expect_no_offenses('a[[ 1, 2 ]]')
end
it 'registers an offense and corrects ref brackets ' \
'with leading whitespace' do
expect_offense(<<~RUBY)
a[ :key]
^^ Do not use space inside reference brackets.
RUBY
expect_correction(<<~RUBY)
a[:key]
RUBY
end
it 'registers an offense and corrects ref brackets ' \
'with trailing whitespace' do
expect_offense(<<~RUBY)
b[:key ]
^ Do not use space inside reference brackets.
RUBY
expect_correction(<<~RUBY)
b[:key]
RUBY
end
it 'registers an offense and corrects second ref brackets ' \
'with leading whitespace' do
expect_offense(<<~RUBY)
a[:key][ "key"]
^ Do not use space inside reference brackets.
RUBY
expect_correction(<<~RUBY)
a[:key]["key"]
RUBY
end
it 'registers an offense and corrects second ref brackets ' \
'with trailing whitespace' do
expect_offense(<<~RUBY)
a[1][:key ]
^^^ Do not use space inside reference brackets.
RUBY
expect_correction(<<~RUBY)
a[1][:key]
RUBY
end
it 'registers an offense and corrects third ref brackets ' \
'with leading whitespace' do
expect_offense(<<~RUBY)
a[:key][3][ :key]
^ Do not use space inside reference brackets.
RUBY
expect_correction(<<~RUBY)
a[:key][3][:key]
RUBY
end
it 'registers an offense and corrects third ref brackets ' \
'with trailing whitespace' do
expect_offense(<<~RUBY)
a[var]["key", 3][:key ]
^ Do not use space inside reference brackets.
RUBY
expect_correction(<<~RUBY)
a[var]["key", 3][:key]
RUBY
end
it 'registers multiple offenses and corrects one set of ref brackets' do
expect_offense(<<~RUBY)
b[ 89 ]
^ Do not use space inside reference brackets.
^^ Do not use space inside reference brackets.
RUBY
expect_correction(<<~RUBY)
b[89]
RUBY
end
it 'registers multiple offenses and corrects ' \
'multiple sets of ref brackets' do
expect_offense(<<~RUBY)
a[ :key]["foo" ][ 0 ]
^ Do not use space inside reference brackets.
^^ Do not use space inside reference brackets.
^^^ Do not use space inside reference brackets.
^ Do not use space inside reference brackets.
RUBY
expect_correction(<<~RUBY)
a[:key]["foo"][0]
RUBY
end
it 'registers an offense and corrects outer ref brackets' do
expect_offense(<<~RUBY)
record[ options[:attribute] ]
^ Do not use space inside reference brackets.
^ Do not use space inside reference brackets.
RUBY
expect_correction(<<~RUBY)
record[options[:attribute]]
RUBY
end
it 'register and correct multiple offenses for multiple sets ' \
'of ref brackets' do
expect_offense(<<~RUBY)
b[ :key]["foo" ][ 0 ]
^ Do not use space inside reference brackets.
^^ Do not use space inside reference brackets.
^^^ Do not use space inside reference brackets.
^ Do not use space inside reference brackets.
RUBY
expect_correction(<<~RUBY)
b[:key]["foo"][0]
RUBY
end
it 'accpets extra spacing in array brackets' do
expect_offense(<<~RUBY)
j[ "pop"] = [89, nil, "" ]
^ Do not use space inside reference brackets.
RUBY
expect_correction(<<~RUBY)
j["pop"] = [89, nil, "" ]
RUBY
end
end
context 'when EnforcedStyle is space' do
let(:cop_config) do
{ 'EnforcedStyle' => 'space',
'EnforcedStyleForEmptyBrackets' => 'space' }
end
it 'does not register offense for array literals' do
expect_no_offenses(<<~RUBY)
a = [1, 2 ]
b = [ 3, 4]
c = [5, 6]
d = [ 7, 8 ]
RUBY
end
it 'does not register offense for reference brackets with spaces' do
expect_no_offenses(<<~RUBY)
a[ 1 ]
b[ index, 3 ]
c[ "foo" ]
d[ :bar ]
e[ ]
RUBY
end
it 'does not register offense for ref bcts with spaces that assign' do
expect_no_offenses(<<~RUBY)
a[ 1 ] = 2
b[ 345 ] = [ 678, var, "", nil]
c[ "foo" ] = "qux"
d[ :bar ] = var
e[ ] = baz
RUBY
end
it 'registers an offense and corrects when a reference bracket with no ' \
'leading whitespace is assigned by another reference bracket' do
expect_offense(<<~RUBY)
a["foo" ] = b[ "something" ]
^ Use space inside reference brackets.
RUBY
expect_correction(<<~RUBY)
a[ "foo" ] = b[ "something" ]
RUBY
end
it 'registers an offense and corrects when a reference bracket with no ' \
'trailing whitespace is assigned by another reference bracket' do
expect_offense(<<~RUBY)
a[ "foo"] = b[ "something" ]
^ Use space inside reference brackets.
RUBY
expect_correction(<<~RUBY)
a[ "foo" ] = b[ "something" ]
RUBY
end
it 'registers an offense and corrects when a reference bracket is ' \
'assigned by another reference bracket with no trailing whitespace' do
expect_offense(<<~RUBY)
a[ "foo" ] = b[ "something"]
^ Use space inside reference brackets.
RUBY
expect_correction(<<~RUBY)
a[ "foo" ] = b[ "something" ]
RUBY
end
it 'accepts square brackets as method name' do
expect_no_offenses(<<~RUBY)
def Vector.[](*array)
end
RUBY
end
it 'accepts square brackets called with method call syntax' do
expect_no_offenses('subject.[](0)')
end
it 'accepts an array as a reference object' do
expect_no_offenses('a[ [1, 2] ]')
end
it 'registers an offense and corrects ref brackets ' \
'with no leading whitespace' do
expect_offense(<<~RUBY)
a[:key ]
^ Use space inside reference brackets.
RUBY
expect_correction(<<~RUBY)
a[ :key ]
RUBY
end
it 'registers an offense and corrects ref brackets ' \
'with no trailing whitespace' do
expect_offense(<<~RUBY)
b[ :key]
^ Use space inside reference brackets.
RUBY
expect_correction(<<~RUBY)
b[ :key ]
RUBY
end
it 'registers an offense and corrects second ref brackets ' \
'with no leading whitespace' do
expect_offense(<<~RUBY)
a[ :key ]["key" ]
^ Use space inside reference brackets.
RUBY
expect_correction(<<~RUBY)
a[ :key ][ "key" ]
RUBY
end
it 'registers an offense and corrects second ref brackets ' \
'with no trailing whitespace' do
expect_offense(<<~RUBY)
a[ 5, 1 ][ :key]
^ Use space inside reference brackets.
RUBY
expect_correction(<<~RUBY)
a[ 5, 1 ][ :key ]
RUBY
end
it 'registers an offense and corrects third ref brackets ' \
'with no leading whitespace' do
expect_offense(<<~RUBY)
a[ :key ][ 3 ][:key ]
^ Use space inside reference brackets.
RUBY
expect_correction(<<~RUBY)
a[ :key ][ 3 ][ :key ]
RUBY
end
it 'registers an offense and correct third ref brackets ' \
'with no trailing whitespace' do
expect_offense(<<~RUBY)
a[ var ][ "key" ][ :key]
^ Use space inside reference brackets.
RUBY
expect_correction(<<~RUBY)
a[ var ][ "key" ][ :key ]
RUBY
end
it 'registers and corrects multiple offenses in one set of ref brackets' do
expect_offense(<<~RUBY)
b[89]
^ Use space inside reference brackets.
^ Use space inside reference brackets.
RUBY
expect_correction(<<~RUBY)
b[ 89 ]
RUBY
end
it 'registers and corrects multiple offenses for multiple sets ' \
'of ref brackets' do
expect_offense(<<~RUBY)
a[:key]["foo" ][0]
^ Use space inside reference brackets.
^ Use space inside reference brackets.
^ Use space inside reference brackets.
^ Use space inside reference brackets.
^ Use space inside reference brackets.
RUBY
expect_correction(<<~RUBY)
a[ :key ][ "foo" ][ 0 ]
RUBY
end
it 'accepts spaces in array brackets' do
expect_no_offenses(<<~RUBY)
j = [89, nil, "" ]
RUBY
end
end
end