-
-
Notifications
You must be signed in to change notification settings - Fork 3k
/
class_structure_spec.rb
226 lines (181 loc) · 4.81 KB
/
class_structure_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Layout::ClassStructure, :config do
let(:config) do
RuboCop::Config.new(
'Layout/ClassStructure' => {
'ExpectedOrder' => %w[
module_inclusion
constants
attribute_macros
delegate
macros
public_class_methods
initializer
public_methods
protected_attribute_macros
protected_methods
private_attribute_macros
private_delegate
private_methods
],
'Categories' => {
'attribute_macros' => %w[
attr_accessor
attr_reader
attr_writer
],
'macros' => %w[
validates
validate
],
'module_inclusion' => %w[
prepend
extend
include
]
}
}
)
end
context 'with a complete ordered example' do
it 'does not create offense' do
expect_no_offenses <<-RUBY
class Person
# extend and include go first
extend SomeModule
include AnotherModule
# inner classes
CustomError = Class.new(StandardError)
# constants are next
SOME_CONSTANT = 20
# afterwards we have attribute macros
attr_reader :name
# then we have public delegate macros
delegate :to_s, to: :name
# followed by other macros (if any)
validates :name
# public class methods are next in line
def self.some_method
end
# initialization goes between class methods and other instance methods
def initialize
end
# followed by other public instance methods
def some_method
end
# protected attribute macros and methods go next
protected
attr_reader :protected_name
def some_protected_method
end
# private attribute macros, delegate macros and methods are grouped near the end
private
attr_reader :private_name
delegate :some_private_delegate, to: :name
def some_private_method
end
end
RUBY
end
end
context 'simple example' do
specify do
expect_offense <<~RUBY
class Person
CONST = 'wrong place'
include AnotherModule
^^^^^^^^^^^^^^^^^^^^^ `module_inclusion` is supposed to appear before `constants`.
extend SomeModule
end
RUBY
end
specify do
expect(autocorrect_source_with_loop(<<~RUBY))
class Example
CONST = 1
include AnotherModule
extend SomeModule
end
RUBY
.to eq(<<~RUBY)
class Example
include AnotherModule
extend SomeModule
CONST = 1
end
RUBY
end
end
context 'with protected methods declared before private' do
let(:code) { <<-RUBY }
class MyClass
def public_method
end
private
def first_private_method
end
def second_private_method
end
protected
def first_protected_method
^^^^^^^^^^^^^^^^^^^^^^^^^^ `protected_methods` is supposed to appear before `private_methods`.
end
def second_protected_method
end
end
RUBY
it { expect_offense(code) }
end
context 'with attribute macros before after validations' do
let(:code) { <<-RUBY }
class Person
include AnotherModule
extend SomeModule
CustomError = Class.new(StandardError)
validates :name
attr_reader :name
^^^^^^^^^^^^^^^^^ `attribute_macros` is supposed to appear before `macros`.
def self.some_public_class_method
end
def initialize
end
def some_public_method
end
def other_public_method
end
private :other_public_method
private def something_inline
end
def yet_other_public_method
end
protected
def some_protected_method
end
private
def some_private_method
end
end
RUBY
it { expect_offense(code) }
end
describe '#autocorrect' do
context 'when there is a comment in the macro method' do
it 'autocorrects the offenses' do
new_source = autocorrect_source(<<~RUBY)
class Foo
# This is a comment for macro method.
validates :attr
attr_reader :foo
end
RUBY
expect(new_source).to eq(<<~RUBY)
class Foo
attr_reader :foo
# This is a comment for macro method.
validates :attr
end
RUBY
end
end
end
end