-
-
Notifications
You must be signed in to change notification settings - Fork 3k
/
negated_while_spec.rb
119 lines (104 loc) · 3.08 KB
/
negated_while_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Style::NegatedWhile do
subject(:cop) { described_class.new }
it 'registers an offense for while with exclamation point condition' do
expect_offense(<<~RUBY)
while !a_condition
^^^^^^^^^^^^^^^^^^ Favor `until` over `while` for negative conditions.
some_method
end
some_method while !a_condition
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Favor `until` over `while` for negative conditions.
RUBY
expect_correction(<<~RUBY)
until a_condition
some_method
end
some_method until a_condition
RUBY
end
it 'registers an offense for until with exclamation point condition' do
expect_offense(<<~RUBY)
until !a_condition
^^^^^^^^^^^^^^^^^^ Favor `while` over `until` for negative conditions.
some_method
end
some_method until !a_condition
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Favor `while` over `until` for negative conditions.
RUBY
expect_correction(<<~RUBY)
while a_condition
some_method
end
some_method while a_condition
RUBY
end
it 'registers an offense for while with "not" condition' do
expect_offense(<<~RUBY)
while (not a_condition)
^^^^^^^^^^^^^^^^^^^^^^^ Favor `until` over `while` for negative conditions.
some_method
end
some_method while not a_condition
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Favor `until` over `while` for negative conditions.
RUBY
expect_correction(<<~RUBY)
until (a_condition)
some_method
end
some_method until a_condition
RUBY
end
it 'accepts a while where only part of the condition is negated' do
expect_no_offenses(<<~RUBY)
while !a_condition && another_condition
some_method
end
while not a_condition or another_condition
some_method
end
some_method while not a_condition or other_cond
RUBY
end
it 'accepts a while where the condition is doubly negated' do
expect_no_offenses(<<~RUBY)
while !!a_condition
some_method
end
some_method while !!a_condition
RUBY
end
it 'autocorrects by replacing while not with until' do
expect_offense(<<~RUBY)
something while !x.even?
^^^^^^^^^^^^^^^^^^^^^^^^ Favor `until` over `while` for negative conditions.
something while(!x.even?)
^^^^^^^^^^^^^^^^^^^^^^^^^ Favor `until` over `while` for negative conditions.
RUBY
expect_correction(<<~RUBY)
something until x.even?
something until(x.even?)
RUBY
end
it 'autocorrects by replacing until not with while' do
expect_offense(<<~RUBY)
something until !x.even?
^^^^^^^^^^^^^^^^^^^^^^^^ Favor `while` over `until` for negative conditions.
RUBY
expect_correction(<<~RUBY)
something while x.even?
RUBY
end
it 'does not blow up for empty while condition' do
expect_no_offenses(<<~RUBY)
while ()
end
RUBY
end
it 'does not blow up for empty until condition' do
expect_no_offenses(<<~RUBY)
until ()
end
RUBY
end
end