/
multiline_method_signature_spec.rb
214 lines (187 loc) · 5.44 KB
/
multiline_method_signature_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Style::MultilineMethodSignature, :config do
context 'when arguments span a single line' do
context 'when defining an instance method' do
it 'registers an offense and corrects when closing paren is on the following line' do
expect_offense(<<~RUBY)
def foo(bar
^^^^^^^^^^^ Avoid multi-line method signatures.
)
end
RUBY
expect_correction(<<~RUBY)
def foo(bar)
end
RUBY
end
it 'registers an offense and corrects when line break after opening parenthesis' do
expect_offense(<<~RUBY)
class Foo
def foo(
^^^^^^^^ Avoid multi-line method signatures.
arg
)
end
end
RUBY
expect_correction(<<~RUBY)
class Foo
def foo(arg)
end
end
RUBY
end
context 'when method signature is on a single line' do
it 'does not register an offense for parameterized method' do
expect_no_offenses(<<~RUBY)
def foo(bar, baz)
end
RUBY
end
it 'does not register an offense for unparameterized method' do
expect_no_offenses(<<~RUBY)
def foo
end
RUBY
end
end
end
context 'when defining an class method' do
context 'when arguments span a single line' do
it 'registers an offense and corrects when closing paren is on the following line' do
expect_offense(<<~RUBY)
def self.foo(bar
^^^^^^^^^^^^^^^^ Avoid multi-line method signatures.
)
end
RUBY
expect_correction(<<~RUBY)
def self.foo(bar)
end
RUBY
end
end
context 'when method signature is on a single line' do
it 'does not register an offense for parameterized method' do
expect_no_offenses(<<~RUBY)
def self.foo(bar, baz)
end
RUBY
end
it 'does not register an offense for unparameterized method' do
expect_no_offenses(<<~RUBY)
def self.foo
end
RUBY
end
end
end
end
context 'when arguments span multiple lines' do
context 'when defining an instance method' do
it 'registers an offense and corrects when `end` is on the following line' do
expect_offense(<<~RUBY)
def foo(bar,
^^^^^^^^^^^^ Avoid multi-line method signatures.
baz)
end
RUBY
expect_correction(<<~RUBY)
def foo(bar, baz)
end
RUBY
end
it 'registers an offense and corrects when `end` is on the same line with last arguemnt' do
expect_offense(<<~RUBY)
def foo(bar,
^^^^^^^^^^^^ Avoid multi-line method signatures.
baz); end
RUBY
expect_correction(<<~RUBY)
def foo(bar, baz); end
RUBY
end
it 'registers an offense and corrects when `end` is on the same line with only closing parentheses' do
expect_offense(<<~RUBY)
def foo(bar,
^^^^^^^^^^^^ Avoid multi-line method signatures.
baz
); end
RUBY
expect_correction(<<~RUBY)
def foo(bar, baz); end
RUBY
end
end
context 'when defining an class method' do
it 'registers an offense and corrects when `end` is on the following line' do
expect_offense(<<~RUBY)
def self.foo(bar,
^^^^^^^^^^^^^^^^^ Avoid multi-line method signatures.
baz)
end
RUBY
expect_correction(<<~RUBY)
def self.foo(bar, baz)
end
RUBY
end
it 'registers an offense and corrects when `end` is on the same line' do
expect_offense(<<~RUBY)
def self.foo(bar,
^^^^^^^^^^^^^^^^^ Avoid multi-line method signatures.
baz); end
RUBY
expect_correction(<<~RUBY)
def self.foo(bar, baz); end
RUBY
end
it 'registers an offense and corrects when `end` is on the same line with only closing parentheses' do
expect_offense(<<~RUBY)
def self.foo(bar,
^^^^^^^^^^^^^^^^^ Avoid multi-line method signatures.
baz
); end
RUBY
expect_correction(<<~RUBY)
def self.foo(bar, baz); end
RUBY
end
end
context 'when correction would exceed maximum line length' do
let(:other_cops) do
{
'Layout/LineLength' => { 'Max' => 5 }
}
end
it 'does not register an offense' do
expect_no_offenses(<<~RUBY)
def foo(bar,
baz)
end
RUBY
end
end
context 'when correction would not exceed maximum line length' do
let(:other_cops) do
{
'Layout/LineLength' => { 'Max' => 25 }
}
end
it 'registers an offense and corrects' do
expect_offense(<<~RUBY)
def foo(bar,
^^^^^^^^^^^^ Avoid multi-line method signatures.
baz)
qux.qux
end
RUBY
expect_correction(<<~RUBY)
def foo(bar, baz)
qux.qux
end
RUBY
end
end
end
end