/
endless_method_spec.rb
142 lines (122 loc) · 3.92 KB
/
endless_method_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Style::EndlessMethod, :config do
context 'Ruby >= 3.0', :ruby30 do
context 'EnforcedStyle: disallow' do
let(:cop_config) { { 'EnforcedStyle' => 'disallow' } }
it 'registers an offense for an endless method' do
expect_offense(<<~RUBY)
def my_method() = x
^^^^^^^^^^^^^^^^^^^ Avoid endless method definitions.
RUBY
expect_correction(<<~RUBY)
def my_method
x
end
RUBY
end
it 'registers an offense for an endless method with arguments' do
expect_offense(<<~RUBY)
def my_method(a, b) = x
^^^^^^^^^^^^^^^^^^^^^^^ Avoid endless method definitions.
RUBY
expect_correction(<<~RUBY)
def my_method(a, b)
x
end
RUBY
end
end
context 'EnforcedStyle: allow_single_line' do
let(:cop_config) { { 'EnforcedStyle' => 'allow_single_line' } }
it 'does not register an offense for an endless method' do
expect_no_offenses(<<~RUBY)
def my_method() = x
RUBY
end
it 'does not register an offense for an endless method with arguments' do
expect_no_offenses(<<~RUBY)
def my_method(a, b) = x
RUBY
end
it 'registers an offense and corrects for a multiline endless method' do
expect_offense(<<~RUBY)
def my_method() = x.foo
^^^^^^^^^^^^^^^^^^^^^^^ Avoid endless method definitions with multiple lines.
.bar
.baz
RUBY
expect_correction(<<~RUBY)
def my_method
x.foo
.bar
.baz
end
RUBY
end
it 'registers an offense and corrects for a multiline endless method with begin' do
expect_offense(<<~RUBY)
def my_method() = begin
^^^^^^^^^^^^^^^^^^^^^^^ Avoid endless method definitions with multiple lines.
foo && bar
end
RUBY
expect_correction(<<~RUBY)
def my_method
begin
foo && bar
end
end
RUBY
end
it 'registers an offense and corrects for a multiline endless method with arguments' do
expect_offense(<<~RUBY)
def my_method(a, b) = x.foo
^^^^^^^^^^^^^^^^^^^^^^^^^^^ Avoid endless method definitions with multiple lines.
.bar
.baz
RUBY
expect_correction(<<~RUBY)
def my_method(a, b)
x.foo
.bar
.baz
end
RUBY
end
end
context 'EnforcedStyle: allow_always' do
let(:cop_config) { { 'EnforcedStyle' => 'allow_always' } }
it 'does not register an offense for an endless method' do
expect_no_offenses(<<~RUBY)
def my_method() = x
RUBY
end
it 'does not register an offense for an endless method with arguments' do
expect_no_offenses(<<~RUBY)
def my_method(a, b) = x
RUBY
end
it 'registers an offense and corrects for a multiline endless method' do
expect_no_offenses(<<~RUBY)
def my_method() = x.foo
.bar
.baz
RUBY
end
it 'registers an offense and corrects for a multiline endless method with begin' do
expect_no_offenses(<<~RUBY)
def my_method() = begin
foo && bar
end
RUBY
end
it 'registers an offense and corrects for a multiline endless method with arguments' do
expect_no_offenses(<<~RUBY)
def my_method(a, b) = x.foo
.bar
.baz
RUBY
end
end
end
end