/
raise_args_spec.rb
282 lines (242 loc) · 7.78 KB
/
raise_args_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Style::RaiseArgs, :config do
context 'when enforced style is compact' do
let(:cop_config) { { 'EnforcedStyle' => 'compact' } }
context 'with a raise with 2 args' do
it 'reports an offense' do
expect_offense(<<~RUBY)
raise RuntimeError, msg
^^^^^^^^^^^^^^^^^^^^^^^ Provide an exception object as an argument to `raise`.
RUBY
expect_correction(<<~RUBY)
raise RuntimeError.new(msg)
RUBY
end
end
context 'when used in a ternary expression' do
it 'registers an offense and auto-corrects' do
expect_offense(<<~RUBY)
foo ? raise(Ex, 'error') : bar
^^^^^^^^^^^^^^^^^^ Provide an exception object as an argument to `raise`.
RUBY
expect_correction(<<~RUBY)
foo ? raise(Ex.new('error')) : bar
RUBY
end
end
context 'when used in a logical and expression' do
it 'registers an offense and auto-corrects' do
expect_offense(<<~RUBY)
bar && raise(Ex, 'error')
^^^^^^^^^^^^^^^^^^ Provide an exception object as an argument to `raise`.
RUBY
expect_correction(<<~RUBY)
bar && raise(Ex.new('error'))
RUBY
end
end
context 'when used in a logical or expression' do
it 'registers an offense and auto-corrects' do
expect_offense(<<~RUBY)
bar || raise(Ex, 'error')
^^^^^^^^^^^^^^^^^^ Provide an exception object as an argument to `raise`.
RUBY
expect_correction(<<~RUBY)
bar || raise(Ex.new('error'))
RUBY
end
end
context 'with correct + opposite' do
it 'reports an offense' do
expect_offense(<<~RUBY)
if a
raise RuntimeError, msg
^^^^^^^^^^^^^^^^^^^^^^^ Provide an exception object as an argument to `raise`.
else
raise Ex.new(msg)
end
RUBY
expect_correction(<<~RUBY)
if a
raise RuntimeError.new(msg)
else
raise Ex.new(msg)
end
RUBY
end
it 'reports multiple offenses' do
expect_offense(<<~RUBY)
if a
raise RuntimeError, msg
^^^^^^^^^^^^^^^^^^^^^^^ Provide an exception object as an argument to `raise`.
elsif b
raise Ex.new(msg)
else
raise ArgumentError, msg
^^^^^^^^^^^^^^^^^^^^^^^^ Provide an exception object as an argument to `raise`.
end
RUBY
expect_correction(<<~RUBY)
if a
raise RuntimeError.new(msg)
elsif b
raise Ex.new(msg)
else
raise ArgumentError.new(msg)
end
RUBY
end
end
context 'with a raise with 3 args' do
it 'reports an offense' do
expect_offense(<<~RUBY)
raise RuntimeError, msg, caller
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Provide an exception object as an argument to `raise`.
RUBY
expect_no_corrections
end
end
it 'accepts a raise with msg argument' do
expect_no_offenses('raise msg')
end
it 'accepts a raise with an exception argument' do
expect_no_offenses('raise Ex.new(msg)')
end
end
context 'when enforced style is exploded' do
let(:cop_config) { { 'EnforcedStyle' => 'exploded' } }
context 'with a raise with exception object' do
context 'with one argument' do
it 'reports an offense' do
expect_offense(<<~RUBY)
raise Ex.new(msg)
^^^^^^^^^^^^^^^^^ Provide an exception class and message as arguments to `raise`.
RUBY
expect_correction(<<~RUBY)
raise Ex, msg
RUBY
end
end
context 'with no arguments' do
it 'reports an offense' do
expect_offense(<<~RUBY)
raise Ex.new
^^^^^^^^^^^^ Provide an exception class and message as arguments to `raise`.
RUBY
expect_correction(<<~RUBY)
raise Ex
RUBY
end
end
context 'when used in a ternary expression' do
it 'registers an offense and auto-corrects' do
expect_offense(<<~RUBY)
foo ? raise(Ex.new('error')) : bar
^^^^^^^^^^^^^^^^^^^^^^ Provide an exception class and message as arguments to `raise`.
RUBY
expect_correction(<<~RUBY)
foo ? raise(Ex, 'error') : bar
RUBY
end
end
context 'when used in a logical and expression' do
it 'registers an offense and auto-corrects' do
expect_offense(<<~RUBY)
bar && raise(Ex.new('error'))
^^^^^^^^^^^^^^^^^^^^^^ Provide an exception class and message as arguments to `raise`.
RUBY
expect_correction(<<~RUBY)
bar && raise(Ex, 'error')
RUBY
end
end
context 'when used in a logical or expression' do
it 'registers an offense and auto-corrects' do
expect_offense(<<~RUBY)
bar || raise(Ex.new('error'))
^^^^^^^^^^^^^^^^^^^^^^ Provide an exception class and message as arguments to `raise`.
RUBY
expect_correction(<<~RUBY)
bar || raise(Ex, 'error')
RUBY
end
end
end
context 'with opposite + correct' do
it 'reports an offense for opposite + correct' do
expect_offense(<<~RUBY)
if a
raise RuntimeError, msg
else
raise Ex.new(msg)
^^^^^^^^^^^^^^^^^ Provide an exception class and message as arguments to `raise`.
end
RUBY
expect_correction(<<~RUBY)
if a
raise RuntimeError, msg
else
raise Ex, msg
end
RUBY
end
it 'reports multiple offenses' do
expect_offense(<<~RUBY)
if a
raise RuntimeError, msg
elsif b
raise Ex.new(msg)
^^^^^^^^^^^^^^^^^ Provide an exception class and message as arguments to `raise`.
else
raise ArgumentError.new(msg)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Provide an exception class and message as arguments to `raise`.
end
RUBY
expect_correction(<<~RUBY)
if a
raise RuntimeError, msg
elsif b
raise Ex, msg
else
raise ArgumentError, msg
end
RUBY
end
end
context 'when an exception object is assigned to a local variable' do
it 'auto-corrects to exploded style' do
expect_offense(<<~RUBY)
def do_something
klass = RuntimeError
raise klass.new('hi')
^^^^^^^^^^^^^^^^^^^^^ Provide an exception class and message as arguments to `raise`.
end
RUBY
expect_correction(<<~RUBY)
def do_something
klass = RuntimeError
raise klass, 'hi'
end
RUBY
end
end
it 'accepts exception constructor with more than 1 argument' do
expect_no_offenses('raise MyCustomError.new(a1, a2, a3)')
end
it 'accepts exception constructor with keyword arguments' do
expect_no_offenses('raise MyKwArgError.new(a: 1, b: 2)')
end
it 'accepts a raise with splatted arguments' do
expect_no_offenses('raise MyCustomError.new(*args)')
end
it 'accepts a raise with 3 args' do
expect_no_offenses('raise RuntimeError, msg, caller')
end
it 'accepts a raise with 2 args' do
expect_no_offenses('raise RuntimeError, msg')
end
it 'accepts a raise with msg argument' do
expect_no_offenses('raise msg')
end
end
end