-
-
Notifications
You must be signed in to change notification settings - Fork 3k
/
suppressed_exception_spec.rb
59 lines (52 loc) · 1.53 KB
/
suppressed_exception_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Lint::SuppressedException, :config do
subject(:cop) { described_class.new(config) }
context 'with AllowComments set to false' do
let(:cop_config) { { 'AllowComments' => false } }
it 'registers an offense for empty rescue block' do
expect_offense(<<~RUBY)
begin
something
rescue
^^^^^^ Do not suppress exceptions.
#do nothing
end
RUBY
end
it 'does not register an offense for rescue with body' do
expect_no_offenses(<<~RUBY)
begin
something
return
rescue
file.close
end
RUBY
end
end
context 'with AllowComments set to true' do
let(:cop_config) { { 'AllowComments' => true } }
it 'does not register an offense for empty rescue with comment' do
expect_no_offenses(<<~RUBY)
begin
something
return
rescue
# do nothing
end
RUBY
end
it 'registers an offense for empty rescue on single line with a comment after it' do
expect_offense(<<~RUBY)
RSpec.describe Dummy do
it 'dummy spec' do
# This rescue is here to ensure the test does not fail because of the `raise`
expect { begin subject; rescue ActiveRecord::Rollback; end }.not_to(change(Post, :count))
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Do not suppress exceptions.
# Done
end
end
RUBY
end
end
end