/
empty_in_pattern_spec.rb
165 lines (143 loc) · 3.57 KB
/
empty_in_pattern_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Lint::EmptyInPattern, :config do
let(:cop_config) { { 'AllowComments' => false } }
context 'when a `in` body is missing', :ruby27 do
it 'registers an offense for a missing `in` body' do
expect_offense(<<~RUBY)
case foo
in [a] then 1
in [a, b] # nothing
^^^^^^^^^ Avoid `in` branches without a body.
end
RUBY
expect_no_corrections
end
it 'registers an offense for missing `in` body followed by `else`' do
expect_offense(<<~RUBY)
case foo
in [a] then 1
in [a, b] # nothing
^^^^^^^^^ Avoid `in` branches without a body.
else 3
end
RUBY
expect_no_corrections
end
it 'registers an offense for missing `in` ... `then` body' do
expect_offense(<<~RUBY)
case foo
in [a] then 1
in [a, b] then # nothing
^^^^^^^^^ Avoid `in` branches without a body.
end
RUBY
expect_no_corrections
end
it 'registers an offense for missing `in` ... then `body` followed by `else`' do
expect_offense(<<~RUBY)
case foo
in [a] then 1
in [a, b] then # nothing
^^^^^^^^^ Avoid `in` branches without a body.
else 3
end
RUBY
expect_no_corrections
end
it 'registers an offense for missing `in` body with a comment' do
expect_offense(<<~RUBY)
case foo
in [a]
1
in [a, b]
^^^^^^^^^ Avoid `in` branches without a body.
# nothing
end
RUBY
expect_no_corrections
end
it 'registers an offense for missing `in` body with a comment followed by `else`' do
expect_offense(<<~RUBY)
case foo
in [a]
1
in [a, b]
^^^^^^^^^ Avoid `in` branches without a body.
# nothing
else
3
end
RUBY
expect_no_corrections
end
end
context 'when a `in` body is present', :ruby27 do
it 'accepts `case` with `in` ... `then` statements' do
expect_no_offenses(<<~RUBY)
case foo
in [a] then 1
in [a, b] then 2
end
RUBY
end
it 'accepts `case` with `in` ... `then` statements and else clause' do
expect_no_offenses(<<~RUBY)
case foo
in [a] then 1
in [a, b] then 2
else 3
end
RUBY
end
it 'accepts `case` with `in` bodies' do
expect_no_offenses(<<~RUBY)
case foo
in [a]
1
in [a, b]
2
end
RUBY
end
it 'accepts `case` with `in` bodies and `else` clause' do
expect_no_offenses(<<~RUBY)
case foo
in [a]
1
in [a, b]
2
else
3
end
RUBY
end
end
context 'when `AllowComments: true`', :ruby27 do
let(:cop_config) { { 'AllowComments' => true } }
it 'accepts an empty `in` body with a comment' do
expect_no_offenses(<<~RUBY)
case condition
in [a]
do_something
in [a, b]
# do nothing
end
RUBY
end
end
context 'when `AllowComments: false`', :ruby27 do
let(:cop_config) { { 'AllowComments' => false } }
it 'registers an offense for empty `in` body with a comment' do
expect_offense(<<~RUBY)
case condition
in [a]
do_something
in [a, b]
^^^^^^^^^ Avoid `in` branches without a body.
# do nothing
end
RUBY
expect_no_corrections
end
end
end