/
access_modifier_declarations_spec.rb
169 lines (145 loc) · 4.86 KB
/
access_modifier_declarations_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Style::AccessModifierDeclarations, :config do
shared_examples 'always accepted' do |access_modifier|
it 'accepts when #{access_modifier} is a hash literal value' do
expect_no_offenses(<<~RUBY)
class Foo
foo
bar(key: #{access_modifier})
end
RUBY
end
context 'allow access modifiers on symbols' do
let(:cop_config) { { 'AllowModifiersOnSymbols' => true } }
it 'accepts when argument to #{access_modifier} is a symbol' do
expect_no_offenses(<<~RUBY)
class Foo
foo
#{access_modifier} :bar
end
RUBY
end
end
context 'do not allow access modifiers on symbols' do
let(:cop_config) { { 'AllowModifiersOnSymbols' => false } }
it 'accepts when argument to #{access_modifier} is a symbol' do
expect_offense(<<~RUBY, access_modifier: access_modifier)
class Foo
foo
%{access_modifier} :bar
^{access_modifier} `#{access_modifier}` should not be inlined in method definitions.
end
RUBY
end
end
end
context 'when `group` is configured' do
let(:cop_config) do
{
'EnforcedStyle' => 'group'
}
end
%w[private protected public module_function].each do |access_modifier|
it "offends when #{access_modifier} is inlined with a method" do
expect_offense(<<~RUBY, access_modifier: access_modifier)
class Test
%{access_modifier} def foo; end
^{access_modifier} `#{access_modifier}` should not be inlined in method definitions.
end
RUBY
end
it "does not offend when #{access_modifier} is not inlined" do
expect_no_offenses(<<~RUBY)
class Test
#{access_modifier}
end
RUBY
end
it 'accepts when using only #{access_modifier}' do
expect_no_offenses(<<~RUBY)
#{access_modifier}
RUBY
end
it "does not offend when #{access_modifier} is not inlined and " \
'has a comment' do
expect_no_offenses(<<~RUBY)
class Test
#{access_modifier} # hey
end
RUBY
end
it 'registers an offense for correct + multiple opposite styles of #{access_modifier} usage' do
expect_offense(<<~RUBY, access_modifier: access_modifier)
class TestOne
#{access_modifier}
end
class TestTwo
#{access_modifier} def foo; end
^{access_modifier} `#{access_modifier}` should not be inlined in method definitions.
end
class TestThree
#{access_modifier} def foo; end
^{access_modifier} `#{access_modifier}` should not be inlined in method definitions.
end
RUBY
end
include_examples 'always accepted', access_modifier
end
end
context 'when `inline` is configured' do
let(:cop_config) do
{
'EnforcedStyle' => 'inline'
}
end
%w[private protected public module_function].each do |access_modifier|
it "offends when #{access_modifier} is not inlined" do
expect_offense(<<~RUBY, access_modifier: access_modifier)
class Test
%{access_modifier}
^{access_modifier} `#{access_modifier}` should be inlined in method definitions.
end
RUBY
end
it "offends when #{access_modifier} is not inlined and has a comment" do
expect_offense(<<~RUBY, access_modifier: access_modifier)
class Test
%{access_modifier} # hey
^{access_modifier} `#{access_modifier}` should be inlined in method definitions.
end
RUBY
end
it "does not offend when #{access_modifier} is inlined with a method" do
expect_no_offenses(<<~RUBY)
class Test
#{access_modifier} def foo; end
end
RUBY
end
it "does not offend when #{access_modifier} is inlined with a symbol" do
expect_no_offenses(<<~RUBY)
class Test
#{access_modifier} :foo
def foo; end
end
RUBY
end
it 'registers an offense for correct + multiple opposite styles of #{access_modifier} usage' do
expect_offense(<<~RUBY, access_modifier: access_modifier)
class TestOne
#{access_modifier} def foo; end
end
class TestTwo
#{access_modifier}
^{access_modifier} `#{access_modifier}` should be inlined in method definitions.
end
class TestThree
#{access_modifier}
^{access_modifier} `#{access_modifier}` should be inlined in method definitions.
end
RUBY
end
include_examples 'always accepted', access_modifier
end
end
end