/
module_function_spec.rb
150 lines (129 loc) · 3.51 KB
/
module_function_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Style::ModuleFunction, :config do
subject(:cop) { described_class.new(config) }
context 'when enforced style is `module_function`' do
let(:cop_config) { { 'EnforcedStyle' => 'module_function' } }
it 'registers an offense for `extend self` in a module' do
expect_offense(<<~RUBY)
module Test
extend self
^^^^^^^^^^^ Use `module_function` instead of `extend self`.
def test; end
end
RUBY
expect_correction(<<~RUBY)
module Test
module_function
def test; end
end
RUBY
end
it 'accepts for `extend self` in a module with private methods' do
expect_no_offenses(<<~RUBY)
module Test
extend self
def test; end
private
def test_private;end
end
RUBY
end
it 'accepts for `extend self` in a module with declarative private' do
expect_no_offenses(<<~RUBY)
module Test
extend self
def test; end
private :test
end
RUBY
end
it 'accepts `extend self` in a class' do
expect_no_offenses(<<~RUBY)
class Test
extend self
end
RUBY
end
end
context 'when enforced style is `extend_self`' do
let(:cop_config) { { 'EnforcedStyle' => 'extend_self' } }
it 'registers an offense for `module_function` without an argument' do
expect_offense(<<~RUBY)
module Test
module_function
^^^^^^^^^^^^^^^ Use `extend self` instead of `module_function`.
def test; end
end
RUBY
expect_correction(<<~RUBY)
module Test
extend self
def test; end
end
RUBY
end
it 'accepts module_function with an argument' do
expect_no_offenses(<<~RUBY)
module Test
def test; end
module_function :test
end
RUBY
end
end
context 'when enforced style is `forbidden`' do
let(:cop_config) { { 'EnforcedStyle' => 'forbidden' } }
context 'registers an offense for `extend self`' do
it 'in a module' do
expect_offense(<<~RUBY)
module Test
extend self
^^^^^^^^^^^ Do not use `module_function` or `extend self`.
def test; end
end
RUBY
expect_no_corrections
end
it 'in a module with private methods' do
expect_offense(<<~RUBY)
module Test
extend self
^^^^^^^^^^^ Do not use `module_function` or `extend self`.
def test; end
private
def test_private;end
end
RUBY
expect_no_corrections
end
it 'in a module with declarative private' do
expect_offense(<<~RUBY)
module Test
extend self
^^^^^^^^^^^ Do not use `module_function` or `extend self`.
def test; end
private :test
end
RUBY
expect_no_corrections
end
end
it 'accepts `extend self` in a class' do
expect_no_offenses(<<~RUBY)
class Test
extend self
end
RUBY
end
it 'registers an offense for `module_function` without an argument' do
expect_offense(<<~RUBY)
module Test
module_function
^^^^^^^^^^^^^^^ Do not use `module_function` or `extend self`.
def test; end
end
RUBY
expect_no_corrections
end
end
end