/
class_equality_comparison_spec.rb
83 lines (69 loc) · 2.21 KB
/
class_equality_comparison_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
# frozen_string_literal: true
RSpec.describe RuboCop::Cop::Style::ClassEqualityComparison, :config do
let(:cop_config) do
{ 'IgnoredMethods' => [] }
end
it 'registers an offense and corrects when comparing class using `==` for equality' do
expect_offense(<<~RUBY)
var.class == Date
^^^^^^^^^^^^^ Use `instance_of?(Date)` instead of comparing classes.
RUBY
expect_correction(<<~RUBY)
var.instance_of?(Date)
RUBY
end
it 'registers an offense and corrects when comparing class using `equal?` for equality' do
expect_offense(<<~RUBY)
var.class.equal?(Date)
^^^^^^^^^^^^^^^^^^ Use `instance_of?(Date)` instead of comparing classes.
RUBY
expect_correction(<<~RUBY)
var.instance_of?(Date)
RUBY
end
it 'registers an offense and corrects when comparing class using `eql?` for equality' do
expect_offense(<<~RUBY)
var.class.eql?(Date)
^^^^^^^^^^^^^^^^ Use `instance_of?(Date)` instead of comparing classes.
RUBY
expect_correction(<<~RUBY)
var.instance_of?(Date)
RUBY
end
it 'registers an offense and corrects when comparing single quoted class name for equality' do
expect_offense(<<~RUBY)
var.class.name == 'Date'
^^^^^^^^^^^^^^^^^^^^ Use `instance_of?(Date)` instead of comparing classes.
RUBY
expect_correction(<<~RUBY)
var.instance_of?(Date)
RUBY
end
it 'registers an offense and corrects when comparing double quoted class name for equality' do
expect_offense(<<~RUBY)
var.class.name == "Date"
^^^^^^^^^^^^^^^^^^^^ Use `instance_of?(Date)` instead of comparing classes.
RUBY
expect_correction(<<~RUBY)
var.instance_of?(Date)
RUBY
end
it 'does not register an offense when using `instance_of?`' do
expect_no_offenses(<<~RUBY)
var.instance_of?(Date)
RUBY
end
context 'when IgnoredMethods is specified' do
let(:cop_config) do
{ 'IgnoredMethods' => ['=='] }
end
it 'does not register an offense when comparing class for equality' do
expect_no_offenses(<<~RUBY)
def ==(other)
self.class == other.class &&
name == other.name
end
RUBY
end
end
end