diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index d6a65b65..3846efa0 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -14,4 +14,4 @@ InternalAffairs/MethodNameEqual: # Offense count: 1 # Configuration parameters: CountComments. Metrics/ClassLength: - Max: 104 + Max: 106 diff --git a/lib/rubocop/cop/rspec_rails/http_status.rb b/lib/rubocop/cop/rspec_rails/http_status.rb index 32a4dbd1..342675b5 100644 --- a/lib/rubocop/cop/rspec_rails/http_status.rb +++ b/lib/rubocop/cop/rspec_rails/http_status.rb @@ -31,6 +31,7 @@ module Rails # it { is_expected.to have_http_status :error } # class HttpStatus < Cop + extend AutoCorrector include ConfigurableEnforcedStyle def_node_matcher :http_status, <<-PATTERN @@ -42,14 +43,9 @@ def on_send(node) checker = checker_class.new(ast_node) return unless checker.offensive? - add_offense(checker.node, message: checker.message) - end - end - - def autocorrect(node) - lambda do |corrector| - checker = checker_class.new(node) - corrector.replace(node.loc.expression, checker.preferred_style) + add_offense(checker.node, message: checker.message) do |corrector| + corrector.replace(checker.node, checker.preferred_style) + end end end diff --git a/rubocop-rspec_rails.gemspec b/rubocop-rspec_rails.gemspec index 48af29b1..fb0299e7 100644 --- a/rubocop-rspec_rails.gemspec +++ b/rubocop-rspec_rails.gemspec @@ -36,7 +36,7 @@ Gem::Specification.new do |spec| 'documentation_uri' => 'https://rubocop-rspec.readthedocs.io/' } - spec.add_runtime_dependency 'rubocop', '>= 0.68.1' + spec.add_runtime_dependency 'rubocop', '>= 0.87.0' spec.add_development_dependency 'rack' spec.add_development_dependency 'rake' diff --git a/tasks/cops_documentation.rake b/tasks/cops_documentation.rake index 8b06365f..2f0ced81 100644 --- a/tasks/cops_documentation.rake +++ b/tasks/cops_documentation.rake @@ -40,7 +40,7 @@ task generate_cops_documentation: :yard_for_generate_documentation do ] config = config.for_cop(cop) safe_auto_correct = config.fetch('SafeAutoCorrect', true) - autocorrect = if cop.new.support_autocorrect? + autocorrect = if cop.support_autocorrect? "Yes #{'(Unsafe)' unless safe_auto_correct}" else 'No'