Cop idea: Disallowed list of spec conditions

[gaffneyc]

We have some rspec hooks which we use for debugging and don't want committed. It would be useful to have a cop which checks for those options (conditions? filters? I'm not sure on the naming). This is similar to the RSpec/Focus cop but more general and allows for a list of options.

For our use case we would only need to disallow option names without checking values (e.g. :headless, headless: true, and headless: false would all be violations).

Describe the solution you'd like

RSpec.configure do |config|
  # Allow a test to be run in the foreground for debugging
  config.before(:each, type: :system, headless: false) do
    driven_by :selenium_chrome
  end
end

RSpec.describe "foo" do
  # bad: headless not allowed
  it "does a thing", headless: false do
  end
end

[pirj]

It would fail on CI anyway, won’t it?

[gaffneyc]

In the case of headless it may or it may not but either way it is something we don't want to commit and would ideally be caught in linting.

Another example that wouldn't fail on CI but we still don't want to commit would be :debug which enables debug logging for a specific spec we're investigating.

[pirj]

Should be easy to implement. Parts could be borrowed/extracted from the Focus cop,

rubocop-rspec/lib/rubocop/cop/rspec/focus.rb

Line 71 in 7b930a0

def_node_matcher :metadata, <<-PATTERN

A PR is welcome.