Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial Incorrect Flag/Bug: RSpec/MissingExampleGroupArgument #1712

Open
luke-hill opened this issue Sep 11, 2023 · 1 comment
Open

Partial Incorrect Flag/Bug: RSpec/MissingExampleGroupArgument #1712

luke-hill opened this issue Sep 11, 2023 · 1 comment

Comments

@luke-hill
Copy link
Contributor

This cop "arguably" incorrectly flags methods that are called feature (And probably others), that take no arguments but take a block. One such example is in cucumber-ruby-core

We have many method call-chains that look like the following... (I won't post all examples)

gherkin = gherkin('features/foo.feature') do
              feature do
                scenario do
                  step 'text'
                end
              end
            end

Would there be some way to not flag this. Possible suggestions are...

  • Only detect at top of file?
  • Provide an exclusion list for names (feature/specify/describe/context/it)
  • Something else?
@luke-hill
Copy link
Contributor Author

luke-hill commented Sep 12, 2023

For context this is related to #1719

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant