Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include config/obsoletion.yml in the gemspec #1383

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

hosamaly
Copy link
Contributor

Fix #1382


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Updated documentation.
  • Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

Copy link
Collaborator

@bquorning bquorning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @hosamaly and @guillaumewrobel 👍🏼

@bquorning bquorning merged commit 6c040b4 into rubocop:master Sep 12, 2022
@hosamaly hosamaly deleted the patch-1 branch September 12, 2022 14:51
@hosamaly
Copy link
Contributor Author

Thanks for merging, @bquorning. It would be great if this could be released soon as it's blocking some CI pipelines.

@bquorning
Copy link
Collaborator

Yep, I was just checking locally against a large-ish repository to see if there should be any more errors. A release should be out in 5–10 minutes.

However I can recommend locking the version of your dependencies (including rubocop-rspec) so that you’re not blocked my upstream errors like these. This is open source, and we make no guarantees about how fast bugs are fixed.

@hosamaly
Copy link
Contributor Author

Thanks, @bquorning. Much appreciated.

@bquorning
Copy link
Collaborator

v2.13.1 is released 📦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing config/obsoletion.yml
2 participants