Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: User newer Rubies & reword job names #1380

Merged
merged 1 commit into from
Sep 12, 2022
Merged

CI: User newer Rubies & reword job names #1380

merged 1 commit into from
Sep 12, 2022

Conversation

bquorning
Copy link
Collaborator

@bquorning bquorning commented Sep 10, 2022

You decide: Which version is easier to read?

Before After
image image

Of course, renaming required checks means all open pull requests need to be rebased.


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Updated documentation.
  • Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

@bquorning bquorning force-pushed the ci-config branch 2 times, most recently from e153f18 to 19d52ef Compare September 10, 2022 19:53
@bquorning bquorning marked this pull request as ready for review September 10, 2022 19:57
@ydah
Copy link
Member

ydah commented Sep 11, 2022

I too think the After looks better and easy to see 😀

@bquorning
Copy link
Collaborator Author

There we go: As I have renamed some of the required checks, so all open pull requests need to be rebased.

@bquorning bquorning merged commit 0fd509d into master Sep 12, 2022
@bquorning bquorning deleted the ci-config branch September 12, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants